GDevStore: remove extra Map lookup

Change-Id: Ib7a234d0b0a69a7fbc7e8a75199ad58d52b7c411

@@ -230,9 +230,10 @@ public class GossipDeviceStore
         final Timestamped<DeviceDescription> deltaDesc = new Timestamped<>(deviceDescription, newTimestamp);
         final Timestamped<DeviceDescription> deltaDesc = new Timestamped<>(deviceDescription, newTimestamp);
         final DeviceEvent event;
         final DeviceEvent event;
         final Timestamped<DeviceDescription> mergedDesc;
         final Timestamped<DeviceDescription> mergedDesc;
-        synchronized (getOrCreateDeviceDescriptionsMap(deviceId)) {
+        final Map<ProviderId, DeviceDescriptions> device = getOrCreateDeviceDescriptionsMap(deviceId);
+        synchronized (device) {
             event = createOrUpdateDeviceInternal(providerId, deviceId, deltaDesc);
             event = createOrUpdateDeviceInternal(providerId, deviceId, deltaDesc);
-            mergedDesc = getOrCreateDeviceDescriptionsMap(deviceId).get(providerId).getDeviceDesc();
+            mergedDesc = device.get(providerId).getDeviceDesc();
         }
         }
         if (event != null) {
         if (event != null) {
             log.info("Notifying peers of a device update topology event for providerId: {} and deviceId: {}",
             log.info("Notifying peers of a device update topology event for providerId: {} and deviceId: {}",
@@ -252,10 +253,10 @@ public class GossipDeviceStore
                                     Timestamped<DeviceDescription> deltaDesc) {
                                     Timestamped<DeviceDescription> deltaDesc) {
 
 
         // Collection of DeviceDescriptions for a Device
         // Collection of DeviceDescriptions for a Device
-        Map<ProviderId, DeviceDescriptions> providerDescs
+        Map<ProviderId, DeviceDescriptions> device
             = getOrCreateDeviceDescriptionsMap(deviceId);
             = getOrCreateDeviceDescriptionsMap(deviceId);
 
 
-        synchronized (providerDescs) {
+        synchronized (device) {
             // locking per device
             // locking per device
 
 
             if (isDeviceRemoved(deviceId, deltaDesc.timestamp())) {
             if (isDeviceRemoved(deviceId, deltaDesc.timestamp())) {
@@ -263,7 +264,7 @@ public class GossipDeviceStore
                 return null;
                 return null;
             }
             }
 
 
-            DeviceDescriptions descs = getOrCreateProviderDeviceDescriptions(providerDescs, providerId, deltaDesc);
+            DeviceDescriptions descs = getOrCreateProviderDeviceDescriptions(device, providerId, deltaDesc);
 
 
             final Device oldDevice = devices.get(deviceId);
             final Device oldDevice = devices.get(deviceId);
             final Device newDevice;
             final Device newDevice;
@@ -272,7 +273,7 @@ public class GossipDeviceStore
                 deltaDesc.isNewer(descs.getDeviceDesc())) {
                 deltaDesc.isNewer(descs.getDeviceDesc())) {
                 // on new device or valid update
                 // on new device or valid update
                 descs.putDeviceDesc(deltaDesc);
                 descs.putDeviceDesc(deltaDesc);
-                newDevice = composeDevice(deviceId, providerDescs);
+                newDevice = composeDevice(deviceId, device);
             } else {
             } else {
                 // outdated event, ignored.
                 // outdated event, ignored.
                 return null;
                 return null;
@@ -444,9 +445,10 @@ public class GossipDeviceStore
         final List<DeviceEvent> events;
         final List<DeviceEvent> events;
         final Timestamped<List<PortDescription>> merged;
         final Timestamped<List<PortDescription>> merged;
 
 
-        synchronized (getOrCreateDeviceDescriptionsMap(deviceId)) {
+        final Map<ProviderId, DeviceDescriptions> device = getOrCreateDeviceDescriptionsMap(deviceId);
+        synchronized (device) {
             events = updatePortsInternal(providerId, deviceId, timestampedInput);
             events = updatePortsInternal(providerId, deviceId, timestampedInput);
-            final DeviceDescriptions descs = getOrCreateDeviceDescriptionsMap(deviceId).get(providerId);
+            final DeviceDescriptions descs = device.get(providerId);
             List<PortDescription> mergedList =
             List<PortDescription> mergedList =
                     FluentIterable.from(portDescriptions)
                     FluentIterable.from(portDescriptions)
                 .transform(new Function<PortDescription, PortDescription>() {
                 .transform(new Function<PortDescription, PortDescription>() {
@@ -632,9 +634,10 @@ public class GossipDeviceStore
             = new Timestamped<>(portDescription, newTimestamp);
             = new Timestamped<>(portDescription, newTimestamp);
         final DeviceEvent event;
         final DeviceEvent event;
         final Timestamped<PortDescription> mergedDesc;
         final Timestamped<PortDescription> mergedDesc;
-        synchronized (getOrCreateDeviceDescriptionsMap(deviceId)) {
+        final Map<ProviderId, DeviceDescriptions> device = getOrCreateDeviceDescriptionsMap(deviceId);
+        synchronized (device) {
             event = updatePortStatusInternal(providerId, deviceId, deltaDesc);
             event = updatePortStatusInternal(providerId, deviceId, deltaDesc);
-            mergedDesc = getOrCreateDeviceDescriptionsMap(deviceId).get(providerId)
+            mergedDesc = device.get(providerId)
                             .getPortDesc(portDescription.portNumber());
                             .getPortDesc(portDescription.portNumber());
         }
         }
         if (event != null) {
         if (event != null) {