More IO loop work.

 package org.onlab.nio;
 package org.onlab.nio;
 
 
+import org.onlab.util.Counter;
 import org.slf4j.Logger;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.slf4j.LoggerFactory;
 
 
@@ -40,6 +41,10 @@ public abstract class MessageStream<M extends Message> {
     private Exception ioError;
     private Exception ioError;
     private long lastActiveTime;
     private long lastActiveTime;
 
 
+    private final Counter bytesIn = new Counter();
+    private final Counter messagesIn = new Counter();
+    private final Counter bytesOut = new Counter();
+    private final Counter messagesOut = new Counter();
 
 
     /**
     /**
      * Creates a message stream associated with the specified IO loop and
      * Creates a message stream associated with the specified IO loop and
@@ -93,6 +98,11 @@ public abstract class MessageStream<M extends Message> {
             closed = true;
             closed = true;
         }
         }
 
 
+        bytesIn.freeze();
+        bytesOut.freeze();
+        messagesIn.freeze();
+        messagesOut.freeze();
+
         loop.removeStream(this);
         loop.removeStream(this);
         if (key != null) {
         if (key != null) {
             try {
             try {
@@ -176,6 +186,8 @@ public abstract class MessageStream<M extends Message> {
                 inbound.flip();
                 inbound.flip();
                 while ((message = read(inbound)) != null) {
                 while ((message = read(inbound)) != null) {
                     messages.add(message);
                     messages.add(message);
+                    messagesIn.add(1);
+                    bytesIn.add(message.length());
                 }
                 }
                 inbound.compact();
                 inbound.compact();
 
 
@@ -226,8 +238,9 @@ public abstract class MessageStream<M extends Message> {
         while (outbound.remaining() < message.length()) {
         while (outbound.remaining() < message.length()) {
             doubleSize();
             doubleSize();
         }
         }
-        // Place the message into the buffer and bump the output trackers.
         write(message, outbound);
         write(message, outbound);
+        messagesOut.add(1);
+        bytesOut.add(message.length());
     }
     }
 
 
     // Forces a flush, unless one is planned already.
     // Forces a flush, unless one is planned already.
@@ -273,6 +286,18 @@ public abstract class MessageStream<M extends Message> {
         }
         }
     }
     }
 
 
+
+    /**
+     * Indicates whether data has been written but not flushed yet.
+     *
+     * @return true if flush is required
+     */
+    boolean isFlushRequired() {
+        synchronized (this) {
+            return outbound.position() > 0;
+        }
+    }
+
     /**
     /**
      * Attempts to flush data, internal stream state and channel availability
      * Attempts to flush data, internal stream state and channel availability
      * permitting. Invoked by the driver I/O loop during handling of writable
      * permitting. Invoked by the driver I/O loop during handling of writable
@@ -344,4 +369,40 @@ public abstract class MessageStream<M extends Message> {
         return currentTimeMillis() - lastActiveTime > maxIdleMillis() && key != null;
         return currentTimeMillis() - lastActiveTime > maxIdleMillis() && key != null;
     }
     }
 
 
+    /**
+     * Returns the inbound bytes counter.
+     *
+     * @return inbound bytes counter
+     */
+    public Counter bytesIn() {
+        return bytesIn;
+    }
+
+    /**
+     * Returns the outbound bytes counter.
+     *
+     * @return outbound bytes counter
+     */
+    public Counter bytesOut() {
+        return bytesOut;
+    }
+
+    /**
+     * Returns the inbound messages counter.
+     *
+     * @return inbound messages counter
+     */
+    public Counter messagesIn() {
+        return messagesIn;
+    }
+
+    /**
+     * Returns the outbound messages counter.
+     *
+     * @return outbound messages counter
+     */
+    public Counter messagesOut() {
+        return messagesOut;
+    }
+
 }
 }

+/**
+ * Mechanism to transfer messages over network using IO loop and
+ * message stream, backed by NIO byte buffers.
+ */
+package org.onlab.nio;
\ No newline at end of file

 package org.onlab.nio;
 package org.onlab.nio;
 
 
+import org.onlab.util.Counter;
 import org.slf4j.Logger;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.slf4j.LoggerFactory;
 
 
@@ -10,6 +11,7 @@ import java.net.SocketAddress;
 import java.nio.channels.ByteChannel;
 import java.nio.channels.ByteChannel;
 import java.nio.channels.SelectionKey;
 import java.nio.channels.SelectionKey;
 import java.nio.channels.SocketChannel;
 import java.nio.channels.SocketChannel;
+import java.text.DecimalFormat;
 import java.util.ArrayList;
 import java.util.ArrayList;
 import java.util.List;
 import java.util.List;
 import java.util.concurrent.ExecutionException;
 import java.util.concurrent.ExecutionException;
@@ -26,9 +28,9 @@ import static org.onlab.util.Tools.namedThreads;
 /**
 /**
  * Auxiliary test fixture to measure speed of NIO-based channels.
  * Auxiliary test fixture to measure speed of NIO-based channels.
  */
  */
-public class StandaloneSpeedClient {
+public class IOLoopClient {
 
 
-    private static Logger log = LoggerFactory.getLogger(StandaloneSpeedClient.class);
+    private static Logger log = LoggerFactory.getLogger(IOLoopClient.class);
 
 
     private final InetAddress ip;
     private final InetAddress ip;
     private final int port;
     private final int port;
@@ -39,8 +41,8 @@ public class StandaloneSpeedClient {
     private final ExecutorService ipool;
     private final ExecutorService ipool;
     private final ExecutorService wpool;
     private final ExecutorService wpool;
 
 
-//    ThroughputTracker messages;
-//    ThroughputTracker bytes;
+    Counter messages;
+    Counter bytes;
 
 
     /**
     /**
      * Main entry point to launch the client.
      * Main entry point to launch the client.
@@ -61,7 +63,7 @@ public class StandaloneSpeedClient {
 
 
         log.info("Setting up client with {} workers sending {} {}-byte messages to {} server... ",
         log.info("Setting up client with {} workers sending {} {}-byte messages to {} server... ",
                  wc, mc, ml, ip);
                  wc, mc, ml, ip);
-        StandaloneSpeedClient sc = new StandaloneSpeedClient(ip, wc, mc, ml, StandaloneSpeedServer.PORT);
+        IOLoopClient sc = new IOLoopClient(ip, wc, mc, ml, IOLoopServer.PORT);
 
 
         sc.start();
         sc.start();
         delay(2000);
         delay(2000);
@@ -82,7 +84,7 @@ public class StandaloneSpeedClient {
      * @param port socket port
      * @param port socket port
      * @throws IOException if unable to create IO loops
      * @throws IOException if unable to create IO loops
      */
      */
-    public StandaloneSpeedClient(InetAddress ip, int wc, int mc, int ml, int port) throws IOException {
+    public IOLoopClient(InetAddress ip, int wc, int mc, int ml, int port) throws IOException {
         this.ip = ip;
         this.ip = ip;
         this.port = port;
         this.port = port;
         this.msgCount = mc;
         this.msgCount = mc;
@@ -101,15 +103,15 @@ public class StandaloneSpeedClient {
      * @throws IOException if unable to open connection
      * @throws IOException if unable to open connection
      */
      */
     public void start() throws IOException {
     public void start() throws IOException {
-//        messages = new ThroughputTracker();
-//        bytes = new ThroughputTracker();
+        messages = new Counter();
+        bytes = new Counter();
 
 
         // First start up all the IO loops
         // First start up all the IO loops
         for (CustomIOLoop l : iloops) {
         for (CustomIOLoop l : iloops) {
             ipool.execute(l);
             ipool.execute(l);
         }
         }
 
 
-//        // Wait for all of them to get going
+        // Wait for all of them to get going
 //        for (CustomIOLoop l : iloops)
 //        for (CustomIOLoop l : iloops)
 //            l.waitForStart(TIMEOUT);
 //            l.waitForStart(TIMEOUT);
 
 
@@ -151,20 +153,20 @@ public class StandaloneSpeedClient {
                 l.worker.task.get(secs, TimeUnit.SECONDS);
                 l.worker.task.get(secs, TimeUnit.SECONDS);
             }
             }
         }
         }
-//        messages.freeze();
-//        bytes.freeze();
+        messages.freeze();
+        bytes.freeze();
     }
     }
 
 
     /**
     /**
      * Reports on the accumulated throughput trackers.
      * Reports on the accumulated throughput trackers.
      */
      */
     public void report() {
     public void report() {
-//        DecimalFormat f = new DecimalFormat("#,##0");
-//        log.info("{} messages; {} bytes; {} mps; {} Mbs",
-//                 f.format(messages.total()),
-//                 f.format(bytes.total()),
-//                 f.format(messages.throughput()),
-//                 f.format(bytes.throughput() / (1024 * 128)));
+        DecimalFormat f = new DecimalFormat("#,##0");
+        log.info("{} messages; {} bytes; {} mps; {} Mbs",
+                 f.format(messages.total()),
+                 f.format(bytes.total()),
+                 f.format(messages.throughput()),
+                 f.format(bytes.throughput() / (1024 * 128)));
     }
     }
 
 
 
 
@@ -187,16 +189,16 @@ public class StandaloneSpeedClient {
         protected synchronized void removeStream(MessageStream<TestMessage> b) {
         protected synchronized void removeStream(MessageStream<TestMessage> b) {
             super.removeStream(b);
             super.removeStream(b);
 
 
-//            messages.add(b.inMessages().total());
-//            bytes.add(b.inBytes().total());
-//            b.inMessages().reset();
-//            b.inBytes().reset();
-
-//            log.info("Disconnected client; inbound {} mps, {} Mbps; outbound {} mps, {} Mbps",
-//                     StandaloneSpeedServer.format.format(b.inMessages().throughput()),
-//                     StandaloneSpeedServer.format.format(b.inBytes().throughput() / (1024 * 128)),
-//                     StandaloneSpeedServer.format.format(b.outMessages().throughput()),
-//                     StandaloneSpeedServer.format.format(b.outBytes().throughput() / (1024 * 128)));
+            messages.add(b.messagesIn().total());
+            bytes.add(b.bytesIn().total());
+            b.messagesOut().reset();
+            b.bytesOut().reset();
+//
+            log.info("Disconnected client; inbound {} mps, {} Mbps; outbound {} mps, {} Mbps",
+                     IOLoopServer.FORMAT.format(b.messagesIn().throughput()),
+                     IOLoopServer.FORMAT.format(b.bytesIn().throughput() / (1024 * 128)),
+                     IOLoopServer.FORMAT.format(b.messagesOut().throughput()),
+                     IOLoopServer.FORMAT.format(b.bytesOut().throughput() / (1024 * 128)));
         }
         }
 
 
         @Override
         @Override

@@ -48,11 +48,11 @@ public class IOLoopIntegrationTest {
 
 
         // Setup the test on a random port to avoid intermittent test failures
         // Setup the test on a random port to avoid intermittent test failures
         // due to the port being already bound.
         // due to the port being already bound.
-        int port = StandaloneSpeedServer.PORT + new Random().nextInt(100);
+        int port = IOLoopServer.PORT + new Random().nextInt(100);
 
 
         InetAddress ip = InetAddress.getLoopbackAddress();
         InetAddress ip = InetAddress.getLoopbackAddress();
-        StandaloneSpeedServer sss = new StandaloneSpeedServer(ip, THREADS, size, port);
-        StandaloneSpeedClient ssc = new StandaloneSpeedClient(ip, THREADS, count, size, port);
+        IOLoopServer sss = new IOLoopServer(ip, THREADS, size, port);
+        IOLoopClient ssc = new IOLoopClient(ip, THREADS, count, size, port);
 
 
         sss.start();
         sss.start();
         ssc.start();
         ssc.start();
@@ -64,32 +64,6 @@ public class IOLoopIntegrationTest {
         delay(1000);
         delay(1000);
         sss.stop();
         sss.stop();
         sss.report();
         sss.report();
-
-        // Note that the client and server will have potentially significantly
-        // differing rates. This is due to the wide variance in how tightly
-        // the throughput tracking starts & stops relative to to the short
-        // test duration.
-//        System.out.println(f.format(ssc.messages.throughput()) + " mps");
-
-//        // Make sure client sent everything.
-//        assertEquals("incorrect client message count sent",
-//                     (long) count * THREADS, ssc.messages.total());
-//        assertEquals("incorrect client bytes count sent",
-//                     (long) size * count * THREADS, ssc.bytes.total());
-//
-//        // Make sure server received everything.
-//        assertEquals("incorrect server message count received",
-//                     (long) count * THREADS, sss.messages.total());
-//        assertEquals("incorrect server bytes count received",
-//                     (long) size * count * THREADS, sss.bytes.total());
-//
-//        // Make sure speeds were reasonable.
-//        if (mps > 0.0) {
-//            assertAboveThreshold("insufficient client speed", mps,
-//                                 ssc.messages.throughput());
-//            assertAboveThreshold("insufficient server speed", mps / 2,
-//                                 sss.messages.throughput());
-//        }
     }
     }
 
 
 }
 }

 package org.onlab.nio;
 package org.onlab.nio;
 
 
+import org.onlab.util.Counter;
 import org.slf4j.Logger;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.slf4j.LoggerFactory;
 
 
@@ -23,9 +24,9 @@ import static org.onlab.util.Tools.namedThreads;
 /**
 /**
  * Auxiliary test fixture to measure speed of NIO-based channels.
  * Auxiliary test fixture to measure speed of NIO-based channels.
  */
  */
-public class StandaloneSpeedServer {
+public class IOLoopServer {
 
 
-    private static Logger log = LoggerFactory.getLogger(StandaloneSpeedServer.class);
+    private static Logger log = LoggerFactory.getLogger(IOLoopServer.class);
 
 
     private static final int PRUNE_FREQUENCY = 1000;
     private static final int PRUNE_FREQUENCY = 1000;
 
 
@@ -48,8 +49,8 @@ public class StandaloneSpeedServer {
     private final int msgLength;
     private final int msgLength;
     private int lastWorker = -1;
     private int lastWorker = -1;
 
 
-//    ThroughputTracker messages;
-//    ThroughputTracker bytes;
+    Counter messages;
+    Counter bytes;
 
 
     /**
     /**
      * Main entry point to launch the server.
      * Main entry point to launch the server.
@@ -64,7 +65,7 @@ public class StandaloneSpeedServer {
 
 
         log.info("Setting up the server with {} workers, {} byte messages on {}... ",
         log.info("Setting up the server with {} workers, {} byte messages on {}... ",
                  wc, ml, ip);
                  wc, ml, ip);
-        StandaloneSpeedServer ss = new StandaloneSpeedServer(ip, wc, ml, PORT);
+        IOLoopServer ss = new IOLoopServer(ip, wc, ml, PORT);
         ss.start();
         ss.start();
 
 
         // Start pruning clients.
         // Start pruning clients.
@@ -83,7 +84,7 @@ public class StandaloneSpeedServer {
      * @param port listen port
      * @param port listen port
      * @throws IOException if unable to create IO loops
      * @throws IOException if unable to create IO loops
      */
      */
-    public StandaloneSpeedServer(InetAddress ip, int wc, int ml, int port) throws IOException {
+    public IOLoopServer(InetAddress ip, int wc, int ml, int port) throws IOException {
         this.workerCount = wc;
         this.workerCount = wc;
         this.msgLength = ml;
         this.msgLength = ml;
         this.ipool = Executors.newFixedThreadPool(workerCount, namedThreads("io-loop"));
         this.ipool = Executors.newFixedThreadPool(workerCount, namedThreads("io-loop"));
@@ -98,14 +99,14 @@ public class StandaloneSpeedServer {
      * Start the server IO loops and kicks off throughput tracking.
      * Start the server IO loops and kicks off throughput tracking.
      */
      */
     public void start() {
     public void start() {
-//        messages = new ThroughputTracker();
-//        bytes = new ThroughputTracker();
+        messages = new Counter();
+        bytes = new Counter();
 
 
         for (CustomIOLoop l : iloops) {
         for (CustomIOLoop l : iloops) {
             ipool.execute(l);
             ipool.execute(l);
         }
         }
         apool.execute(aloop);
         apool.execute(aloop);
-//
+
 //        for (CustomIOLoop l : iloops)
 //        for (CustomIOLoop l : iloops)
 //            l.waitForStart(TIMEOUT);
 //            l.waitForStart(TIMEOUT);
 //        aloop.waitForStart(TIMEOUT);
 //        aloop.waitForStart(TIMEOUT);
@@ -124,20 +125,20 @@ public class StandaloneSpeedServer {
 //            l.waitForFinish(TIMEOUT);
 //            l.waitForFinish(TIMEOUT);
 //        aloop.waitForFinish(TIMEOUT);
 //        aloop.waitForFinish(TIMEOUT);
 //
 //
-//        messages.freeze();
-//        bytes.freeze();
+        messages.freeze();
+        bytes.freeze();
     }
     }
 
 
     /**
     /**
      * Reports on the accumulated throughput trackers.
      * Reports on the accumulated throughput trackers.
      */
      */
     public void report() {
     public void report() {
-//        DecimalFormat f = new DecimalFormat("#,##0");
-//        log.info("{} messages; {} bytes; {} mps; {} Mbs",
-//                 f.format(messages.total()),
-//                 f.format(bytes.total()),
-//                 f.format(messages.throughput()),
-//                 f.format(bytes.throughput() / (1024 * 128)));
+        DecimalFormat f = new DecimalFormat("#,##0");
+        log.info("{} messages; {} bytes; {} mps; {} Mbs",
+                 f.format(messages.total()),
+                 f.format(bytes.total()),
+                 f.format(messages.throughput()),
+                 f.format(bytes.throughput() / (1024 * 128)));
     }
     }
 
 
     /**
     /**
@@ -170,15 +171,15 @@ public class StandaloneSpeedServer {
         @Override
         @Override
         protected void removeStream(MessageStream<TestMessage> stream) {
         protected void removeStream(MessageStream<TestMessage> stream) {
             super.removeStream(stream);
             super.removeStream(stream);
-//
-//            messages.add(b.inMessages().total());
-//            bytes.add(b.inBytes().total());
-//
-//            log.info("Disconnected client; inbound {} mps, {} Mbps; outbound {} mps, {} Mbps",
-//                     format.format(b.inMessages().throughput()),
-//                     format.format(b.inBytes().throughput() / (1024 * 128)),
-//                     format.format(b.outMessages().throughput()),
-//                     format.format(b.outBytes().throughput() / (1024 * 128)));
+
+            messages.add(stream.messagesIn().total());
+            bytes.add(stream.bytesIn().total());
+
+            log.info("Disconnected client; inbound {} mps, {} Mbps; outbound {} mps, {} Mbps",
+                     FORMAT.format(stream.messagesIn().throughput()),
+                     FORMAT.format(stream.bytesIn().throughput() / (1024 * 128)),
+                     FORMAT.format(stream.messagesOut().throughput()),
+                     FORMAT.format(stream.bytesOut().throughput() / (1024 * 128)));
         }
         }
 
 
         @Override
         @Override

@@ -23,57 +23,36 @@ import static org.junit.Assert.assertNull;
  */
  */
 public class MessageStreamTest {
 public class MessageStreamTest {
 
 
-    private static final int LENGTH = 16;
-
-    private static final TestMessage TM1 = new TestMessage(LENGTH);
-    private static final TestMessage TM2 = new TestMessage(LENGTH);
-    private static final TestMessage TM3 = new TestMessage(LENGTH);
-    private static final TestMessage TM4 = new TestMessage(LENGTH);
+    private static final int SIZE = 16;
+    private static final TestMessage MESSAGE = new TestMessage(SIZE);
 
 
     private static final int BIG_SIZE = 32 * 1024;
     private static final int BIG_SIZE = 32 * 1024;
     private static final TestMessage BIG_MESSAGE = new TestMessage(BIG_SIZE);
     private static final TestMessage BIG_MESSAGE = new TestMessage(BIG_SIZE);
 
 
-    private static enum WritePending {
-        ON, OFF;
-
-        public boolean on() {
-            return this == ON;
-        }
-    }
-
-    private static enum FlushRequired {
-        ON, OFF;
-
-        public boolean on() {
-            return this == ON;
-        }
-    }
-
-    private FakeIOLoop loop;
+    private TestIOLoop loop;
     private TestByteChannel channel;
     private TestByteChannel channel;
-    private TestMessageStream buffer;
+    private TestMessageStream stream;
     private TestKey key;
     private TestKey key;
 
 
     @Before
     @Before
     public void setUp() throws IOException {
     public void setUp() throws IOException {
-        loop = new FakeIOLoop();
+        loop = new TestIOLoop();
         channel = new TestByteChannel();
         channel = new TestByteChannel();
         key = new TestKey(channel);
         key = new TestKey(channel);
-        buffer = loop.createStream(channel);
-        buffer.setKey(key);
+        stream = loop.createStream(channel);
+        stream.setKey(key);
     }
     }
 
 
     @After
     @After
     public void tearDown() {
     public void tearDown() {
         loop.shutdown();
         loop.shutdown();
-        buffer.close();
+        stream.close();
     }
     }
 
 
-    // Check state of the message buffer
-    private void assertState(WritePending wp, FlushRequired fr,
-                             int read, int written) {
-        assertEquals(wp.on(), buffer.isWritePending());
-//        assertEquals(fr.on(), buffer.requiresFlush());
+    // Validates the state of the message stream
+    private void validate(boolean wp, boolean fr, int read, int written) {
+        assertEquals(wp, stream.isWritePending());
+        assertEquals(fr, stream.isFlushRequired());
         assertEquals(read, channel.readBytes);
         assertEquals(read, channel.readBytes);
         assertEquals(written, channel.writtenBytes);
         assertEquals(written, channel.writtenBytes);
     }
     }
@@ -81,155 +60,155 @@ public class MessageStreamTest {
     @Test
     @Test
     public void endOfStream() throws IOException {
     public void endOfStream() throws IOException {
         channel.close();
         channel.close();
-        List<TestMessage> messages = buffer.read();
+        List<TestMessage> messages = stream.read();
         assertNull(messages);
         assertNull(messages);
     }
     }
 
 
     @Test
     @Test
     public void bufferGrowth() throws IOException {
     public void bufferGrowth() throws IOException {
-        // Create a buffer for big messages and test the growth.
-        buffer = new TestMessageStream(BIG_SIZE, channel, loop);
-        buffer.write(BIG_MESSAGE);
-        buffer.write(BIG_MESSAGE);
-        buffer.write(BIG_MESSAGE);
-        buffer.write(BIG_MESSAGE);
-        buffer.write(BIG_MESSAGE);
+        // Create a stream for big messages and test the growth.
+        stream = new TestMessageStream(BIG_SIZE, channel, loop);
+        stream.write(BIG_MESSAGE);
+        stream.write(BIG_MESSAGE);
+        stream.write(BIG_MESSAGE);
+        stream.write(BIG_MESSAGE);
+        stream.write(BIG_MESSAGE);
     }
     }
 
 
     @Test
     @Test
     public void discardBeforeKey() {
     public void discardBeforeKey() {
-        // Create a buffer that does not yet have the key set and discard it.
-        buffer = loop.createStream(channel);
-        assertNull(buffer.key());
-        buffer.close();
+        // Create a stream that does not yet have the key set and discard it.
+        stream = loop.createStream(channel);
+        assertNull(stream.key());
+        stream.close();
         // There is not key, so nothing to check; we just expect no problem.
         // There is not key, so nothing to check; we just expect no problem.
     }
     }
 
 
     @Test
     @Test
     public void bufferedRead() throws IOException {
     public void bufferedRead() throws IOException {
-        channel.bytesToRead = LENGTH + 4;
-        List<TestMessage> messages = buffer.read();
+        channel.bytesToRead = SIZE + 4;
+        List<TestMessage> messages = stream.read();
         assertEquals(1, messages.size());
         assertEquals(1, messages.size());
-        assertState(WritePending.OFF, FlushRequired.OFF, LENGTH + 4, 0);
+        validate(false, false, SIZE + 4, 0);
 
 
-        channel.bytesToRead = LENGTH - 4;
-        messages = buffer.read();
+        channel.bytesToRead = SIZE - 4;
+        messages = stream.read();
         assertEquals(1, messages.size());
         assertEquals(1, messages.size());
-        assertState(WritePending.OFF, FlushRequired.OFF, LENGTH * 2, 0);
+        validate(false, false, SIZE * 2, 0);
     }
     }
 
 
     @Test
     @Test
     public void bufferedWrite() throws IOException {
     public void bufferedWrite() throws IOException {
-        assertState(WritePending.OFF, FlushRequired.OFF, 0, 0);
+        validate(false, false, 0, 0);
 
 
         // First write is immediate...
         // First write is immediate...
-        buffer.write(TM1);
-        assertState(WritePending.OFF, FlushRequired.OFF, 0, LENGTH);
+        stream.write(MESSAGE);
+        validate(false, false, 0, SIZE);
 
 
         // Second and third get buffered...
         // Second and third get buffered...
-        buffer.write(TM2);
-        assertState(WritePending.OFF, FlushRequired.ON, 0, LENGTH);
-        buffer.write(TM3);
-        assertState(WritePending.OFF, FlushRequired.ON, 0, LENGTH);
+        stream.write(MESSAGE);
+        validate(false, true, 0, SIZE);
+        stream.write(MESSAGE);
+        validate(false, true, 0, SIZE);
 
 
         // Reset write, which will flush if needed; the next write is again buffered
         // Reset write, which will flush if needed; the next write is again buffered
-        buffer.flushIfWriteNotPending();
-        assertState(WritePending.OFF, FlushRequired.OFF, 0, LENGTH * 3);
-        buffer.write(TM4);
-        assertState(WritePending.OFF, FlushRequired.ON, 0, LENGTH * 3);
+        stream.flushIfWriteNotPending();
+        validate(false, false, 0, SIZE * 3);
+        stream.write(MESSAGE);
+        validate(false, true, 0, SIZE * 3);
 
 
         // Select reset, which will flush if needed; the next write is again buffered
         // Select reset, which will flush if needed; the next write is again buffered
-        buffer.flushIfPossible();
-        assertState(WritePending.OFF, FlushRequired.OFF, 0, LENGTH * 4);
-        buffer.write(TM1);
-        assertState(WritePending.OFF, FlushRequired.ON, 0, LENGTH * 4);
-        buffer.flush();
-        assertState(WritePending.OFF, FlushRequired.ON, 0, LENGTH * 4);
+        stream.flushIfPossible();
+        validate(false, false, 0, SIZE * 4);
+        stream.write(MESSAGE);
+        validate(false, true, 0, SIZE * 4);
+        stream.flush();
+        validate(false, true, 0, SIZE * 4);
     }
     }
 
 
     @Test
     @Test
     public void bufferedWriteList() throws IOException {
     public void bufferedWriteList() throws IOException {
-        assertState(WritePending.OFF, FlushRequired.OFF, 0, 0);
+        validate(false, false, 0, 0);
 
 
         // First write is immediate...
         // First write is immediate...
-        List<TestMessage> messages = new ArrayList<TestMessage>();
-        messages.add(TM1);
-        messages.add(TM2);
-        messages.add(TM3);
-        messages.add(TM4);
+        List<TestMessage> messages = new ArrayList<>();
+        messages.add(MESSAGE);
+        messages.add(MESSAGE);
+        messages.add(MESSAGE);
+        messages.add(MESSAGE);
 
 
-        buffer.write(messages);
-        assertState(WritePending.OFF, FlushRequired.OFF, 0, LENGTH * 4);
+        stream.write(messages);
+        validate(false, false, 0, SIZE * 4);
 
 
-        buffer.write(messages);
-        assertState(WritePending.OFF, FlushRequired.ON, 0, LENGTH * 4);
+        stream.write(messages);
+        validate(false, true, 0, SIZE * 4);
 
 
-        buffer.flushIfPossible();
-        assertState(WritePending.OFF, FlushRequired.OFF, 0, LENGTH * 8);
+        stream.flushIfPossible();
+        validate(false, false, 0, SIZE * 8);
     }
     }
 
 
     @Test
     @Test
     public void bufferedPartialWrite() throws IOException {
     public void bufferedPartialWrite() throws IOException {
-        assertState(WritePending.OFF, FlushRequired.OFF, 0, 0);
+        validate(false, false, 0, 0);
 
 
         // First write is immediate...
         // First write is immediate...
-        buffer.write(TM1);
-        assertState(WritePending.OFF, FlushRequired.OFF, 0, LENGTH);
+        stream.write(MESSAGE);
+        validate(false, false, 0, SIZE);
 
 
         // Tell test channel to accept only half.
         // Tell test channel to accept only half.
-        channel.bytesToWrite = LENGTH / 2;
+        channel.bytesToWrite = SIZE / 2;
 
 
         // Second and third get buffered...
         // Second and third get buffered...
-        buffer.write(TM2);
-        assertState(WritePending.OFF, FlushRequired.ON, 0, LENGTH);
-        buffer.flushIfPossible();
-        assertState(WritePending.ON, FlushRequired.ON, 0, LENGTH + LENGTH / 2);
+        stream.write(MESSAGE);
+        validate(false, true, 0, SIZE);
+        stream.flushIfPossible();
+        validate(true, true, 0, SIZE + SIZE / 2);
     }
     }
 
 
     @Test
     @Test
     public void bufferedPartialWrite2() throws IOException {
     public void bufferedPartialWrite2() throws IOException {
-        assertState(WritePending.OFF, FlushRequired.OFF, 0, 0);
+        validate(false, false, 0, 0);
 
 
         // First write is immediate...
         // First write is immediate...
-        buffer.write(TM1);
-        assertState(WritePending.OFF, FlushRequired.OFF, 0, LENGTH);
+        stream.write(MESSAGE);
+        validate(false, false, 0, SIZE);
 
 
         // Tell test channel to accept only half.
         // Tell test channel to accept only half.
-        channel.bytesToWrite = LENGTH / 2;
+        channel.bytesToWrite = SIZE / 2;
 
 
         // Second and third get buffered...
         // Second and third get buffered...
-        buffer.write(TM2);
-        assertState(WritePending.OFF, FlushRequired.ON, 0, LENGTH);
-        buffer.flushIfWriteNotPending();
-        assertState(WritePending.ON, FlushRequired.ON, 0, LENGTH + LENGTH / 2);
+        stream.write(MESSAGE);
+        validate(false, true, 0, SIZE);
+        stream.flushIfWriteNotPending();
+        validate(true, true, 0, SIZE + SIZE / 2);
     }
     }
 
 
     @Test
     @Test
     public void bufferedReadWrite() throws IOException {
     public void bufferedReadWrite() throws IOException {
-        channel.bytesToRead = LENGTH + 4;
-        List<TestMessage> messages = buffer.read();
+        channel.bytesToRead = SIZE + 4;
+        List<TestMessage> messages = stream.read();
         assertEquals(1, messages.size());
         assertEquals(1, messages.size());
-        assertState(WritePending.OFF, FlushRequired.OFF, LENGTH + 4, 0);
+        validate(false, false, SIZE + 4, 0);
 
 
-        buffer.write(TM1);
-        assertState(WritePending.OFF, FlushRequired.OFF, LENGTH + 4, LENGTH);
+        stream.write(MESSAGE);
+        validate(false, false, SIZE + 4, SIZE);
 
 
-        channel.bytesToRead = LENGTH - 4;
-        messages = buffer.read();
+        channel.bytesToRead = SIZE - 4;
+        messages = stream.read();
         assertEquals(1, messages.size());
         assertEquals(1, messages.size());
-        assertState(WritePending.OFF, FlushRequired.OFF, LENGTH * 2, LENGTH);
+        validate(false, false, SIZE * 2, SIZE);
     }
     }
 
 
     // Fake IO driver loop
     // Fake IO driver loop
-    private static class FakeIOLoop extends IOLoop<TestMessage, TestMessageStream> {
+    private static class TestIOLoop extends IOLoop<TestMessage, TestMessageStream> {
 
 
-        public FakeIOLoop() throws IOException {
+        public TestIOLoop() throws IOException {
             super(500);
             super(500);
         }
         }
 
 
         @Override
         @Override
         protected TestMessageStream createStream(ByteChannel channel) {
         protected TestMessageStream createStream(ByteChannel channel) {
-            return new TestMessageStream(LENGTH, channel, this);
+            return new TestMessageStream(SIZE, channel, this);
         }
         }
 
 
         @Override
         @Override