Remove "public" to follow our convention
Change-Id: Ic52ca8b1bc5701ec8214ce1110d49511e39b4edb
Showing
6 changed files
with
50 additions
and
50 deletions
... | @@ -28,19 +28,19 @@ public interface OpenFlowController { | ... | @@ -28,19 +28,19 @@ public interface OpenFlowController { |
28 | * Returns all switches known to this OF controller. | 28 | * Returns all switches known to this OF controller. |
29 | * @return Iterable of dpid elements | 29 | * @return Iterable of dpid elements |
30 | */ | 30 | */ |
31 | - public Iterable<OpenFlowSwitch> getSwitches(); | 31 | + Iterable<OpenFlowSwitch> getSwitches(); |
32 | 32 | ||
33 | /** | 33 | /** |
34 | * Returns all master switches known to this OF controller. | 34 | * Returns all master switches known to this OF controller. |
35 | * @return Iterable of dpid elements | 35 | * @return Iterable of dpid elements |
36 | */ | 36 | */ |
37 | - public Iterable<OpenFlowSwitch> getMasterSwitches(); | 37 | + Iterable<OpenFlowSwitch> getMasterSwitches(); |
38 | 38 | ||
39 | /** | 39 | /** |
40 | * Returns all equal switches known to this OF controller. | 40 | * Returns all equal switches known to this OF controller. |
41 | * @return Iterable of dpid elements | 41 | * @return Iterable of dpid elements |
42 | */ | 42 | */ |
43 | - public Iterable<OpenFlowSwitch> getEqualSwitches(); | 43 | + Iterable<OpenFlowSwitch> getEqualSwitches(); |
44 | 44 | ||
45 | 45 | ||
46 | /** | 46 | /** |
... | @@ -48,70 +48,70 @@ public interface OpenFlowController { | ... | @@ -48,70 +48,70 @@ public interface OpenFlowController { |
48 | * @param dpid the switch to fetch | 48 | * @param dpid the switch to fetch |
49 | * @return the interface to this switch | 49 | * @return the interface to this switch |
50 | */ | 50 | */ |
51 | - public OpenFlowSwitch getSwitch(Dpid dpid); | 51 | + OpenFlowSwitch getSwitch(Dpid dpid); |
52 | 52 | ||
53 | /** | 53 | /** |
54 | * Returns the actual master switch for the given Dpid, if one exists. | 54 | * Returns the actual master switch for the given Dpid, if one exists. |
55 | * @param dpid the switch to fetch | 55 | * @param dpid the switch to fetch |
56 | * @return the interface to this switch | 56 | * @return the interface to this switch |
57 | */ | 57 | */ |
58 | - public OpenFlowSwitch getMasterSwitch(Dpid dpid); | 58 | + OpenFlowSwitch getMasterSwitch(Dpid dpid); |
59 | 59 | ||
60 | /** | 60 | /** |
61 | * Returns the actual equal switch for the given Dpid, if one exists. | 61 | * Returns the actual equal switch for the given Dpid, if one exists. |
62 | * @param dpid the switch to fetch | 62 | * @param dpid the switch to fetch |
63 | * @return the interface to this switch | 63 | * @return the interface to this switch |
64 | */ | 64 | */ |
65 | - public OpenFlowSwitch getEqualSwitch(Dpid dpid); | 65 | + OpenFlowSwitch getEqualSwitch(Dpid dpid); |
66 | 66 | ||
67 | /** | 67 | /** |
68 | * Register a listener for meta events that occur to OF | 68 | * Register a listener for meta events that occur to OF |
69 | * devices. | 69 | * devices. |
70 | * @param listener the listener to notify | 70 | * @param listener the listener to notify |
71 | */ | 71 | */ |
72 | - public void addListener(OpenFlowSwitchListener listener); | 72 | + void addListener(OpenFlowSwitchListener listener); |
73 | 73 | ||
74 | /** | 74 | /** |
75 | * Unregister a listener. | 75 | * Unregister a listener. |
76 | * | 76 | * |
77 | * @param listener the listener to unregister | 77 | * @param listener the listener to unregister |
78 | */ | 78 | */ |
79 | - public void removeListener(OpenFlowSwitchListener listener); | 79 | + void removeListener(OpenFlowSwitchListener listener); |
80 | 80 | ||
81 | /** | 81 | /** |
82 | * Register a listener for packet events. | 82 | * Register a listener for packet events. |
83 | * @param priority the importance of this listener, lower values are more important | 83 | * @param priority the importance of this listener, lower values are more important |
84 | * @param listener the listener to notify | 84 | * @param listener the listener to notify |
85 | */ | 85 | */ |
86 | - public void addPacketListener(int priority, PacketListener listener); | 86 | + void addPacketListener(int priority, PacketListener listener); |
87 | 87 | ||
88 | /** | 88 | /** |
89 | * Unregister a listener. | 89 | * Unregister a listener. |
90 | * | 90 | * |
91 | * @param listener the listener to unregister | 91 | * @param listener the listener to unregister |
92 | */ | 92 | */ |
93 | - public void removePacketListener(PacketListener listener); | 93 | + void removePacketListener(PacketListener listener); |
94 | 94 | ||
95 | /** | 95 | /** |
96 | * Register a listener for OF msg events. | 96 | * Register a listener for OF msg events. |
97 | * | 97 | * |
98 | * @param listener the listener to notify | 98 | * @param listener the listener to notify |
99 | */ | 99 | */ |
100 | - public void addEventListener(OpenFlowEventListener listener); | 100 | + void addEventListener(OpenFlowEventListener listener); |
101 | 101 | ||
102 | /** | 102 | /** |
103 | * Unregister a listener. | 103 | * Unregister a listener. |
104 | * | 104 | * |
105 | * @param listener the listener to unregister | 105 | * @param listener the listener to unregister |
106 | */ | 106 | */ |
107 | - public void removeEventListener(OpenFlowEventListener listener); | 107 | + void removeEventListener(OpenFlowEventListener listener); |
108 | 108 | ||
109 | /** | 109 | /** |
110 | * Send a message to a particular switch. | 110 | * Send a message to a particular switch. |
111 | * @param dpid the switch to send to. | 111 | * @param dpid the switch to send to. |
112 | * @param msg the message to send | 112 | * @param msg the message to send |
113 | */ | 113 | */ |
114 | - public void write(Dpid dpid, OFMessage msg); | 114 | + void write(Dpid dpid, OFMessage msg); |
115 | 115 | ||
116 | /** | 116 | /** |
117 | * Process a message and notify the appropriate listeners. | 117 | * Process a message and notify the appropriate listeners. |
... | @@ -119,12 +119,12 @@ public interface OpenFlowController { | ... | @@ -119,12 +119,12 @@ public interface OpenFlowController { |
119 | * @param dpid the dpid the message arrived on | 119 | * @param dpid the dpid the message arrived on |
120 | * @param msg the message to process. | 120 | * @param msg the message to process. |
121 | */ | 121 | */ |
122 | - public void processPacket(Dpid dpid, OFMessage msg); | 122 | + void processPacket(Dpid dpid, OFMessage msg); |
123 | 123 | ||
124 | /** | 124 | /** |
125 | * Sets the role for a given switch. | 125 | * Sets the role for a given switch. |
126 | * @param role the desired role | 126 | * @param role the desired role |
127 | * @param dpid the switch to set the role for. | 127 | * @param dpid the switch to set the role for. |
128 | */ | 128 | */ |
129 | - public void setRole(Dpid dpid, RoleState role); | 129 | + void setRole(Dpid dpid, RoleState role); |
130 | } | 130 | } | ... | ... |
... | @@ -29,5 +29,5 @@ public interface OpenFlowEventListener { | ... | @@ -29,5 +29,5 @@ public interface OpenFlowEventListener { |
29 | * @param dpid switch data path identifier | 29 | * @param dpid switch data path identifier |
30 | * @param msg the message | 30 | * @param msg the message |
31 | */ | 31 | */ |
32 | - public void handleMessage(Dpid dpid, OFMessage msg); | 32 | + void handleMessage(Dpid dpid, OFMessage msg); |
33 | } | 33 | } | ... | ... |
... | @@ -31,56 +31,56 @@ public interface OpenFlowPacketContext { | ... | @@ -31,56 +31,56 @@ public interface OpenFlowPacketContext { |
31 | * packet in event. | 31 | * packet in event. |
32 | * @return true if blocks | 32 | * @return true if blocks |
33 | */ | 33 | */ |
34 | - public boolean block(); | 34 | + boolean block(); |
35 | 35 | ||
36 | /** | 36 | /** |
37 | * Checks whether the packet has been handled. | 37 | * Checks whether the packet has been handled. |
38 | * @return true if handled, false otherwise. | 38 | * @return true if handled, false otherwise. |
39 | */ | 39 | */ |
40 | - public boolean isHandled(); | 40 | + boolean isHandled(); |
41 | 41 | ||
42 | /** | 42 | /** |
43 | * Provided build has been called send the packet | 43 | * Provided build has been called send the packet |
44 | * out the switch it came in on. | 44 | * out the switch it came in on. |
45 | */ | 45 | */ |
46 | - public void send(); | 46 | + void send(); |
47 | 47 | ||
48 | /** | 48 | /** |
49 | * Build the packet out in response to this packet in event. | 49 | * Build the packet out in response to this packet in event. |
50 | * @param outPort the out port to send to packet out of. | 50 | * @param outPort the out port to send to packet out of. |
51 | */ | 51 | */ |
52 | - public void build(OFPort outPort); | 52 | + void build(OFPort outPort); |
53 | 53 | ||
54 | /** | 54 | /** |
55 | * Build the packet out in response to this packet in event. | 55 | * Build the packet out in response to this packet in event. |
56 | * @param ethFrame the actual packet to send out. | 56 | * @param ethFrame the actual packet to send out. |
57 | * @param outPort the out port to send to packet out of. | 57 | * @param outPort the out port to send to packet out of. |
58 | */ | 58 | */ |
59 | - public void build(Ethernet ethFrame, OFPort outPort); | 59 | + void build(Ethernet ethFrame, OFPort outPort); |
60 | 60 | ||
61 | /** | 61 | /** |
62 | * Provided a handle onto the parsed payload. | 62 | * Provided a handle onto the parsed payload. |
63 | * @return the parsed form of the payload. | 63 | * @return the parsed form of the payload. |
64 | */ | 64 | */ |
65 | - public Ethernet parsed(); | 65 | + Ethernet parsed(); |
66 | 66 | ||
67 | /** | 67 | /** |
68 | * Provide an unparsed copy of the data. | 68 | * Provide an unparsed copy of the data. |
69 | * @return the unparsed form of the payload. | 69 | * @return the unparsed form of the payload. |
70 | */ | 70 | */ |
71 | - public byte[] unparsed(); | 71 | + byte[] unparsed(); |
72 | 72 | ||
73 | /** | 73 | /** |
74 | * Provide the dpid of the switch where the packet in arrived. | 74 | * Provide the dpid of the switch where the packet in arrived. |
75 | * @return the dpid of the switch. | 75 | * @return the dpid of the switch. |
76 | */ | 76 | */ |
77 | - public Dpid dpid(); | 77 | + Dpid dpid(); |
78 | 78 | ||
79 | /** | 79 | /** |
80 | * Provide the port on which the packet arrived. | 80 | * Provide the port on which the packet arrived. |
81 | * @return the port | 81 | * @return the port |
82 | */ | 82 | */ |
83 | - public Integer inPort(); | 83 | + Integer inPort(); |
84 | 84 | ||
85 | /** | 85 | /** |
86 | * Indicates that this packet is buffered at the switch. | 86 | * Indicates that this packet is buffered at the switch. | ... | ... |
... | @@ -31,101 +31,101 @@ public interface OpenFlowSwitch { | ... | @@ -31,101 +31,101 @@ public interface OpenFlowSwitch { |
31 | * | 31 | * |
32 | * @param msg the message to write | 32 | * @param msg the message to write |
33 | */ | 33 | */ |
34 | - public void sendMsg(OFMessage msg); | 34 | + void sendMsg(OFMessage msg); |
35 | 35 | ||
36 | /** | 36 | /** |
37 | * Writes the OFMessage list to the driver. | 37 | * Writes the OFMessage list to the driver. |
38 | * | 38 | * |
39 | * @param msgs the messages to be written | 39 | * @param msgs the messages to be written |
40 | */ | 40 | */ |
41 | - public void sendMsg(List<OFMessage> msgs); | 41 | + void sendMsg(List<OFMessage> msgs); |
42 | 42 | ||
43 | /** | 43 | /** |
44 | * Handle a message from the switch. | 44 | * Handle a message from the switch. |
45 | * @param fromSwitch the message to handle | 45 | * @param fromSwitch the message to handle |
46 | */ | 46 | */ |
47 | - public void handleMessage(OFMessage fromSwitch); | 47 | + void handleMessage(OFMessage fromSwitch); |
48 | 48 | ||
49 | /** | 49 | /** |
50 | * Sets the role for this switch. | 50 | * Sets the role for this switch. |
51 | * @param role the role to set. | 51 | * @param role the role to set. |
52 | */ | 52 | */ |
53 | - public void setRole(RoleState role); | 53 | + void setRole(RoleState role); |
54 | 54 | ||
55 | /** | 55 | /** |
56 | * Fetch the role for this switch. | 56 | * Fetch the role for this switch. |
57 | * @return the role. | 57 | * @return the role. |
58 | */ | 58 | */ |
59 | - public RoleState getRole(); | 59 | + RoleState getRole(); |
60 | 60 | ||
61 | /** | 61 | /** |
62 | * Fetches the ports of this switch. | 62 | * Fetches the ports of this switch. |
63 | * @return unmodifiable list of the ports. | 63 | * @return unmodifiable list of the ports. |
64 | */ | 64 | */ |
65 | - public List<OFPortDesc> getPorts(); | 65 | + List<OFPortDesc> getPorts(); |
66 | 66 | ||
67 | /** | 67 | /** |
68 | * Provides the factory for this OF version. | 68 | * Provides the factory for this OF version. |
69 | * @return OF version specific factory. | 69 | * @return OF version specific factory. |
70 | */ | 70 | */ |
71 | - public OFFactory factory(); | 71 | + OFFactory factory(); |
72 | 72 | ||
73 | /** | 73 | /** |
74 | * Gets a string version of the ID for this switch. | 74 | * Gets a string version of the ID for this switch. |
75 | * | 75 | * |
76 | * @return string version of the ID | 76 | * @return string version of the ID |
77 | */ | 77 | */ |
78 | - public String getStringId(); | 78 | + String getStringId(); |
79 | 79 | ||
80 | /** | 80 | /** |
81 | * Gets the datapathId of the switch. | 81 | * Gets the datapathId of the switch. |
82 | * | 82 | * |
83 | * @return the switch dpid in long format | 83 | * @return the switch dpid in long format |
84 | */ | 84 | */ |
85 | - public long getId(); | 85 | + long getId(); |
86 | 86 | ||
87 | /** | 87 | /** |
88 | * fetch the manufacturer description. | 88 | * fetch the manufacturer description. |
89 | * @return the description | 89 | * @return the description |
90 | */ | 90 | */ |
91 | - public String manufacturerDescription(); | 91 | + String manufacturerDescription(); |
92 | 92 | ||
93 | /** | 93 | /** |
94 | * fetch the datapath description. | 94 | * fetch the datapath description. |
95 | * @return the description | 95 | * @return the description |
96 | */ | 96 | */ |
97 | - public String datapathDescription(); | 97 | + String datapathDescription(); |
98 | 98 | ||
99 | /** | 99 | /** |
100 | * fetch the hardware description. | 100 | * fetch the hardware description. |
101 | * @return the description | 101 | * @return the description |
102 | */ | 102 | */ |
103 | - public String hardwareDescription(); | 103 | + String hardwareDescription(); |
104 | 104 | ||
105 | /** | 105 | /** |
106 | * fetch the software description. | 106 | * fetch the software description. |
107 | * @return the description | 107 | * @return the description |
108 | */ | 108 | */ |
109 | - public String softwareDescription(); | 109 | + String softwareDescription(); |
110 | 110 | ||
111 | /** | 111 | /** |
112 | * fetch the serial number. | 112 | * fetch the serial number. |
113 | * @return the serial | 113 | * @return the serial |
114 | */ | 114 | */ |
115 | - public String serialNumber(); | 115 | + String serialNumber(); |
116 | 116 | ||
117 | /** | 117 | /** |
118 | * Checks if the switch is still connected. | 118 | * Checks if the switch is still connected. |
119 | * | 119 | * |
120 | * @return whether the switch is still connected | 120 | * @return whether the switch is still connected |
121 | */ | 121 | */ |
122 | - public boolean isConnected(); | 122 | + boolean isConnected(); |
123 | 123 | ||
124 | /** | 124 | /** |
125 | * Disconnects the switch by closing the TCP connection. Results in a call | 125 | * Disconnects the switch by closing the TCP connection. Results in a call |
126 | * to the channel handler's channelDisconnected method for cleanup | 126 | * to the channel handler's channelDisconnected method for cleanup |
127 | */ | 127 | */ |
128 | - public void disconnectSwitch(); | 128 | + void disconnectSwitch(); |
129 | 129 | ||
130 | /** | 130 | /** |
131 | * Notifies the controller that the device has responded to a set-role request. | 131 | * Notifies the controller that the device has responded to a set-role request. |
... | @@ -133,19 +133,19 @@ public interface OpenFlowSwitch { | ... | @@ -133,19 +133,19 @@ public interface OpenFlowSwitch { |
133 | * @param requested the role requested by the controller | 133 | * @param requested the role requested by the controller |
134 | * @param response the role set at the device | 134 | * @param response the role set at the device |
135 | */ | 135 | */ |
136 | - public void returnRoleReply(RoleState requested, RoleState response); | 136 | + void returnRoleReply(RoleState requested, RoleState response); |
137 | 137 | ||
138 | /** | 138 | /** |
139 | * Indicates if this switch is optical. | 139 | * Indicates if this switch is optical. |
140 | * | 140 | * |
141 | * @return true if optical | 141 | * @return true if optical |
142 | */ | 142 | */ |
143 | - public boolean isOptical(); | 143 | + boolean isOptical(); |
144 | 144 | ||
145 | /** | 145 | /** |
146 | * Identifies the channel used to communicate with the switch. | 146 | * Identifies the channel used to communicate with the switch. |
147 | * | 147 | * |
148 | * @return string representation of the connection to the device | 148 | * @return string representation of the connection to the device |
149 | */ | 149 | */ |
150 | - public String channelId(); | 150 | + String channelId(); |
151 | } | 151 | } | ... | ... |
... | @@ -26,26 +26,26 @@ public interface OpenFlowSwitchListener { | ... | @@ -26,26 +26,26 @@ public interface OpenFlowSwitchListener { |
26 | * Notify that the switch was added. | 26 | * Notify that the switch was added. |
27 | * @param dpid the switch where the event occurred | 27 | * @param dpid the switch where the event occurred |
28 | */ | 28 | */ |
29 | - public void switchAdded(Dpid dpid); | 29 | + void switchAdded(Dpid dpid); |
30 | 30 | ||
31 | /** | 31 | /** |
32 | * Notify that the switch was removed. | 32 | * Notify that the switch was removed. |
33 | * @param dpid the switch where the event occurred. | 33 | * @param dpid the switch where the event occurred. |
34 | */ | 34 | */ |
35 | - public void switchRemoved(Dpid dpid); | 35 | + void switchRemoved(Dpid dpid); |
36 | 36 | ||
37 | /** | 37 | /** |
38 | * Notify that the switch has changed in some way. | 38 | * Notify that the switch has changed in some way. |
39 | * @param dpid the switch that changed | 39 | * @param dpid the switch that changed |
40 | */ | 40 | */ |
41 | - public void switchChanged(Dpid dpid); | 41 | + void switchChanged(Dpid dpid); |
42 | 42 | ||
43 | /** | 43 | /** |
44 | * Notify that a port has changed. | 44 | * Notify that a port has changed. |
45 | * @param dpid the switch on which the change happened. | 45 | * @param dpid the switch on which the change happened. |
46 | * @param status the new state of the port. | 46 | * @param status the new state of the port. |
47 | */ | 47 | */ |
48 | - public void portChanged(Dpid dpid, OFPortStatus status); | 48 | + void portChanged(Dpid dpid, OFPortStatus status); |
49 | 49 | ||
50 | /** | 50 | /** |
51 | * Notify that a role imposed on a switch failed to take hold. | 51 | * Notify that a role imposed on a switch failed to take hold. |
... | @@ -54,5 +54,5 @@ public interface OpenFlowSwitchListener { | ... | @@ -54,5 +54,5 @@ public interface OpenFlowSwitchListener { |
54 | * @param requested the role controller requested | 54 | * @param requested the role controller requested |
55 | * @param response role reply from the switch | 55 | * @param response role reply from the switch |
56 | */ | 56 | */ |
57 | - public void receivedRoleReply(Dpid dpid, RoleState requested, RoleState response); | 57 | + void receivedRoleReply(Dpid dpid, RoleState requested, RoleState response); |
58 | } | 58 | } | ... | ... |
... | @@ -25,5 +25,5 @@ public interface PacketListener { | ... | @@ -25,5 +25,5 @@ public interface PacketListener { |
25 | * | 25 | * |
26 | * @param pktCtx the packet context | 26 | * @param pktCtx the packet context |
27 | */ | 27 | */ |
28 | - public void handlePacket(OpenFlowPacketContext pktCtx); | 28 | + void handlePacket(OpenFlowPacketContext pktCtx); |
29 | } | 29 | } | ... | ... |
-
Please register or login to post a comment