use encode/decode instead of serialize/deserialize
Change-Id: I273bb86d32cb763e1eb8bbbe4efa7a8dab541c51
Showing
6 changed files
with
15 additions
and
15 deletions
1 | package org.onlab.onos.store.cluster.messaging; | 1 | package org.onlab.onos.store.cluster.messaging; |
2 | 2 | ||
3 | /** | 3 | /** |
4 | - * Service for encoding & decoding intra-cluster messages. | 4 | + * Service for encoding & decoding intra-cluster message payload. |
5 | */ | 5 | */ |
6 | public interface SerializationService { | 6 | public interface SerializationService { |
7 | 7 | ||
... | @@ -11,7 +11,7 @@ public interface SerializationService { | ... | @@ -11,7 +11,7 @@ public interface SerializationService { |
11 | * @param buffer byte buffer with message(s) | 11 | * @param buffer byte buffer with message(s) |
12 | * @return parsed message | 12 | * @return parsed message |
13 | */ | 13 | */ |
14 | - Object decode(byte[] data); | 14 | + <T> T decode(byte[] data); |
15 | 15 | ||
16 | /** | 16 | /** |
17 | * Encodes the specified message into the given byte buffer. | 17 | * Encodes the specified message into the given byte buffer. | ... | ... |
... | @@ -52,7 +52,7 @@ public class MessageSerializer implements SerializationService { | ... | @@ -52,7 +52,7 @@ public class MessageSerializer implements SerializationService { |
52 | 52 | ||
53 | 53 | ||
54 | @Override | 54 | @Override |
55 | - public Object decode(byte[] data) { | 55 | + public <T> T decode(byte[] data) { |
56 | return serializerPool.deserialize(data); | 56 | return serializerPool.deserialize(data); |
57 | } | 57 | } |
58 | 58 | ... | ... |
... | @@ -50,7 +50,7 @@ public abstract class AbstractHazelcastStore<E extends Event, D extends StoreDel | ... | @@ -50,7 +50,7 @@ public abstract class AbstractHazelcastStore<E extends Event, D extends StoreDel |
50 | * @return serialized object | 50 | * @return serialized object |
51 | */ | 51 | */ |
52 | protected byte[] serialize(Object obj) { | 52 | protected byte[] serialize(Object obj) { |
53 | - return kryoSerializationService.serialize(obj); | 53 | + return kryoSerializationService.encode(obj); |
54 | } | 54 | } |
55 | 55 | ||
56 | /** | 56 | /** |
... | @@ -61,7 +61,7 @@ public abstract class AbstractHazelcastStore<E extends Event, D extends StoreDel | ... | @@ -61,7 +61,7 @@ public abstract class AbstractHazelcastStore<E extends Event, D extends StoreDel |
61 | * @return deserialized object | 61 | * @return deserialized object |
62 | */ | 62 | */ |
63 | protected <T> T deserialize(byte[] bytes) { | 63 | protected <T> T deserialize(byte[] bytes) { |
64 | - return kryoSerializationService.deserialize(bytes); | 64 | + return kryoSerializationService.decode(bytes); |
65 | } | 65 | } |
66 | 66 | ||
67 | 67 | ... | ... |
... | @@ -34,12 +34,12 @@ public final class OptionalCacheLoader<K, V> extends | ... | @@ -34,12 +34,12 @@ public final class OptionalCacheLoader<K, V> extends |
34 | 34 | ||
35 | @Override | 35 | @Override |
36 | public Optional<V> load(K key) throws Exception { | 36 | public Optional<V> load(K key) throws Exception { |
37 | - byte[] keyBytes = kryoSerializationService.serialize(key); | 37 | + byte[] keyBytes = kryoSerializationService.encode(key); |
38 | byte[] valBytes = rawMap.get(keyBytes); | 38 | byte[] valBytes = rawMap.get(keyBytes); |
39 | if (valBytes == null) { | 39 | if (valBytes == null) { |
40 | return Optional.absent(); | 40 | return Optional.absent(); |
41 | } | 41 | } |
42 | - V dev = kryoSerializationService.deserialize(valBytes); | 42 | + V dev = kryoSerializationService.decode(valBytes); |
43 | return Optional.of(dev); | 43 | return Optional.of(dev); |
44 | } | 44 | } |
45 | } | 45 | } | ... | ... |
... | @@ -43,12 +43,12 @@ public class KryoSerializationManager implements KryoSerializationService { | ... | @@ -43,12 +43,12 @@ public class KryoSerializationManager implements KryoSerializationService { |
43 | } | 43 | } |
44 | 44 | ||
45 | @Override | 45 | @Override |
46 | - public byte[] serialize(final Object obj) { | 46 | + public byte[] encode(final Object obj) { |
47 | return serializerPool.serialize(obj); | 47 | return serializerPool.serialize(obj); |
48 | } | 48 | } |
49 | 49 | ||
50 | @Override | 50 | @Override |
51 | - public <T> T deserialize(final byte[] bytes) { | 51 | + public <T> T decode(final byte[] bytes) { |
52 | if (bytes == null) { | 52 | if (bytes == null) { |
53 | return null; | 53 | return null; |
54 | } | 54 | } |
... | @@ -56,12 +56,12 @@ public class KryoSerializationManager implements KryoSerializationService { | ... | @@ -56,12 +56,12 @@ public class KryoSerializationManager implements KryoSerializationService { |
56 | } | 56 | } |
57 | 57 | ||
58 | @Override | 58 | @Override |
59 | - public void serialize(Object obj, ByteBuffer buffer) { | 59 | + public void encode(Object obj, ByteBuffer buffer) { |
60 | serializerPool.serialize(obj, buffer); | 60 | serializerPool.serialize(obj, buffer); |
61 | } | 61 | } |
62 | 62 | ||
63 | @Override | 63 | @Override |
64 | - public <T> T deserialize(ByteBuffer buffer) { | 64 | + public <T> T decode(ByteBuffer buffer) { |
65 | return serializerPool.deserialize(buffer); | 65 | return serializerPool.deserialize(buffer); |
66 | } | 66 | } |
67 | 67 | ... | ... |
... | @@ -15,7 +15,7 @@ public interface KryoSerializationService { | ... | @@ -15,7 +15,7 @@ public interface KryoSerializationService { |
15 | * @param obj object to be serialized | 15 | * @param obj object to be serialized |
16 | * @return serialized bytes | 16 | * @return serialized bytes |
17 | */ | 17 | */ |
18 | - public byte[] serialize(final Object obj); | 18 | + public byte[] encode(final Object obj); |
19 | 19 | ||
20 | /** | 20 | /** |
21 | * Serializes the specified object into bytes using one of the | 21 | * Serializes the specified object into bytes using one of the |
... | @@ -24,7 +24,7 @@ public interface KryoSerializationService { | ... | @@ -24,7 +24,7 @@ public interface KryoSerializationService { |
24 | * @param obj object to be serialized | 24 | * @param obj object to be serialized |
25 | * @param buffer to write serialized bytes | 25 | * @param buffer to write serialized bytes |
26 | */ | 26 | */ |
27 | - public void serialize(final Object obj, ByteBuffer buffer); | 27 | + public void encode(final Object obj, ByteBuffer buffer); |
28 | 28 | ||
29 | /** | 29 | /** |
30 | * Deserializes the specified bytes into an object using one of the | 30 | * Deserializes the specified bytes into an object using one of the |
... | @@ -33,7 +33,7 @@ public interface KryoSerializationService { | ... | @@ -33,7 +33,7 @@ public interface KryoSerializationService { |
33 | * @param bytes bytes to be deserialized | 33 | * @param bytes bytes to be deserialized |
34 | * @return deserialized object | 34 | * @return deserialized object |
35 | */ | 35 | */ |
36 | - public <T> T deserialize(final byte[] bytes); | 36 | + public <T> T decode(final byte[] bytes); |
37 | 37 | ||
38 | /** | 38 | /** |
39 | * Deserializes the specified bytes into an object using one of the | 39 | * Deserializes the specified bytes into an object using one of the |
... | @@ -42,5 +42,5 @@ public interface KryoSerializationService { | ... | @@ -42,5 +42,5 @@ public interface KryoSerializationService { |
42 | * @param buffer bytes to be deserialized | 42 | * @param buffer bytes to be deserialized |
43 | * @return deserialized object | 43 | * @return deserialized object |
44 | */ | 44 | */ |
45 | - public <T> T deserialize(final ByteBuffer buffer); | 45 | + public <T> T decode(final ByteBuffer buffer); |
46 | } | 46 | } | ... | ... |
-
Please register or login to post a comment