Committed by
Gerrit Code Review
Change the second type parameter of BatchOperationEntry
- Remove the bounded type parameter for BatchOperationTarget - FlowRule and Intent don't inherit from BatchOperationTarget - Remove BatchOperationTarget because nothing depends on it Change-Id: I3b414d25409e9bbe5de37ffef10b08bc1799be74
Showing
5 changed files
with
4 additions
and
28 deletions
... | @@ -27,7 +27,7 @@ import static com.google.common.base.Preconditions.checkNotNull; | ... | @@ -27,7 +27,7 @@ import static com.google.common.base.Preconditions.checkNotNull; |
27 | * This is the interface to classes which are maintained by BatchOperation as | 27 | * This is the interface to classes which are maintained by BatchOperation as |
28 | * its entries. | 28 | * its entries. |
29 | */ | 29 | */ |
30 | -public class BatchOperationEntry<T extends Enum<?>, U extends BatchOperationTarget> { | 30 | +public class BatchOperationEntry<T extends Enum<?>, U> { |
31 | 31 | ||
32 | private final T operator; | 32 | private final T operator; |
33 | private final U target; | 33 | private final U target; | ... | ... |
1 | -/* | ||
2 | - * Copyright 2014 Open Networking Laboratory | ||
3 | - * | ||
4 | - * Licensed under the Apache License, Version 2.0 (the "License"); | ||
5 | - * you may not use this file except in compliance with the License. | ||
6 | - * You may obtain a copy of the License at | ||
7 | - * | ||
8 | - * http://www.apache.org/licenses/LICENSE-2.0 | ||
9 | - * | ||
10 | - * Unless required by applicable law or agreed to in writing, software | ||
11 | - * distributed under the License is distributed on an "AS IS" BASIS, | ||
12 | - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
13 | - * See the License for the specific language governing permissions and | ||
14 | - * limitations under the License. | ||
15 | - */ | ||
16 | -package org.onosproject.net.flow; | ||
17 | - | ||
18 | -/** | ||
19 | - * An interface of the class which is assigned to BatchOperation. | ||
20 | - */ | ||
21 | -public interface BatchOperationTarget { | ||
22 | - | ||
23 | -} |
... | @@ -22,7 +22,7 @@ import org.onosproject.net.DeviceId; | ... | @@ -22,7 +22,7 @@ import org.onosproject.net.DeviceId; |
22 | * Represents a generalized match & action pair to be applied to | 22 | * Represents a generalized match & action pair to be applied to |
23 | * an infrastructure device. | 23 | * an infrastructure device. |
24 | */ | 24 | */ |
25 | -public interface FlowRule extends BatchOperationTarget { | 25 | +public interface FlowRule { |
26 | 26 | ||
27 | static final int MAX_TIMEOUT = 60; | 27 | static final int MAX_TIMEOUT = 60; |
28 | static final int MIN_PRIORITY = 0; | 28 | static final int MIN_PRIORITY = 0; | ... | ... |
... | @@ -18,7 +18,6 @@ package org.onosproject.net.intent; | ... | @@ -18,7 +18,6 @@ package org.onosproject.net.intent; |
18 | import org.onosproject.core.ApplicationId; | 18 | import org.onosproject.core.ApplicationId; |
19 | import org.onosproject.core.IdGenerator; | 19 | import org.onosproject.core.IdGenerator; |
20 | import org.onosproject.net.NetworkResource; | 20 | import org.onosproject.net.NetworkResource; |
21 | -import org.onosproject.net.flow.BatchOperationTarget; | ||
22 | 21 | ||
23 | import java.util.Collection; | 22 | import java.util.Collection; |
24 | import java.util.Objects; | 23 | import java.util.Objects; |
... | @@ -32,7 +31,7 @@ import static com.google.common.base.Preconditions.checkState; | ... | @@ -32,7 +31,7 @@ import static com.google.common.base.Preconditions.checkState; |
32 | * Make sure that an Intent should be immutable when a new type is defined. | 31 | * Make sure that an Intent should be immutable when a new type is defined. |
33 | * </p> | 32 | * </p> |
34 | */ | 33 | */ |
35 | -public abstract class Intent implements BatchOperationTarget { | 34 | +public abstract class Intent { |
36 | 35 | ||
37 | private final IntentId id; | 36 | private final IntentId id; |
38 | private final ApplicationId appId; | 37 | private final ApplicationId appId; | ... | ... |
... | @@ -43,7 +43,7 @@ public class BatchOperationTest { | ... | @@ -43,7 +43,7 @@ public class BatchOperationTest { |
43 | final TestEntry entry2 = new TestEntry(TestType.OP2, new TestTarget(2)); | 43 | final TestEntry entry2 = new TestEntry(TestType.OP2, new TestTarget(2)); |
44 | 44 | ||
45 | 45 | ||
46 | - private static final class TestTarget implements BatchOperationTarget { | 46 | + private static final class TestTarget { |
47 | private int id; | 47 | private int id; |
48 | 48 | ||
49 | private TestTarget(int id) { | 49 | private TestTarget(int id) { | ... | ... |
-
Please register or login to post a comment