Committed by
Gerrit Code Review
Remove "public" to follow our convention
Change-Id: Iff2ebf90d8791bfcdb724d67b2bd0da2756cf5ce
Showing
6 changed files
with
29 additions
and
29 deletions
| ... | @@ -30,81 +30,81 @@ public interface PcepClient { | ... | @@ -30,81 +30,81 @@ public interface PcepClient { |
| 30 | * | 30 | * |
| 31 | * @param msg the message to write | 31 | * @param msg the message to write |
| 32 | */ | 32 | */ |
| 33 | - public void sendMessage(PcepMessage msg); | 33 | + void sendMessage(PcepMessage msg); |
| 34 | 34 | ||
| 35 | /** | 35 | /** |
| 36 | * Writes the PcepMessage list to the driver. | 36 | * Writes the PcepMessage list to the driver. |
| 37 | * | 37 | * |
| 38 | * @param msgs the messages to be written | 38 | * @param msgs the messages to be written |
| 39 | */ | 39 | */ |
| 40 | - public void sendMessage(List<PcepMessage> msgs); | 40 | + void sendMessage(List<PcepMessage> msgs); |
| 41 | 41 | ||
| 42 | /** | 42 | /** |
| 43 | * Handle a message from the pcc. | 43 | * Handle a message from the pcc. |
| 44 | * | 44 | * |
| 45 | * @param fromClient the message to handle | 45 | * @param fromClient the message to handle |
| 46 | */ | 46 | */ |
| 47 | - public void handleMessage(PcepMessage fromClient); | 47 | + void handleMessage(PcepMessage fromClient); |
| 48 | 48 | ||
| 49 | /** | 49 | /** |
| 50 | * Provides the factory for this PCEP version. | 50 | * Provides the factory for this PCEP version. |
| 51 | * | 51 | * |
| 52 | * @return PCEP version specific factory. | 52 | * @return PCEP version specific factory. |
| 53 | */ | 53 | */ |
| 54 | - public PcepFactory factory(); | 54 | + PcepFactory factory(); |
| 55 | 55 | ||
| 56 | /** | 56 | /** |
| 57 | * Gets a string version of the ID for this pcc. | 57 | * Gets a string version of the ID for this pcc. |
| 58 | * | 58 | * |
| 59 | * @return string version of the ID | 59 | * @return string version of the ID |
| 60 | */ | 60 | */ |
| 61 | - public String getStringId(); | 61 | + String getStringId(); |
| 62 | 62 | ||
| 63 | /** | 63 | /** |
| 64 | * Gets the ipAddress of the client. | 64 | * Gets the ipAddress of the client. |
| 65 | * | 65 | * |
| 66 | * @return the client pccId in IPAddress format | 66 | * @return the client pccId in IPAddress format |
| 67 | */ | 67 | */ |
| 68 | - public PccId getPccId(); | 68 | + PccId getPccId(); |
| 69 | 69 | ||
| 70 | /** | 70 | /** |
| 71 | * Checks if the pcc is still connected. | 71 | * Checks if the pcc is still connected. |
| 72 | * | 72 | * |
| 73 | * @return true if client is connected, false otherwise | 73 | * @return true if client is connected, false otherwise |
| 74 | */ | 74 | */ |
| 75 | - public boolean isConnected(); | 75 | + boolean isConnected(); |
| 76 | 76 | ||
| 77 | /** | 77 | /** |
| 78 | * Disconnects the pcc by closing the TCP connection. Results in a call | 78 | * Disconnects the pcc by closing the TCP connection. Results in a call |
| 79 | * to the channel handler's channelDisconnected method for cleanup. | 79 | * to the channel handler's channelDisconnected method for cleanup. |
| 80 | */ | 80 | */ |
| 81 | - public void disconnectClient(); | 81 | + void disconnectClient(); |
| 82 | 82 | ||
| 83 | /** | 83 | /** |
| 84 | * Indicates if this pcc is optical. | 84 | * Indicates if this pcc is optical. |
| 85 | * | 85 | * |
| 86 | * @return true if optical | 86 | * @return true if optical |
| 87 | */ | 87 | */ |
| 88 | - public boolean isOptical(); | 88 | + boolean isOptical(); |
| 89 | 89 | ||
| 90 | /** | 90 | /** |
| 91 | * Identifies the channel used to communicate with the pcc. | 91 | * Identifies the channel used to communicate with the pcc. |
| 92 | * | 92 | * |
| 93 | * @return string representation of the connection to the client | 93 | * @return string representation of the connection to the client |
| 94 | */ | 94 | */ |
| 95 | - public String channelId(); | 95 | + String channelId(); |
| 96 | 96 | ||
| 97 | /** | 97 | /** |
| 98 | * To set the status of state synchronization. | 98 | * To set the status of state synchronization. |
| 99 | * | 99 | * |
| 100 | * @param value to set the synchronization status | 100 | * @param value to set the synchronization status |
| 101 | */ | 101 | */ |
| 102 | - public void setIsSyncComplete(boolean value); | 102 | + void setIsSyncComplete(boolean value); |
| 103 | 103 | ||
| 104 | /** | 104 | /** |
| 105 | * Indicates the state synchronization status of this pcc. | 105 | * Indicates the state synchronization status of this pcc. |
| 106 | * | 106 | * |
| 107 | * @return true/false if the synchronization is completed/not completed | 107 | * @return true/false if the synchronization is completed/not completed |
| 108 | */ | 108 | */ |
| 109 | - public boolean isSyncComplete(); | 109 | + boolean isSyncComplete(); |
| 110 | } | 110 | } | ... | ... |
| ... | @@ -25,12 +25,12 @@ public interface PcepClientListener { | ... | @@ -25,12 +25,12 @@ public interface PcepClientListener { |
| 25 | * | 25 | * |
| 26 | * @param pccId the id of the client that connected | 26 | * @param pccId the id of the client that connected |
| 27 | */ | 27 | */ |
| 28 | - public void clientConnected(PccId pccId); | 28 | + void clientConnected(PccId pccId); |
| 29 | 29 | ||
| 30 | /** | 30 | /** |
| 31 | * Notify that the PCC was disconnected. | 31 | * Notify that the PCC was disconnected. |
| 32 | * | 32 | * |
| 33 | * @param pccId the id of the client that disconnected. | 33 | * @param pccId the id of the client that disconnected. |
| 34 | */ | 34 | */ |
| 35 | - public void clientDisconnected(PccId pccId); | 35 | + void clientDisconnected(PccId pccId); |
| 36 | } | 36 | } | ... | ... |
| ... | @@ -27,5 +27,5 @@ public interface PcepEventListener { | ... | @@ -27,5 +27,5 @@ public interface PcepEventListener { |
| 27 | * @param pccId id of the pcc | 27 | * @param pccId id of the pcc |
| 28 | * @param msg the message | 28 | * @param msg the message |
| 29 | */ | 29 | */ |
| 30 | - public void handleMessage(PccId pccId, PcepMessage msg); | 30 | + void handleMessage(PccId pccId, PcepMessage msg); |
| 31 | } | 31 | } | ... | ... |
| ... | @@ -33,7 +33,7 @@ public interface PcepAgent { | ... | @@ -33,7 +33,7 @@ public interface PcepAgent { |
| 33 | * @param pc the actual pce client object. | 33 | * @param pc the actual pce client object. |
| 34 | * @return true if added, false otherwise. | 34 | * @return true if added, false otherwise. |
| 35 | */ | 35 | */ |
| 36 | - public boolean addConnectedClient(PccId pccId, PcepClient pc); | 36 | + boolean addConnectedClient(PccId pccId, PcepClient pc); |
| 37 | 37 | ||
| 38 | /** | 38 | /** |
| 39 | * Checks if the activation for this pcc client is valid. | 39 | * Checks if the activation for this pcc client is valid. |
| ... | @@ -41,7 +41,7 @@ public interface PcepAgent { | ... | @@ -41,7 +41,7 @@ public interface PcepAgent { |
| 41 | * @param pccId the id of pcc client to check | 41 | * @param pccId the id of pcc client to check |
| 42 | * @return true if valid, false otherwise | 42 | * @return true if valid, false otherwise |
| 43 | */ | 43 | */ |
| 44 | - public boolean validActivation(PccId pccId); | 44 | + boolean validActivation(PccId pccId); |
| 45 | 45 | ||
| 46 | /** | 46 | /** |
| 47 | * Clear all state in controller client maps for a pcc client that has | 47 | * Clear all state in controller client maps for a pcc client that has |
| ... | @@ -50,7 +50,7 @@ public interface PcepAgent { | ... | @@ -50,7 +50,7 @@ public interface PcepAgent { |
| 50 | * | 50 | * |
| 51 | * @param pccIds the id of pcc client to remove. | 51 | * @param pccIds the id of pcc client to remove. |
| 52 | */ | 52 | */ |
| 53 | - public void removeConnectedClient(PccId pccIds); | 53 | + void removeConnectedClient(PccId pccIds); |
| 54 | 54 | ||
| 55 | /** | 55 | /** |
| 56 | * Process a message coming from a pcc client. | 56 | * Process a message coming from a pcc client. |
| ... | @@ -58,6 +58,6 @@ public interface PcepAgent { | ... | @@ -58,6 +58,6 @@ public interface PcepAgent { |
| 58 | * @param pccId the id of pcc client the message was received. | 58 | * @param pccId the id of pcc client the message was received. |
| 59 | * @param m the message to process | 59 | * @param m the message to process |
| 60 | */ | 60 | */ |
| 61 | - public void processPcepMessage(PccId pccId, PcepMessage m); | 61 | + void processPcepMessage(PccId pccId, PcepMessage m); |
| 62 | 62 | ||
| 63 | } | 63 | } | ... | ... |
| ... | @@ -34,33 +34,33 @@ public interface PcepClientDriver extends PcepClient { | ... | @@ -34,33 +34,33 @@ public interface PcepClientDriver extends PcepClient { |
| 34 | * | 34 | * |
| 35 | * @param agent the agent to set. | 35 | * @param agent the agent to set. |
| 36 | */ | 36 | */ |
| 37 | - public void setAgent(PcepAgent agent); | 37 | + void setAgent(PcepAgent agent); |
| 38 | 38 | ||
| 39 | /** | 39 | /** |
| 40 | * Announce to the Pcep agent that this pcc client has connected. | 40 | * Announce to the Pcep agent that this pcc client has connected. |
| 41 | * | 41 | * |
| 42 | * @return true if successful, false if duplicate switch. | 42 | * @return true if successful, false if duplicate switch. |
| 43 | */ | 43 | */ |
| 44 | - public boolean connectClient(); | 44 | + boolean connectClient(); |
| 45 | 45 | ||
| 46 | /** | 46 | /** |
| 47 | * Remove this pcc client from the Pcep agent. | 47 | * Remove this pcc client from the Pcep agent. |
| 48 | */ | 48 | */ |
| 49 | - public void removeConnectedClient(); | 49 | + void removeConnectedClient(); |
| 50 | 50 | ||
| 51 | /** | 51 | /** |
| 52 | * Sets the PCEP version for this pcc. | 52 | * Sets the PCEP version for this pcc. |
| 53 | * | 53 | * |
| 54 | * @param pcepVersion the version to set. | 54 | * @param pcepVersion the version to set. |
| 55 | */ | 55 | */ |
| 56 | - public void setPcVersion(PcepVersion pcepVersion); | 56 | + void setPcVersion(PcepVersion pcepVersion); |
| 57 | 57 | ||
| 58 | /** | 58 | /** |
| 59 | * Sets the associated Netty channel for this pcc. | 59 | * Sets the associated Netty channel for this pcc. |
| 60 | * | 60 | * |
| 61 | * @param channel the Netty channel | 61 | * @param channel the Netty channel |
| 62 | */ | 62 | */ |
| 63 | - public void setChannel(Channel channel); | 63 | + void setChannel(Channel channel); |
| 64 | 64 | ||
| 65 | 65 | ||
| 66 | /** | 66 | /** |
| ... | @@ -68,28 +68,28 @@ public interface PcepClientDriver extends PcepClient { | ... | @@ -68,28 +68,28 @@ public interface PcepClientDriver extends PcepClient { |
| 68 | * | 68 | * |
| 69 | * @param keepAliveTime the keep alive time to set. | 69 | * @param keepAliveTime the keep alive time to set. |
| 70 | */ | 70 | */ |
| 71 | - public void setPcKeepAliveTime(byte keepAliveTime); | 71 | + void setPcKeepAliveTime(byte keepAliveTime); |
| 72 | 72 | ||
| 73 | /** | 73 | /** |
| 74 | * Sets the dead time for this pcc. | 74 | * Sets the dead time for this pcc. |
| 75 | * | 75 | * |
| 76 | * @param deadTime the dead timer value to set. | 76 | * @param deadTime the dead timer value to set. |
| 77 | */ | 77 | */ |
| 78 | - public void setPcDeadTime(byte deadTime); | 78 | + void setPcDeadTime(byte deadTime); |
| 79 | 79 | ||
| 80 | /** | 80 | /** |
| 81 | * Sets the session id for this pcc. | 81 | * Sets the session id for this pcc. |
| 82 | * | 82 | * |
| 83 | * @param sessionId the session id value to set. | 83 | * @param sessionId the session id value to set. |
| 84 | */ | 84 | */ |
| 85 | - public void setPcSessionId(byte sessionId); | 85 | + void setPcSessionId(byte sessionId); |
| 86 | 86 | ||
| 87 | /** | 87 | /** |
| 88 | * Sets whether the pcc is connected. | 88 | * Sets whether the pcc is connected. |
| 89 | * | 89 | * |
| 90 | * @param connected whether the pcc is connected | 90 | * @param connected whether the pcc is connected |
| 91 | */ | 91 | */ |
| 92 | - public void setConnected(boolean connected); | 92 | + void setConnected(boolean connected); |
| 93 | 93 | ||
| 94 | /** | 94 | /** |
| 95 | * Initializes the behavior. | 95 | * Initializes the behavior. | ... | ... |
| ... | @@ -33,6 +33,6 @@ public interface PcepClientDriverFactory { | ... | @@ -33,6 +33,6 @@ public interface PcepClientDriverFactory { |
| 33 | * @param pcepVersion the Pcep version in use | 33 | * @param pcepVersion the Pcep version in use |
| 34 | * @return the Pcep client representation. | 34 | * @return the Pcep client representation. |
| 35 | */ | 35 | */ |
| 36 | - public PcepClientDriver getPcepClientImpl(IpAddress pccIpAddress, | 36 | + PcepClientDriver getPcepClientImpl(IpAddress pccIpAddress, |
| 37 | PcepVersion pcepVersion); | 37 | PcepVersion pcepVersion); |
| 38 | } | 38 | } | ... | ... |
-
Please register or login to post a comment