Remove redundant Object[] declarations in variable argument lists
Change-Id: I34b8e183c3f57a04a84b2cbc061e7071ec466887
Showing
3 changed files
with
11 additions
and
11 deletions
... | @@ -445,7 +445,7 @@ class OFChannelHandler extends IdleStateAwareChannelHandler { | ... | @@ -445,7 +445,7 @@ class OFChannelHandler extends IdleStateAwareChannelHandler { |
445 | 445 | ||
446 | 446 | ||
447 | log.debug("Switch {} bound to class {}, description {}", | 447 | log.debug("Switch {} bound to class {}, description {}", |
448 | - new Object[] {h.sw, h.sw.getClass(), drep }); | 448 | + h.sw, h.sw.getClass(), drep); |
449 | //Put switch in EQUAL mode until we hear back from the global registry | 449 | //Put switch in EQUAL mode until we hear back from the global registry |
450 | //log.debug("Setting new switch {} to EQUAL and sending Role request", | 450 | //log.debug("Setting new switch {} to EQUAL and sending Role request", |
451 | // h.sw.getStringId()); | 451 | // h.sw.getStringId()); |
... | @@ -730,10 +730,9 @@ class OFChannelHandler extends IdleStateAwareChannelHandler { | ... | @@ -730,10 +730,9 @@ class OFChannelHandler extends IdleStateAwareChannelHandler { |
730 | */ | 730 | */ |
731 | protected void logError(OFChannelHandler h, OFErrorMsg error) { | 731 | protected void logError(OFChannelHandler h, OFErrorMsg error) { |
732 | log.error("{} from switch {} in state {}", | 732 | log.error("{} from switch {} in state {}", |
733 | - new Object[] { | ||
734 | error, | 733 | error, |
735 | h.getSwitchInfoString(), | 734 | h.getSwitchInfoString(), |
736 | - this.toString()}); | 735 | + this.toString()); |
737 | } | 736 | } |
738 | 737 | ||
739 | /** | 738 | /** | ... | ... |
... | @@ -498,10 +498,10 @@ public class OpenFlowControllerImpl implements OpenFlowController { | ... | @@ -498,10 +498,10 @@ public class OpenFlowControllerImpl implements OpenFlowController { |
498 | activeEqualSwitches.get(dpid) != null) { | 498 | activeEqualSwitches.get(dpid) != null) { |
499 | log.error("Trying to activate switch but it is already " | 499 | log.error("Trying to activate switch but it is already " |
500 | + "activated: dpid {}. Found in activeMaster: {} " | 500 | + "activated: dpid {}. Found in activeMaster: {} " |
501 | - + "Found in activeEqual: {}. Aborting ..", new Object[]{ | 501 | + + "Found in activeEqual: {}. Aborting ..", |
502 | dpid, | 502 | dpid, |
503 | (activeMasterSwitches.get(dpid) == null) ? 'N' : 'Y', | 503 | (activeMasterSwitches.get(dpid) == null) ? 'N' : 'Y', |
504 | - (activeEqualSwitches.get(dpid) == null) ? 'N' : 'Y'}); | 504 | + (activeEqualSwitches.get(dpid) == null) ? 'N' : 'Y'); |
505 | return false; | 505 | return false; |
506 | } | 506 | } |
507 | return true; | 507 | return true; | ... | ... |
... | @@ -213,8 +213,9 @@ class RoleManager implements RoleHandler { | ... | @@ -213,8 +213,9 @@ class RoleManager implements RoleHandler { |
213 | log.debug("Received unexpected RoleReply {} from " | 213 | log.debug("Received unexpected RoleReply {} from " |
214 | + "Switch: {}. " | 214 | + "Switch: {}. " |
215 | + "This controller has no current role for this sw. " | 215 | + "This controller has no current role for this sw. " |
216 | - + "Ignoring ...", new Object[] {rri, | 216 | + + "Ignoring ...", |
217 | - sw == null ? "(null)" : sw.getStringId(), }); | 217 | + rri, |
218 | + sw == null ? "(null)" : sw.getStringId()); | ||
218 | return RoleRecvStatus.OTHER_EXPECTATION; | 219 | return RoleRecvStatus.OTHER_EXPECTATION; |
219 | } | 220 | } |
220 | 221 | ||
... | @@ -232,7 +233,7 @@ class RoleManager implements RoleHandler { | ... | @@ -232,7 +233,7 @@ class RoleManager implements RoleHandler { |
232 | if (expectedRole == receivedRole) { | 233 | if (expectedRole == receivedRole) { |
233 | log.debug("Received role reply message from {} that matched " | 234 | log.debug("Received role reply message from {} that matched " |
234 | + "expected role-reply {} with expectations {}", | 235 | + "expected role-reply {} with expectations {}", |
235 | - new Object[] {sw.getStringId(), receivedRole, expectation}); | 236 | + sw.getStringId(), receivedRole, expectation); |
236 | 237 | ||
237 | // Done with this RoleReply; Invalidate | 238 | // Done with this RoleReply; Invalidate |
238 | pendingReplies.invalidate(xid); | 239 | pendingReplies.invalidate(xid); |
... | @@ -283,10 +284,10 @@ class RoleManager implements RoleHandler { | ... | @@ -283,10 +284,10 @@ class RoleManager implements RoleHandler { |
283 | log.error("Received a error msg {} from sw {} for " | 284 | log.error("Received a error msg {} from sw {} for " |
284 | + "pending role request {}. Switch driver indicates " | 285 | + "pending role request {}. Switch driver indicates " |
285 | + "role-messaging is supported. Possible issues in " | 286 | + "role-messaging is supported. Possible issues in " |
286 | - + "switch driver configuration?", new Object[] { | 287 | + + "switch driver configuration?", |
287 | ((OFBadRequestErrorMsg) error).toString(), | 288 | ((OFBadRequestErrorMsg) error).toString(), |
288 | - sw.getStringId(), errorRole | 289 | + sw.getStringId(), |
289 | - }); | 290 | + errorRole); |
290 | return RoleRecvStatus.UNSUPPORTED; | 291 | return RoleRecvStatus.UNSUPPORTED; |
291 | } | 292 | } |
292 | 293 | ... | ... |
-
Please register or login to post a comment