Use ConcurrentHashMap instead of FastHashMap

Apache Commons Collections doesn't support Generics

Change-Id: I8125b5e1aca9054ae399f9cabe8f76970294f848

@@ -3,7 +3,6 @@ package org.onosproject.security.impl;
 
 
 import com.google.common.collect.ImmutableSet;
 import com.google.common.collect.ImmutableSet;
 import com.google.common.collect.Sets;
 import com.google.common.collect.Sets;
-import org.apache.commons.collections.FastHashMap;
 import org.onosproject.core.Permission;
 import org.onosproject.core.Permission;
 import org.onosproject.security.AppPermission;
 import org.onosproject.security.AppPermission;
 import org.osgi.service.permissionadmin.PermissionInfo;
 import org.osgi.service.permissionadmin.PermissionInfo;
@@ -47,8 +46,9 @@ import org.osgi.framework.AdaptPermission;
 
 
 
 
 import java.util.Collections;
 import java.util.Collections;
-import java.util.HashMap;
+import java.util.Map;
 import java.util.Set;
 import java.util.Set;
+import java.util.concurrent.ConcurrentHashMap;
 import java.util.stream.Collectors;
 import java.util.stream.Collectors;
 
 
 public final class PolicyBuilder {
 public final class PolicyBuilder {
@@ -56,7 +56,7 @@ public final class PolicyBuilder {
     private PolicyBuilder(){
     private PolicyBuilder(){
     }
     }
 
 
-    public static PermissionInfo[] getApplicationPermissions(HashMap<Permission, Set<String>> serviceDirectory,
+    public static PermissionInfo[] getApplicationPermissions(Map<Permission, Set<String>> serviceDirectory,
                                                              Set<Permission> permissions) {
                                                              Set<Permission> permissions) {
         Set<PermissionInfo> permSet = Sets.newHashSet();
         Set<PermissionInfo> permSet = Sets.newHashSet();
         Collections.addAll(permSet, getDefaultPerms());
         Collections.addAll(permSet, getDefaultPerms());
@@ -69,7 +69,7 @@ public final class PolicyBuilder {
         return permSet.toArray(permissionInfos);
         return permSet.toArray(permissionInfos);
     }
     }
 
 
-    public static PermissionInfo[] getAdminApplicationPermissions(HashMap<Permission, Set<String>> serviceDirectory) {
+    public static PermissionInfo[] getAdminApplicationPermissions(Map<Permission, Set<String>> serviceDirectory) {
         Set<PermissionInfo> permSet = Sets.newHashSet();
         Set<PermissionInfo> permSet = Sets.newHashSet();
         Collections.addAll(permSet, getDefaultPerms());
         Collections.addAll(permSet, getDefaultPerms());
         Collections.addAll(permSet, getAdminDefaultPerms());
         Collections.addAll(permSet, getAdminDefaultPerms());
@@ -166,9 +166,9 @@ public final class PolicyBuilder {
     }
     }
 
 
 
 
-    public static HashMap<Permission, Set<String>> getServiceDirectory() {
+    public static Map<Permission, Set<String>> getServiceDirectory() {
 
 
-        HashMap<Permission, Set<String>> serviceDirectory = new FastHashMap();
+        Map<Permission, Set<String>> serviceDirectory = new ConcurrentHashMap<>();
 
 
         serviceDirectory.put(Permission.APP_READ, ImmutableSet.of(
         serviceDirectory.put(Permission.APP_READ, ImmutableSet.of(
                 ApplicationService.class.getName(), CoreService.class.getName()));
                 ApplicationService.class.getName(), CoreService.class.getName()));

 package org.onosproject.security.impl;
 package org.onosproject.security.impl;
 
 
-import org.apache.commons.collections.FastHashMap;
 import org.apache.felix.scr.annotations.Component;
 import org.apache.felix.scr.annotations.Component;
 import org.apache.felix.scr.annotations.Reference;
 import org.apache.felix.scr.annotations.Reference;
 import org.apache.felix.scr.annotations.ReferenceCardinality;
 import org.apache.felix.scr.annotations.ReferenceCardinality;
@@ -33,9 +32,10 @@ import org.osgi.service.permissionadmin.PermissionInfo;
 import java.security.AccessControlException;
 import java.security.AccessControlException;
 import java.security.AllPermission;
 import java.security.AllPermission;
 import java.util.ArrayList;
 import java.util.ArrayList;
-import java.util.HashMap;
 import java.util.List;
 import java.util.List;
+import java.util.Map;
 import java.util.Set;
 import java.util.Set;
+import java.util.concurrent.ConcurrentHashMap;
 import java.util.stream.Collectors;
 import java.util.stream.Collectors;
 
 
 import org.osgi.service.permissionadmin.PermissionAdmin;
 import org.osgi.service.permissionadmin.PermissionAdmin;
@@ -75,9 +75,9 @@ public class SecurityModeManager {
 
 
     private PermissionAdmin permissionAdmin = null;
     private PermissionAdmin permissionAdmin = null;
 
 
-    private HashMap<String, ApplicationId> appTracker = null;
+    private Map<String, ApplicationId> appTracker = null;
 
 
-    private HashMap<Permission, Set<String>> serviceDirectory = null;
+    private Map<Permission, Set<String>> serviceDirectory = null;
 
 
 
 
     @Activate
     @Activate
@@ -93,7 +93,7 @@ public class SecurityModeManager {
         bundleContext.addBundleListener(securityBundleListener);
         bundleContext.addBundleListener(securityBundleListener);
         appAdminService.addListener(securityApplicationListener);
         appAdminService.addListener(securityApplicationListener);
         logReaderService.addLogListener(securityLogListener);
         logReaderService.addLogListener(securityLogListener);
-        appTracker = new FastHashMap();
+        appTracker = new ConcurrentHashMap<>();
 
 
         permissionAdmin = getPermissionAdmin(bundleContext);
         permissionAdmin = getPermissionAdmin(bundleContext);
         if (permissionAdmin == null) {
         if (permissionAdmin == null) {