ONOS-393 - In a multi ONOS system, a ink may not yet be known about.

[Merged from master] Change-Id: Ife53b41ec9ff577e7e5c80bbd8a25f89e08942cf (cherry picked from commit 7bbeb3fe)

ONOS-393 - In a multi ONOS system, a ink may not yet be known about.
[Merged from master] Change-Id: Ife53b41ec9ff577e7e5c80bbd8a25f89e08942cf (cherry picked from commit 7bbeb3fe)
Ray Milkey · Pavlin Radoslavov
Commit 7a1d4a8d830dff7c204e7a62ce34c64935a9ef6a 7a1d4a8d 1 parent acdb3e0f
Showing 2 changed files with 40 additions and 43 deletions
core/net/src/main/java/org/onosproject/net/link/impl/LinkManager.java
core/store/dist/src/main/java/org/onosproject/store/link/impl/GossipLinkStore.java
--- a/core/net/src/main/java/org/onosproject/net/link/impl/LinkManager.java
View file @7a1d4a8
+++ b/core/net/src/main/java/org/onosproject/net/link/impl/LinkManager.java
View file @7a1d4a8
@@ -15,9 +15,6 @@
  */
 package org.onosproject.net.link.impl;
-import static com.google.common.base.Preconditions.checkNotNull;
-import static org.slf4j.LoggerFactory.getLogger;
-
 import java.util.Set;
 import org.apache.felix.scr.annotations.Activate;
@@ -29,7 +26,6 @@ import org.apache.felix.scr.annotations.Service;
 import org.onosproject.event.AbstractListenerRegistry;
 import org.onosproject.event.EventDeliveryService;
 import org.onosproject.net.ConnectPoint;
-import org.onosproject.net.Device;
 import org.onosproject.net.DeviceId;
 import org.onosproject.net.Link;
 import org.onosproject.net.Link.State;
@@ -55,6 +51,9 @@ import com.google.common.base.Predicate;
 import com.google.common.collect.FluentIterable;
 import com.google.common.collect.Sets;
+import static com.google.common.base.Preconditions.checkNotNull;
+import static org.slf4j.LoggerFactory.getLogger;
+
 /**
  * Provides basic implementation of the link SB &amp; NB APIs.
  */
@@ -274,20 +273,6 @@ public class LinkManager
     // Removes all links in the specified set and emits appropriate events.
     private void  removeLinks(Set<Link> links, boolean isSoftRemove) {
         for (Link link : links) {
-            final Device srcDevice = deviceService.getDevice(link.src().deviceId());
-            final Device dstDevice = deviceService.getDevice(link.dst().deviceId());
-            if (srcDevice != null &&
-                    dstDevice != null &&
-                    !srcDevice.type().equals(dstDevice.type())) {
-                //TODO this is awful. need to be fixed so that we don't down
-                // configured links. perhaps add a mechanism to figure out the
-                // state of this link
-                log.info("Ignoring removal of link as device types are " +
-                                 "different {} {} ",
-                         link.src() ,
-                         link.dst());
-                continue;
-            }
             LinkEvent event = isSoftRemove ?
                     store.removeOrDownLink(link.src(), link.dst()) :
                     store.removeLink(link.src(), link.dst());
--- a/core/store/dist/src/main/java/org/onosproject/store/link/impl/GossipLinkStore.java
View file @7a1d4a8
+++ b/core/store/dist/src/main/java/org/onosproject/store/link/impl/GossipLinkStore.java
View file @7a1d4a8
@@ -15,11 +15,20 @@
  */
 package org.onosproject.store.link.impl;
-import com.google.common.base.Function;
+import java.io.IOException;
-import com.google.common.collect.FluentIterable;
+import java.util.Collections;
-import com.google.common.collect.HashMultimap;
+import java.util.HashMap;
-import com.google.common.collect.ImmutableList;
+import java.util.HashSet;
-import com.google.common.collect.SetMultimap;
+import java.util.Map;
+import java.util.Map.Entry;
+import java.util.Objects;
+import java.util.Set;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.TimeUnit;
 import org.apache.commons.lang3.RandomUtils;
 import org.apache.felix.scr.annotations.Activate;
@@ -28,6 +37,7 @@ import org.apache.felix.scr.annotations.Deactivate;
 import org.apache.felix.scr.annotations.Reference;
 import org.apache.felix.scr.annotations.ReferenceCardinality;
 import org.apache.felix.scr.annotations.Service;
+import org.onlab.util.KryoNamespace;
 import org.onosproject.cluster.ClusterService;
 import org.onosproject.cluster.ControllerNode;
 import org.onosproject.cluster.NodeId;
@@ -57,28 +67,20 @@ import org.onosproject.store.cluster.messaging.MessageSubject;
 import org.onosproject.store.impl.Timestamped;
 import org.onosproject.store.serializers.KryoSerializer;
 import org.onosproject.store.serializers.impl.DistributedStoreSerializers;
-import org.onlab.util.KryoNamespace;
 import org.slf4j.Logger;
-import java.io.IOException;
+import com.google.common.base.Function;
-import java.util.Collections;
+import com.google.common.collect.FluentIterable;
-import java.util.HashMap;
+import com.google.common.collect.HashMultimap;
-import java.util.HashSet;
+import com.google.common.collect.ImmutableList;
-import java.util.Map;
+import com.google.common.collect.SetMultimap;
-import java.util.Map.Entry;
-import java.util.Objects;
-import java.util.Set;
-import java.util.concurrent.ConcurrentHashMap;
-import java.util.concurrent.ConcurrentMap;
-import java.util.concurrent.ExecutorService;
-import java.util.concurrent.Executors;
-import java.util.concurrent.ScheduledExecutorService;
-import java.util.concurrent.TimeUnit;
 import static com.google.common.base.Preconditions.checkNotNull;
 import static com.google.common.base.Predicates.notNull;
 import static com.google.common.collect.Multimaps.synchronizedSetMultimap;
 import static java.util.concurrent.Executors.newSingleThreadScheduledExecutor;
+import static org.onlab.util.Tools.minPriority;
+import static org.onlab.util.Tools.namedThreads;
 import static org.onosproject.cluster.ControllerNodeToNodeId.toNodeId;
 import static org.onosproject.net.DefaultAnnotations.merge;
 import static org.onosproject.net.DefaultAnnotations.union;
@@ -87,10 +89,10 @@ import static org.onosproject.net.Link.State.INACTIVE;
 import static org.onosproject.net.Link.Type.DIRECT;
 import static org.onosproject.net.Link.Type.INDIRECT;
 import static org.onosproject.net.LinkKey.linkKey;
-import static org.onosproject.net.link.LinkEvent.Type.*;
+import static org.onosproject.net.link.LinkEvent.Type.LINK_ADDED;
+import static org.onosproject.net.link.LinkEvent.Type.LINK_REMOVED;
+import static org.onosproject.net.link.LinkEvent.Type.LINK_UPDATED;
 import static org.onosproject.store.link.impl.GossipLinkStoreMessageSubjects.LINK_ANTI_ENTROPY_ADVERTISEMENT;
-import static org.onlab.util.Tools.minPriority;
-import static org.onlab.util.Tools.namedThreads;
 import static org.slf4j.LoggerFactory.getLogger;
 /**
@@ -236,7 +238,12 @@ public class GossipLinkStore
         Set<Link> egress = new HashSet<>();
         for (LinkKey linkKey : srcLinks.get(src.deviceId())) {
             if (linkKey.src().equals(src)) {
-                egress.add(links.get(linkKey));
+                Link link = links.get(linkKey);
+                if (link != null) {
+                    egress.add(link);
+                } else {
+                    log.debug("Egress link for {} was null, skipped", linkKey);
+                }
             }
         }
         return egress;
@@ -247,7 +254,12 @@ public class GossipLinkStore
         Set<Link> ingress = new HashSet<>();
         for (LinkKey linkKey : dstLinks.get(dst.deviceId())) {
             if (linkKey.dst().equals(dst)) {
-                ingress.add(links.get(linkKey));
+                Link link = links.get(linkKey);
+                if (link != null) {
+                    ingress.add(link);
+                } else {
+                    log.debug("Ingress link for {} was null, skipped", linkKey);
+                }
             }
         }
         return ingress;