Added Constant file, to resolve hardcoded value from NetconfDeviceProviderTest.

Change-Id: I66e9c761b2b40e5a237ceecac4b82d035c9fb7f1

Added Constant file, to resolve hardcoded value from NetconfDeviceProviderTest.
Change-Id: I66e9c761b2b40e5a237ceecac4b82d035c9fb7f1
Samir Anand · Gerrit Code Review
Commit 7b270f5dc4257f47c43576f60b02f63b6207196a 7b270f5d 1 parent e27055be
Showing 2 changed files with 80 additions and 67 deletions
providers/netconf/device/src/test/java/org/onosproject/provider/netconf/device/impl/NetconfDeviceProviderTest.java
providers/netconf/device/src/test/java/org/onosproject/provider/netconf/device/impl/NetconfDeviceProviderTestConstant.java
--- a/providers/netconf/device/src/test/java/org/onosproject/provider/netconf/device/impl/NetconfDeviceProviderTest.java
View file @7b270f5
+++ b/providers/netconf/device/src/test/java/org/onosproject/provider/netconf/device/impl/NetconfDeviceProviderTest.java
View file @7b270f5
@@ -19,10 +19,10 @@ import static org.easymock.EasyMock.expect;
 import static org.easymock.EasyMock.replay;
 import static org.junit.Assert.assertFalse;
 import static org.onlab.util.Tools.delay;
+import static org.onosproject.provider.netconf.device.impl.NetconfDeviceProviderTestConstant.*;
 import static org.slf4j.LoggerFactory.getLogger;
 import java.io.IOException;
-import java.net.SocketTimeoutException;
 import java.net.URI;
 import java.net.URISyntaxException;
 import java.util.Collection;
@@ -57,11 +57,8 @@ import com.tailf.jnc.JNCException;
 /**
  * Test Case to Validate Netconf Device Provider.
- *
  */
 public class NetconfDeviceProviderTest {
-    // private NetconfDevice device;
-
     TestDeviceCreator create;
     private final Logger log = getLogger(NetconfDeviceProviderTest.class);
@@ -70,12 +67,7 @@ public class NetconfDeviceProviderTest {
     private DeviceProviderService providerService;
-    private static final int EVENTINTERVAL = 5;
+    private static final DeviceId DID1 = DeviceId.deviceId(DEVICE_ID);
-
-    private static final String SCHEME = "netconf";
-
-    private static final DeviceId DID1 = DeviceId
-            .deviceId("of:0000000000000001");
     private final NetconfDeviceProvider provider = new NetconfDeviceProvider();
     private final TestDeviceRegistry registry = new TestDeviceRegistry();
@@ -90,22 +82,10 @@ public class NetconfDeviceProviderTest {
     }
     @SuppressWarnings("unchecked")
-    private Dictionary<String, String> getDictionaryMock(ComponentContext componentContext) {
-        Dictionary<String, String> dictionary = EasyMock
-                .createMock(Dictionary.class);
-        expect(dictionary.get("devConfigs"))
-                .andReturn("cisco:cisco@10.18.11.14:22:active,"
-                                   + "sanjay:b33rb3lly@10.18.24.122:2022:inactive");
-        replay(dictionary);
-        expect(componentContext.getProperties()).andReturn(dictionary);
-        return dictionary;
-    }
-
-    @SuppressWarnings("unchecked")
     private Dictionary<String, String> getDictionaryMockWithoutValues(ComponentContext componentContext) {
         Dictionary<String, String> dictionary = EasyMock
                 .createMock(Dictionary.class);
-        expect(dictionary.get("devConfigs")).andReturn("");
+        expect(dictionary.get(DEV_CONFIG)).andReturn(NULL);
         replay(dictionary);
         expect(componentContext.getProperties()).andReturn(dictionary);
         return dictionary;
@@ -115,7 +95,7 @@ public class NetconfDeviceProviderTest {
     private Dictionary<String, String> getDictionaryMockWithDeviceEntryNull(ComponentContext componentContext) {
         Dictionary<String, String> dictionary = EasyMock
                 .createMock(Dictionary.class);
-        expect(dictionary.get("devConfigs")).andReturn("null,null");
+        expect(dictionary.get(DEV_CONFIG)).andReturn(NULL_NULL);
         replay(dictionary);
         expect(componentContext.getProperties()).andReturn(dictionary);
         return dictionary;
@@ -125,8 +105,8 @@ public class NetconfDeviceProviderTest {
     private Dictionary<String, String> getDictionaryMockDeviceEntryNumberFomatEx(ComponentContext componentContext) {
         Dictionary<String, String> dictionary = EasyMock
                 .createMock(Dictionary.class);
-        expect(dictionary.get("devConfigs"))
+        expect(dictionary.get(DEV_CONFIG))
-                .andReturn("cisco:cisco@10.18.11.14:cisco:active")
+                .andReturn(CONFIG_WITH_INVALID_ENTRY_NUMBER)
                 .andThrow(new NumberFormatException());
         replay(dictionary);
         expect(componentContext.getProperties()).andReturn(dictionary);
@@ -137,8 +117,7 @@ public class NetconfDeviceProviderTest {
     private Dictionary<String, String> getDictionaryMockWithoutUsernameAndPassword(ComponentContext componentContext) {
         Dictionary<String, String> dictionary = EasyMock
                 .createMock(Dictionary.class);
-        expect(dictionary.get("devConfigs"))
+        expect(dictionary.get(DEV_CONFIG)).andReturn(CONFIG_WITH_NULL_ENTRY);
-                .andReturn("null:null@null:0:active");
         replay(dictionary);
         expect(componentContext.getProperties()).andReturn(dictionary);
         return dictionary;
@@ -148,9 +127,8 @@ public class NetconfDeviceProviderTest {
     private Dictionary<String, String> getDictionaryMockWithDifferentDeviceState(ComponentContext componentContext) {
         Dictionary<String, String> dictionary = EasyMock
                 .createMock(Dictionary.class);
-        expect(dictionary.get("devConfigs"))
+        expect(dictionary.get(DEV_CONFIG))
-                .andReturn("cisco:cisco@10.18.11.14:22:active,cisco:cisco@10.18.11.18:22:inactive,"
+                .andReturn(CONFIG_WITH_DIFFERENT_DEVICE_STATE);
-                                   + "cisco:cisco@10.18.11.14:22:invalid,cisco:cisco@10.18.11.14:22:null");
         replay(dictionary);
         expect(componentContext.getProperties()).andReturn(dictionary);
         return dictionary;
@@ -160,8 +138,8 @@ public class NetconfDeviceProviderTest {
     private Dictionary<String, String> getDictionaryMockDeviceWithArrayOutOFBoundEx(ComponentContext componentContext) {
         Dictionary<String, String> dictionary = EasyMock
                 .createMock(Dictionary.class);
-        expect(dictionary.get("devConfigs"))
+        expect(dictionary.get(DEV_CONFIG))
-                .andReturn("@10.18.11.14:22:active")
+                .andReturn(CONFIG_WITH_ARRAY_OUT_OF_BOUNDEX)
                 .andThrow(new ArrayIndexOutOfBoundsException());
         replay(dictionary);
         expect(componentContext.getProperties()).andReturn(dictionary);
@@ -172,21 +150,23 @@ public class NetconfDeviceProviderTest {
     private Dictionary<String, String> getDictionaryMockDeviceEntryForDeactivate(ComponentContext componentContext) {
         Dictionary<String, String> dictionary = EasyMock
                 .createMock(Dictionary.class);
-        expect(dictionary.get("devConfigs"))
+        expect(dictionary.get(DEV_CONFIG))
-                .andReturn("netconf:cisco@10.18.11.14:22:active")
+                .andReturn(CONFIG_ENTRY_FOR_DEACTIVATE)
                 .andThrow(new ArrayIndexOutOfBoundsException());
         replay(dictionary);
         expect(componentContext.getProperties()).andReturn(dictionary);
         return dictionary;
     }
-    @Ignore("Test fails if the hard coded host actually exists.")
+    @Ignore
-    @Test(expected = SocketTimeoutException.class)
+    @Test(expected = IOException.class)
-    public void testSSHAuthentication() throws JNCException, IOException {
+    public void testSSHAuthentication() throws IOException, JNCException {
-        NetconfDevice netconfDevice = new NetconfDevice("10.18.14.19", 22,
+        TestDeviceCreator objForTestDev = new TestDeviceCreator(
-                                                        "cisco", "cisco");
+                                                                new NetconfDevice(
-        netconfDevice.setConnectTimeout(1000);
+                                                                                  DEVICE_IP,
-        TestDeviceCreator objForTestDev = new TestDeviceCreator(netconfDevice,
+                                                                                  DEVICE_PORT,
+                                                                                  DEVICE_USERNAME,
+                                                                                  DEVICE_PASSWORD),
                                                                 true);
         objForTestDev.run();
     }
@@ -197,16 +177,6 @@ public class NetconfDeviceProviderTest {
         provider.cfgService = null;
     }
-    @Test
-    public void testActiveWithComponentContext() {
-
-        ComponentContext componentContext = EasyMock
-                .createMock(ComponentContext.class);
-        getDictionaryMock(componentContext);
-        replay(componentContext);
-        provider.activate(componentContext);
-    }
-
     // To check if deviceCfgValue is empty or null
     @Test
     public void testActiveWithcomponentContextIsNull() {
@@ -273,7 +243,7 @@ public class NetconfDeviceProviderTest {
     public void isReachableWithInvalidDeviceId() {
         assertFalse("Initially the Device ID Should not be reachable",
                     provider.isReachable(DID1));
-        NetconfDevice device = new NetconfDevice("", 0, "", "");
+        NetconfDevice device = new NetconfDevice(NULL, ZERO, NULL, NULL);
         provider.netconfDeviceMap.put(DID1, device);
         assertFalse("Particular Device ID cannot be Reachable",
                     provider.isReachable(DID1));
@@ -286,7 +256,7 @@ public class NetconfDeviceProviderTest {
                 .createMock(ComponentContext.class);
         getDictionaryMockDeviceEntryForDeactivate(componentContext);
         replay(componentContext);
-        testActiveWithComponentContext();
+        testActiveWithDeviceEntryWithDifferentDeviceState();
         provider.deactivate(componentContext);
     }
@@ -312,7 +282,6 @@ public class NetconfDeviceProviderTest {
         /**
          * For each Netconf Device, remove the entry from the device store.
-         * @throws URISyntaxException
          */
         private void removeDevices() {
             if (device == null) {
@@ -343,8 +312,7 @@ public class NetconfDeviceProviderTest {
          * Initialize Netconf Device object, and notify core saying device
          * connected.
          */
-        private void advertiseDevices()
+        private void advertiseDevices() throws JNCException, IOException {
-                throws JNCException, IOException, SocketTimeoutException {
             try {
                 if (device == null) {
                     log.warn("The Request Netconf Device is null, cannot proceed further");
@@ -356,9 +324,10 @@ public class NetconfDeviceProviderTest {
                 DeviceDescription desc = new DefaultDeviceDescription(
                                                                       did.uri(),
                                                                       Device.Type.OTHER,
-                                                                      "", "",
+                                                                      NULL,
-                                                                      "", "",
+                                                                      NULL,
-                                                                      cid);
+                                                                      NULL,
+                                                                      NULL, cid);
                 log.info("Persisting Device" + did.uri().toString());
                 netconfDeviceMap.put(did, device);
@@ -372,22 +341,20 @@ public class NetconfDeviceProviderTest {
                         + " couldn't persist the device onto the store", e);
             } catch (JNCException e) {
                 throw e;
-            } catch (SocketTimeoutException e) {
-                throw e;
             } catch (IOException e) {
                 throw e;
             } catch (Exception e) {
                 log.error("Error while initializing session for the device: "
-                        + (device != null ? device.deviceInfo() : null), e);
+                        + device.deviceInfo(), e);
             }
         }
         private DeviceId getDeviceId() throws URISyntaxException {
             String additionalSSP = new StringBuilder(device.getUsername())
-                    .append("@").append(device.getSshHost()).append(":")
+                    .append(AT_THE_RATE).append(device.getSshHost())
-                    .append(device.getSshPort()).toString();
+                    .append(COLON).append(device.getSshPort()).toString();
-            DeviceId did = DeviceId.deviceId(new URI(SCHEME, additionalSSP,
+            DeviceId did = DeviceId.deviceId(new URI(SCHEME_NETCONF,
-                                                     null));
+                                                     additionalSSP, null));
             return did;
         }
     }
--- a/providers/netconf/device/src/test/java/org/onosproject/provider/netconf/device/impl/NetconfDeviceProviderTestConstant.java 0 → 100644
View file @7b270f5
+++ b/providers/netconf/device/src/test/java/org/onosproject/provider/netconf/device/impl/NetconfDeviceProviderTestConstant.java 0 → 100644
View file @7b270f5
+/*
+ * Copyright 2015 Open Networking Laboratory
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.onosproject.provider.netconf.device.impl;
+
+public final class NetconfDeviceProviderTestConstant {
+
+    private NetconfDeviceProviderTestConstant() {
+    }
+
+    public static final int ZERO = 0;
+    public static final int EVENTINTERVAL = 5;
+    public static final String DEV_CONFIG = "devConfigs";
+    public static final String CONFIG_WITH_INVALID_ENTRY_NUMBER = "cisco:cisco"
+            + "@10.18.11.14:cisco:active";
+    public static final String CONFIG_WITH_NULL_ENTRY = "null:null@null:0:active";
+    public static final String CONFIG_WITH_DIFFERENT_DEVICE_STATE = "cisco:cisco@10.18.11.14:22:active,"
+            + "cisco:cisco@10.18.11.18:22:inactive,cisco:cisco@10.18.11.14:22:invalid,"
+            + "cisco:cisco@10.18.11.14:22:null";
+    public static final String CONFIG_WITH_ARRAY_OUT_OF_BOUNDEX = "@10.18.11.14:22:active";
+    public static final String CONFIG_ENTRY_FOR_DEACTIVATE = "netconf:cisco"
+            + "@10.18.11.14:22:active";
+    public static final String DEVICE_IP = "10.18.14.19";
+    public static final int DEVICE_PORT = 22;
+    public static final String DEVICE_USERNAME = "cisco";
+    public static final String DEVICE_PASSWORD = "cisco";
+    public static final String AT_THE_RATE = "@";
+    public static final String COLON = ":";
+    public static final String NULL = "";
+    public static final String NULL_NULL = "null,null";
+    public static final String SCHEME_NETCONF = "netconf";
+    public static final String DEVICE_ID = "of:0000000000000001";
+
+}