Do not remove the topic from the CandidateMap even when the list of candidates

is empty. This makes the implementation and logic simpler and more consistent.

Change-Id: Ib55c5b9a020e147784cdf6156da2c47e70a3a6c2

@@ -255,17 +255,7 @@ public class DistributedLeadershipManager implements LeadershipService {
             if (!candidateList.remove(localNodeId)) {
             if (!candidateList.remove(localNodeId)) {
                 return;
                 return;
             }
             }
-            boolean success = false;
-            if (candidateList.isEmpty()) {
-                if (candidateMap.remove(path, candidates.version())) {
-                    success = true;
-                }
-            } else {
             if (candidateMap.replace(path, candidates.version(), candidateList)) {
             if (candidateMap.replace(path, candidates.version(), candidateList)) {
-                    success = true;
-                }
-            }
-            if (success) {
                 Versioned<List<NodeId>> newCandidates = candidateMap.get(path);
                 Versioned<List<NodeId>> newCandidates = candidateMap.get(path);
                 notifyCandidateRemoved(path, candidates.version(), candidates.creationTime(), newCandidates);
                 notifyCandidateRemoved(path, candidates.version(), candidates.creationTime(), newCandidates);
             } else {
             } else {
@@ -366,21 +356,10 @@ public class DistributedLeadershipManager implements LeadershipService {
         final MutableBoolean updated = new MutableBoolean(false);
         final MutableBoolean updated = new MutableBoolean(false);
 
 
         candidateBoard.compute(path, (k, current) -> {
         candidateBoard.compute(path, (k, current) -> {
-            if (candidates != null) {
             if (current != null && current.epoch() < newInfo.epoch()) {
             if (current != null && current.epoch() < newInfo.epoch()) {
                 updated.setTrue();
                 updated.setTrue();
-                    if (candidates.value().isEmpty()) {
-                        return null;
-                    } else {
                 return newInfo;
                 return newInfo;
             }
             }
-                }
-            } else {
-                if (current != null && current.epoch() == oldEpoch) {
-                    updated.setTrue();
-                    return null;
-                }
-            }
             return current;
             return current;
         });
         });
         // maybe rethink types of candidates events
         // maybe rethink types of candidates events
@@ -471,11 +450,8 @@ public class DistributedLeadershipManager implements LeadershipService {
                 });
                 });
             } else if (eventType.equals(LeadershipEvent.Type.CANDIDATES_CHANGED)) {
             } else if (eventType.equals(LeadershipEvent.Type.CANDIDATES_CHANGED)) {
                 candidateBoard.compute(topic, (k, currentInfo) -> {
                 candidateBoard.compute(topic, (k, currentInfo) -> {
-                    if (currentInfo == null || currentInfo.epoch() <= leadershipUpdate.epoch()) {
+                    if (currentInfo == null || currentInfo.epoch() < leadershipUpdate.epoch()) {
                         updateAccepted.setTrue();
                         updateAccepted.setTrue();
-                        if (leadershipUpdate.candidates().isEmpty()) {
-                            return null;
-                        }
                         return leadershipUpdate;
                         return leadershipUpdate;
                     }
                     }
                     return currentInfo;
                     return currentInfo;