Committed by
Brian O'Connor
Remove unnecessary empty set check
It isn't harmful to remove the if statement because missing.forEach() doesn't call the specified lambda when it is empty. Change-Id: I3f43f5fd4a4422899c621f2a63c0259f1bae838a
Showing
1 changed file
with
0 additions
and
2 deletions
... | @@ -455,13 +455,11 @@ class ConfigProvider implements DeviceProvider, LinkProvider, HostProvider { | ... | @@ -455,13 +455,11 @@ class ConfigProvider implements DeviceProvider, LinkProvider, HostProvider { |
455 | .filter(cp -> !existing.contains(cp)) | 455 | .filter(cp -> !existing.contains(cp)) |
456 | .collect(Collectors.toSet()); | 456 | .collect(Collectors.toSet()); |
457 | 457 | ||
458 | - if (!missing.isEmpty()) { | ||
459 | List<PortDescription> newPorts = Lists.newArrayList(); | 458 | List<PortDescription> newPorts = Lists.newArrayList(); |
460 | ports.forEach(p -> newPorts.add(description(p))); | 459 | ports.forEach(p -> newPorts.add(description(p))); |
461 | missing.forEach(cp -> newPorts.add(description(cp))); | 460 | missing.forEach(cp -> newPorts.add(description(cp))); |
462 | deviceProviderService.updatePorts(device.id(), newPorts); | 461 | deviceProviderService.updatePorts(device.id(), newPorts); |
463 | } | 462 | } |
464 | - } | ||
465 | 463 | ||
466 | // Creates a port description from the specified port. | 464 | // Creates a port description from the specified port. |
467 | private PortDescription description(Port p) { | 465 | private PortDescription description(Port p) { | ... | ... |
-
Please register or login to post a comment