Fix shutdown crash if link pruner runs after services are shut down

Change-Id: I7eb3dc9ed19b1a20182d34f8e25df151e32f572f

@@ -144,6 +144,8 @@ public class LldpLinkProvider extends AbstractProvider implements ProbedLinkProv
 
 
     private ScheduledExecutorService executor;
     private ScheduledExecutorService executor;
 
 
+    private boolean shuttingDown = false;
+
     // TODO: Add sanity checking for the configurable params based on the delays
     // TODO: Add sanity checking for the configurable params based on the delays
     private static final long DEVICE_SYNC_DELAY = 5;
     private static final long DEVICE_SYNC_DELAY = 5;
     private static final long LINK_PRUNER_DELAY = 3;
     private static final long LINK_PRUNER_DELAY = 3;
@@ -240,6 +242,7 @@ public class LldpLinkProvider extends AbstractProvider implements ProbedLinkProv
 
 
     @Activate
     @Activate
     public void activate(ComponentContext context) {
     public void activate(ComponentContext context) {
+        shuttingDown = false;
         cfgService.registerProperties(getClass());
         cfgService.registerProperties(getClass());
         appId = coreService.registerApplication(PROVIDER_NAME);
         appId = coreService.registerApplication(PROVIDER_NAME);
 
 
@@ -271,6 +274,7 @@ public class LldpLinkProvider extends AbstractProvider implements ProbedLinkProv
 
 
     @Deactivate
     @Deactivate
     public void deactivate() {
     public void deactivate() {
+        shuttingDown = true;
         cfgRegistry.removeListener(cfgListener);
         cfgRegistry.removeListener(cfgListener);
         factories.forEach(cfgRegistry::unregisterConfigFactory);
         factories.forEach(cfgRegistry::unregisterConfigFactory);
 
 
@@ -358,7 +362,6 @@ public class LldpLinkProvider extends AbstractProvider implements ProbedLinkProv
         deviceService.removeListener(deviceListener);
         deviceService.removeListener(deviceListener);
         packetService.removeProcessor(packetProcessor);
         packetService.removeProcessor(packetProcessor);
 
 
-
         if (executor != null) {
         if (executor != null) {
             executor.shutdownNow();
             executor.shutdownNow();
         }
         }
@@ -696,7 +699,13 @@ public class LldpLinkProvider extends AbstractProvider implements ProbedLinkProv
 
 
             } catch (Exception e) {
             } catch (Exception e) {
                 // Catch all exceptions to avoid task being suppressed
                 // Catch all exceptions to avoid task being suppressed
+                if (!shuttingDown) {
+                    // Error condition
                     log.error("Exception thrown during link pruning process", e);
                     log.error("Exception thrown during link pruning process", e);
+                } else {
+                    // Provider is shutting down, the error can be ignored
+                    log.trace("Shutting down, ignoring error", e);
+                }
             }
             }
         }
         }