Added isLinkLocal predicate to MacAddress and used it in ReactiveForwarding.

Thomas Vachuska
Commit e1bcb0b3efc4d0fa7ca225f0c15e7daee41b58c1 e1bcb0b3 1 parent fc58467f
Showing 3 changed files with 71 additions and 97 deletions
apps/fwd/src/main/java/org/onlab/onos/fwd/ReactiveForwarding.java
providers/lldp/src/main/java/org/onlab/onos/provider/lldp/impl/LinkDiscovery.java
utils/misc/src/main/java/org/onlab/packet/MacAddress.java
--- a/apps/fwd/src/main/java/org/onlab/onos/fwd/ReactiveForwarding.java
View file @e1bcb0b
+++ b/apps/fwd/src/main/java/org/onlab/onos/fwd/ReactiveForwarding.java
View file @e1bcb0b
@@ -137,6 +137,11 @@ public class ReactiveForwarding {
             HostId id = HostId.hostId(ethPkt.getDestinationMAC());
+            // Do not process link-local addresses in any way.
+            if (id.mac().isLinkLocal()) {
+                return;
+            }
+
             // Do we know who this is for? If not, flood and bail.
             Host dst = hostService.getHost(id);
             if (dst == null) {
--- a/providers/lldp/src/main/java/org/onlab/onos/provider/lldp/impl/LinkDiscovery.java
View file @e1bcb0b
+++ b/providers/lldp/src/main/java/org/onlab/onos/provider/lldp/impl/LinkDiscovery.java
View file @e1bcb0b
@@ -18,20 +18,6 @@
  */
 package org.onlab.onos.provider.lldp.impl;
-
-import static com.google.common.base.Preconditions.checkNotNull;
-import static org.slf4j.LoggerFactory.getLogger;
-
-import java.nio.ByteBuffer;
-import java.util.Collections;
-import java.util.HashMap;
-import java.util.HashSet;
-import java.util.Iterator;
-import java.util.Map;
-import java.util.Set;
-import java.util.concurrent.TimeUnit;
-import java.util.concurrent.atomic.AtomicInteger;
-
 import org.jboss.netty.util.Timeout;
 import org.jboss.netty.util.TimerTask;
 import org.onlab.onos.mastership.MastershipService;
@@ -39,10 +25,8 @@ import org.onlab.onos.net.ConnectPoint;
 import org.onlab.onos.net.Device;
 import org.onlab.onos.net.DeviceId;
 import org.onlab.onos.net.Link.Type;
-import org.onlab.onos.net.MastershipRole;
 import org.onlab.onos.net.Port;
 import org.onlab.onos.net.PortNumber;
-import org.onlab.onos.net.flow.DefaultTrafficTreatment;
 import org.onlab.onos.net.link.DefaultLinkDescription;
 import org.onlab.onos.net.link.LinkDescription;
 import org.onlab.onos.net.link.LinkProviderService;
@@ -55,7 +39,21 @@ import org.onlab.packet.ONOSLLDP;
 import org.onlab.util.Timer;
 import org.slf4j.Logger;
+import java.nio.ByteBuffer;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.Iterator;
+import java.util.Map;
+import java.util.Set;
+import java.util.concurrent.atomic.AtomicInteger;
+import static com.google.common.base.Preconditions.checkNotNull;
+import static java.util.concurrent.TimeUnit.MILLISECONDS;
+import static org.onlab.onos.net.MastershipRole.MASTER;
+import static org.onlab.onos.net.PortNumber.portNumber;
+import static org.onlab.onos.net.flow.DefaultTrafficTreatment.builder;
+import static org.slf4j.LoggerFactory.getLogger;
 /**
  * Run discovery process from a physical switch. Ports are initially labeled as
@@ -63,7 +61,7 @@ import org.slf4j.Logger;
  * fast. Every probeRate milliseconds, loop over all fast ports and send an
  * LLDP, send an LLDP for a single slow port. Based on FlowVisor topology
  * discovery implementation.
- *
+ * <p/>
  * TODO: add 'fast discovery' mode: drop LLDPs in destination switch but listen
  * for flow_removed messages
  */
@@ -93,13 +91,14 @@ public class LinkDiscovery implements TimerTask {
      * Instantiates discovery manager for the given physical switch. Creates a
      * generic LLDP packet that will be customized for the port it is sent out on.
      * Starts the the timer for the discovery process.
+     *
      * @param device        the physical switch
-     * @param masterService
+     * @param masterService mastership service
      * @param useBDDP       flag to also use BDDP for discovery
      */
     public LinkDiscovery(Device device, PacketService pktService,
-                         MastershipService masterService, LinkProviderService providerService, Boolean... useBDDP) {
+                         MastershipService masterService,
-
+                         LinkProviderService providerService, Boolean... useBDDP) {
         this.device = device;
         this.probeRate = 3000;
         this.linkProvider = providerService;
@@ -142,16 +141,12 @@ public class LinkDiscovery implements TimerTask {
      * @param port the port
      */
     public void addPort(final Port port) {
-        this.log.debug("sending init probe to port {}@{}",
+        this.log.debug("Sending init probe to port {}@{}",
                        port.number().toLong(), device.id());
-
         sendProbes(port.number().toLong());
-
         synchronized (this) {
             this.slowPorts.add(port.number().toLong());
         }
-
-
     }
     /**
@@ -172,8 +167,7 @@ public class LinkDiscovery implements TimerTask {
                 this.portProbeCount.remove(portnum);
                 // no iterator to update
             } else {
-                this.log.warn(
+                this.log.warn("Tried to dynamically remove non-existing port {}",
-                        "tried to dynamically remove non-existing port {}",
                               portnum);
             }
         }
@@ -187,7 +181,6 @@ public class LinkDiscovery implements TimerTask {
      * @param portNumber the port
      */
     public void ackProbe(final Long portNumber) {
-
         synchronized (this) {
             if (this.slowPorts.contains(portNumber)) {
                 this.log.debug("Setting slow port to fast: {}:{}",
@@ -198,10 +191,7 @@ public class LinkDiscovery implements TimerTask {
             } else if (this.fastPorts.contains(portNumber)) {
                 this.portProbeCount.get(portNumber).set(0);
             } else {
-                    this.log.debug(
+                this.log.debug("Got ackProbe for non-existing port: {}", portNumber);
-                            "Got ackProbe for non-existing port: {}",
-                            portNumber);
-
             }
         }
     }
@@ -217,7 +207,7 @@ public class LinkDiscovery implements TimerTask {
         if (onoslldp != null) {
             final PortNumber dstPort =
                     context.inPacket().receivedFrom().port();
-            final PortNumber srcPort = PortNumber.portNumber(onoslldp.getPort());
+            final PortNumber srcPort = portNumber(onoslldp.getPort());
             final DeviceId srcDeviceId = DeviceId.deviceId(onoslldp.getDeviceString());
             final DeviceId dstDeviceId = context.inPacket().receivedFrom().deviceId();
             this.ackProbe(dstPort.toLong());
@@ -237,61 +227,48 @@ public class LinkDiscovery implements TimerTask {
     }
-
     /**
      * Execute this method every t milliseconds. Loops over all ports
      * labeled as fast and sends out an LLDP. Send out an LLDP on a single slow
      * port.
      *
      * @param t timeout
-     * @throws Exception
      */
     @Override
     public void run(final Timeout t) {
-        this.log.trace("sending probes from {}", device.id());
+        this.log.trace("Sending probes from {}", device.id());
         synchronized (this) {
             final Iterator<Long> fastIterator = this.fastPorts.iterator();
-            Long portNumber;
-            Integer probeCount;
             while (fastIterator.hasNext()) {
-                portNumber = fastIterator.next();
+                long portNumber = fastIterator.next();
-                probeCount = this.portProbeCount.get(portNumber)
+                int probeCount = portProbeCount.get(portNumber).getAndIncrement();
-                        .getAndIncrement();
                 if (probeCount < LinkDiscovery.MAX_PROBE_COUNT) {
-                    this.log.trace("sending fast probe to port {}", portNumber);
+                    this.log.trace("Sending fast probe to port {}", portNumber);
                     sendProbes(portNumber);
+
                 } else {
                     // Update fast and slow ports
                     fastIterator.remove();
                     this.slowPorts.add(portNumber);
                     this.portProbeCount.remove(portNumber);
-
+                    ConnectPoint cp = new ConnectPoint(device.id(),
-                    ConnectPoint cp = new ConnectPoint(
+                                                       portNumber(portNumber));
-                            device.id(),
-                            PortNumber.portNumber(portNumber));
                     log.debug("Link down -> {}", cp);
                     linkProvider.linksVanished(cp);
                 }
             }
             // send a probe for the next slow port
-            if (!this.slowPorts.isEmpty()) {
+            for (long portNumber : slowPorts) {
-                Iterator<Long> slowIterator = this.slowPorts.iterator();
+                this.log.trace("Sending slow probe to port {}", portNumber);
-                while (slowIterator.hasNext()) {
-                    portNumber = slowIterator.next();
-                    this.log.trace("sending slow probe to port {}", portNumber);
-
                 sendProbes(portNumber);
-
-                }
             }
         }
         // reschedule timer
-        timeout = Timer.getTimer().newTimeout(this, this.probeRate,
+        timeout = Timer.getTimer().newTimeout(this, this.probeRate, MILLISECONDS);
-                TimeUnit.MILLISECONDS);
     }
     public void stop() {
@@ -300,8 +277,7 @@ public class LinkDiscovery implements TimerTask {
     }
     public void start() {
-        timeout = Timer.getTimer().newTimeout(this, 0,
+        timeout = Timer.getTimer().newTimeout(this, 0, MILLISECONDS);
-                                              TimeUnit.MILLISECONDS);
         isStopped = false;
     }
@@ -319,12 +295,9 @@ public class LinkDiscovery implements TimerTask {
         this.ethPacket.setSourceMACAddress("DE:AD:BE:EF:BA:11");
         final byte[] lldp = this.ethPacket.serialize();
-        OutboundPacket outboundPacket = new DefaultOutboundPacket(
+        return new DefaultOutboundPacket(this.device.id(),
-                this.device.id(),
+                                         builder().setOutput(portNumber(port)).build(),
-                DefaultTrafficTreatment.builder().setOutput(
-                        PortNumber.portNumber(port)).build(),
                                          ByteBuffer.wrap(lldp));
-        return outboundPacket;
     }
     /**
@@ -341,25 +314,15 @@ public class LinkDiscovery implements TimerTask {
         this.bddpEth.setSourceMACAddress("DE:AD:BE:EF:BA:11");
         final byte[] bddp = this.bddpEth.serialize();
-        OutboundPacket outboundPacket = new DefaultOutboundPacket(
+        return new DefaultOutboundPacket(this.device.id(),
-                this.device.id(),
+                                         builder().setOutput(portNumber(port)).build(),
-                DefaultTrafficTreatment.builder()
-                        .setOutput(PortNumber.portNumber(port)).build(),
                                          ByteBuffer.wrap(bddp));
-        return outboundPacket;
     }
     private void sendProbes(Long portNumber) {
-       if (device == null) {
+        boolean isMaster = mastershipService.getLocalRole(device.id()) == MASTER;
-           log.warn("CRAZY SHIT");
+        if (isMaster && device.type() != Device.Type.ROADM) {
-       }
+            log.debug("Sending probes out to {}@{}", portNumber, device.id());
-       if (mastershipService == null) {
-           log.warn("INSANE");
-       }
-       if (device.type() != Device.Type.ROADM &&
-               mastershipService.getLocalRole(this.device.id()) ==
-               MastershipRole.MASTER) {
-           log.debug("sending probes out to {}@{}", portNumber, device.id());
             OutboundPacket pkt = this.createOutBoundLLDP(portNumber);
             pktService.emit(pkt);
             if (useBDDP) {
@@ -370,10 +333,7 @@ public class LinkDiscovery implements TimerTask {
     }
     public boolean containsPort(Long portNumber) {
-        if (slowPorts.contains(portNumber) || fastPorts.contains(portNumber)) {
+        return slowPorts.contains(portNumber) || fastPorts.contains(portNumber);
-            return true;
-        }
-        return false;
     }
     public boolean isStopped() {
--- a/utils/misc/src/main/java/org/onlab/packet/MacAddress.java
View file @e1bcb0b
+++ b/utils/misc/src/main/java/org/onlab/packet/MacAddress.java
View file @e1bcb0b
@@ -22,7 +22,6 @@ import java.util.Arrays;
 /**
  * The class representing MAC address.
- *
  */
 public class MacAddress {
@@ -32,6 +31,11 @@ public class MacAddress {
     public static final byte[] ZERO_MAC_ADDRESS = ZERO.getAddress();
     public static final byte[] BROADCAST_MAC = BROADCAST.getAddress();
+    private static final byte[] LL = new byte[]{
+            0x01, (byte) 0x80, (byte) 0xc2, 0x00, 0x00,
+            0x00, 0x0e, 0x03
+    };
+
     public static final int MAC_ADDRESS_LENGTH = 6;
     private byte[] address = new byte[MacAddress.MAC_ADDRESS_LENGTH];
@@ -43,12 +47,10 @@ public class MacAddress {
      * Returns a MAC address instance representing the value of the specified
      * {@code String}.
      *
-     * @param address
+     * @param address the String representation of the MAC Address to be parsed.
-     *            the String representation of the MAC Address to be parsed.
      * @return a MAC Address instance representing the value of the specified
      * {@code String}.
-     * @throws IllegalArgumentException
+     * @throws IllegalArgumentException if the string cannot be parsed as a MAC address.
-     *             if the string cannot be parsed as a MAC address.
      */
     public static MacAddress valueOf(final String address) {
         final String[] elements = address.split(":");
@@ -71,12 +73,10 @@ public class MacAddress {
      * Returns a MAC address instance representing the specified {@code byte}
      * array.
      *
-     * @param address
+     * @param address the byte array to be parsed.
-     *            the byte array to be parsed.
      * @return a MAC address instance representing the specified {@code byte}
      * array.
-     * @throws IllegalArgumentException
+     * @throws IllegalArgumentException if the byte array cannot be parsed as a MAC address.
-     *             if the byte array cannot be parsed as a MAC address.
      */
     public static MacAddress valueOf(final byte[] address) {
         if (address.length != MacAddress.MAC_ADDRESS_LENGTH) {
@@ -92,19 +92,17 @@ public class MacAddress {
      * value. The lower 48 bits of the long value are used to parse as a MAC
      * address.
      *
-     * @param address
+     * @param address the long value to be parsed. The lower 48 bits are used for a
-     *            the long value to be parsed. The lower 48 bits are used for a
      *                MAC address.
      * @return a MAC address instance representing the specified {@code long}
      * value.
-     * @throws IllegalArgumentException
+     * @throws IllegalArgumentException if the long value cannot be parsed as a MAC address.
-     *             if the long value cannot be parsed as a MAC address.
      */
     public static MacAddress valueOf(final long address) {
-        final byte[] addressInBytes = new byte[] {
+        final byte[] addressInBytes = new byte[]{
                 (byte) (address >> 40 & 0xff), (byte) (address >> 32 & 0xff),
                 (byte) (address >> 24 & 0xff), (byte) (address >> 16 & 0xff),
-                (byte) (address >> 8 & 0xff), (byte) (address >> 0 & 0xff) };
+                (byte) (address >> 8 & 0xff), (byte) (address >> 0 & 0xff)};
         return new MacAddress(addressInBytes);
     }
@@ -169,6 +167,17 @@ public class MacAddress {
         return (this.address[0] & 0x01) != 0;
     }
+    /**
+     * Returns true if this MAC address is link local.
+     *
+     * @return true if link local
+     */
+    public boolean isLinkLocal() {
+        return LL[0] == address[0] && LL[1] == address[1] && LL[2] == address[2] &&
+                LL[3] == address[3] && LL[4] == address[4] &&
+                (LL[5] == address[5] || LL[6] == address[5] || LL[7] == address[5]);
+    }
+
     @Override
     public boolean equals(final Object o) {
         if (o == this) {