RenameTests.cpp
32.1 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
//===-- RenameTests.cpp -----------------------------------------*- C++ -*-===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "Annotations.h"
#include "ClangdServer.h"
#include "SyncAPI.h"
#include "TestFS.h"
#include "TestTU.h"
#include "index/Ref.h"
#include "refactor/Rename.h"
#include "clang/Tooling/Core/Replacement.h"
#include "llvm/ADT/STLExtras.h"
#include "llvm/Support/MemoryBuffer.h"
#include "gmock/gmock.h"
#include "gtest/gtest.h"
#include <algorithm>
namespace clang {
namespace clangd {
namespace {
using testing::Eq;
using testing::Pair;
using testing::IsEmpty;
using testing::UnorderedElementsAre;
using testing::UnorderedElementsAreArray;
// Convert a Range to a Ref.
Ref refWithRange(const clangd::Range &Range, const std::string &URI) {
Ref Result;
Result.Kind = RefKind::Reference;
Result.Location.Start.setLine(Range.start.line);
Result.Location.Start.setColumn(Range.start.character);
Result.Location.End.setLine(Range.end.line);
Result.Location.End.setColumn(Range.end.character);
Result.Location.FileURI = URI.c_str();
return Result;
}
// Build a RefSlab from all marked ranges in the annotation. The ranges are
// assumed to associate with the given SymbolName.
std::unique_ptr<RefSlab> buildRefSlab(const Annotations &Code,
llvm::StringRef SymbolName,
llvm::StringRef Path) {
RefSlab::Builder Builder;
TestTU TU;
TU.HeaderCode = Code.code();
auto Symbols = TU.headerSymbols();
const auto &SymbolID = findSymbol(Symbols, SymbolName).ID;
std::string PathURI = URI::create(Path).toString();
for (const auto &Range : Code.ranges())
Builder.insert(SymbolID, refWithRange(Range, PathURI));
return std::make_unique<RefSlab>(std::move(Builder).build());
}
std::vector<
std::pair</*FilePath*/ std::string, /*CodeAfterRename*/ std::string>>
applyEdits(FileEdits FE) {
std::vector<std::pair<std::string, std::string>> Results;
for (auto &It : FE)
Results.emplace_back(
It.first().str(),
llvm::cantFail(tooling::applyAllReplacements(
It.getValue().InitialCode, It.getValue().Replacements)));
return Results;
}
// Generates an expected rename result by replacing all ranges in the given
// annotation with the NewName.
std::string expectedResult(Annotations Test, llvm::StringRef NewName) {
std::string Result;
unsigned NextChar = 0;
llvm::StringRef Code = Test.code();
for (const auto &R : Test.llvm::Annotations::ranges()) {
assert(R.Begin <= R.End && NextChar <= R.Begin);
Result += Code.substr(NextChar, R.Begin - NextChar);
Result += NewName;
NextChar = R.End;
}
Result += Code.substr(NextChar);
return Result;
}
TEST(RenameTest, WithinFileRename) {
// rename is runnning on all "^" points, and "[[]]" ranges point to the
// identifier that is being renamed.
llvm::StringRef Tests[] = {
// Function.
R"cpp(
void [[foo^]]() {
[[fo^o]]();
}
)cpp",
// Type.
R"cpp(
struct [[foo^]] {};
[[foo]] test() {
[[f^oo]] x;
return x;
}
)cpp",
// Local variable.
R"cpp(
void bar() {
if (auto [[^foo]] = 5) {
[[foo]] = 3;
}
}
)cpp",
// Rename class, including constructor/destructor.
R"cpp(
class [[F^oo]] {
[[F^oo]]();
~[[Foo]]();
void foo(int x);
};
[[Foo]]::[[Fo^o]]() {}
void [[Foo]]::foo(int x) {}
)cpp",
// Class in template argument.
R"cpp(
class [[F^oo]] {};
template <typename T> void func();
template <typename T> class Baz {};
int main() {
func<[[F^oo]]>();
Baz<[[F^oo]]> obj;
return 0;
}
)cpp",
// Forward class declaration without definition.
R"cpp(
class [[F^oo]];
[[Foo]] *f();
)cpp",
// Class methods overrides.
R"cpp(
struct A {
virtual void [[f^oo]]() {}
};
struct B : A {
void [[f^oo]]() override {}
};
struct C : B {
void [[f^oo]]() override {}
};
void func() {
A().[[f^oo]]();
B().[[f^oo]]();
C().[[f^oo]]();
}
)cpp",
// Template class (partial) specializations.
R"cpp(
template <typename T>
class [[F^oo]] {};
template<>
class [[F^oo]]<bool> {};
template <typename T>
class [[F^oo]]<T*> {};
void test() {
[[Foo]]<int> x;
[[Foo]]<bool> y;
[[Foo]]<int*> z;
}
)cpp",
// Template class instantiations.
R"cpp(
template <typename T>
class [[F^oo]] {
public:
T foo(T arg, T& ref, T* ptr) {
T value;
int number = 42;
value = (T)number;
value = static_cast<T>(number);
return value;
}
static void foo(T value) {}
T member;
};
template <typename T>
void func() {
[[F^oo]]<T> obj;
obj.member = T();
[[Foo]]<T>::foo();
}
void test() {
[[F^oo]]<int> i;
i.member = 0;
[[F^oo]]<int>::foo(0);
[[F^oo]]<bool> b;
b.member = false;
[[Foo]]<bool>::foo(false);
}
)cpp",
// Template class methods.
R"cpp(
template <typename T>
class A {
public:
void [[f^oo]]() {}
};
void func() {
A<int>().[[f^oo]]();
A<double>().[[f^oo]]();
A<float>().[[f^oo]]();
}
)cpp",
// Complicated class type.
R"cpp(
// Forward declaration.
class [[Fo^o]];
class Baz {
virtual int getValue() const = 0;
};
class [[F^oo]] : public Baz {
public:
[[Foo]](int value = 0) : x(value) {}
[[Foo]] &operator++(int);
bool operator<([[Foo]] const &rhs);
int getValue() const;
private:
int x;
};
void func() {
[[Foo]] *Pointer = 0;
[[Foo]] Variable = [[Foo]](10);
for ([[Foo]] it; it < Variable; it++);
const [[Foo]] *C = new [[Foo]]();
const_cast<[[Foo]] *>(C)->getValue();
[[Foo]] foo;
const Baz &BazReference = foo;
const Baz *BazPointer = &foo;
reinterpret_cast<const [[^Foo]] *>(BazPointer)->getValue();
static_cast<const [[^Foo]] &>(BazReference).getValue();
static_cast<const [[^Foo]] *>(BazPointer)->getValue();
}
)cpp",
// CXXConstructor initializer list.
R"cpp(
class Baz {};
class Qux {
Baz [[F^oo]];
public:
Qux();
};
Qux::Qux() : [[F^oo]]() {}
)cpp",
// DeclRefExpr.
R"cpp(
class C {
public:
static int [[F^oo]];
};
int foo(int x);
#define MACRO(a) foo(a)
void func() {
C::[[F^oo]] = 1;
MACRO(C::[[Foo]]);
int y = C::[[F^oo]];
}
)cpp",
// Macros.
R"cpp(
// no rename inside macro body.
#define M1 foo
#define M2(x) x
int [[fo^o]]();
void boo(int);
void qoo() {
[[foo]]();
boo([[foo]]());
M1();
boo(M1());
M2([[foo]]());
M2(M1()); // foo is inside the nested macro body.
}
)cpp",
// MemberExpr in macros
R"cpp(
class Baz {
public:
int [[F^oo]];
};
int qux(int x);
#define MACRO(a) qux(a)
int main() {
Baz baz;
baz.[[Foo]] = 1;
MACRO(baz.[[Foo]]);
int y = baz.[[Foo]];
}
)cpp",
// Template parameters.
R"cpp(
template <typename [[^T]]>
class Foo {
[[T]] foo([[T]] arg, [[T]]& ref, [[^T]]* ptr) {
[[T]] value;
int number = 42;
value = ([[T]])number;
value = static_cast<[[^T]]>(number);
return value;
}
static void foo([[T]] value) {}
[[T]] member;
};
)cpp",
// Typedef.
R"cpp(
namespace std {
class basic_string {};
typedef basic_string [[s^tring]];
} // namespace std
std::[[s^tring]] foo();
)cpp",
// Variable.
R"cpp(
namespace A {
int [[F^oo]];
}
int Foo;
int Qux = Foo;
int Baz = A::[[^Foo]];
void fun() {
struct {
int Foo;
} b = {100};
int Foo = 100;
Baz = Foo;
{
extern int Foo;
Baz = Foo;
Foo = A::[[F^oo]] + Baz;
A::[[Fo^o]] = b.Foo;
}
Foo = b.Foo;
}
)cpp",
// Namespace alias.
R"cpp(
namespace a { namespace b { void foo(); } }
namespace [[^x]] = a::b;
void bar() {
[[x]]::foo();
}
)cpp",
// Scope enums.
R"cpp(
enum class [[K^ind]] { ABC };
void ff() {
[[K^ind]] s;
s = [[Kind]]::ABC;
}
)cpp",
// template class in template argument list.
R"cpp(
template<typename T>
class [[Fo^o]] {};
template <template<typename> class Z> struct Bar { };
template <> struct Bar<[[Foo]]> {};
)cpp",
};
for (llvm::StringRef T : Tests) {
Annotations Code(T);
auto TU = TestTU::withCode(Code.code());
TU.ExtraArgs.push_back("-fno-delayed-template-parsing");
auto AST = TU.build();
llvm::StringRef NewName = "abcde";
for (const auto &RenamePos : Code.points()) {
auto RenameResult =
rename({RenamePos, NewName, AST, testPath(TU.Filename)});
ASSERT_TRUE(bool(RenameResult)) << RenameResult.takeError();
ASSERT_EQ(1u, RenameResult->size());
EXPECT_EQ(applyEdits(std::move(*RenameResult)).front().second,
expectedResult(Code, NewName));
}
}
}
TEST(RenameTest, Renameable) {
struct Case {
const char *Code;
const char* ErrorMessage; // null if no error
bool IsHeaderFile;
const SymbolIndex *Index;
};
TestTU OtherFile = TestTU::withCode("Outside s; auto ss = &foo;");
const char *CommonHeader = R"cpp(
class Outside {};
void foo();
)cpp";
OtherFile.HeaderCode = CommonHeader;
OtherFile.Filename = "other.cc";
// The index has a "Outside" reference and a "foo" reference.
auto OtherFileIndex = OtherFile.index();
const SymbolIndex *Index = OtherFileIndex.get();
const bool HeaderFile = true;
Case Cases[] = {
{R"cpp(// allow -- function-local
void f(int [[Lo^cal]]) {
[[Local]] = 2;
}
)cpp",
nullptr, HeaderFile, Index},
{R"cpp(// allow -- symbol is indexable and has no refs in index.
void [[On^lyInThisFile]]();
)cpp",
nullptr, HeaderFile, Index},
{R"cpp(// disallow -- symbol is indexable and has other refs in index.
void f() {
Out^side s;
}
)cpp",
"used outside main file", HeaderFile, Index},
{R"cpp(// disallow -- symbol in anonymous namespace in header is not indexable.
namespace {
class Unin^dexable {};
}
)cpp",
"not eligible for indexing", HeaderFile, Index},
{R"cpp(// allow -- symbol in anonymous namespace in non-header file is indexable.
namespace {
class [[F^oo]] {};
}
)cpp",
nullptr, !HeaderFile, Index},
{R"cpp(// disallow -- namespace symbol isn't supported
namespace n^s {}
)cpp",
"not a supported kind", HeaderFile, Index},
{
R"cpp(
#define MACRO 1
int s = MAC^RO;
)cpp",
"not a supported kind", HeaderFile, Index},
{
R"cpp(
struct X { X operator++(int); };
void f(X x) {x+^+;})cpp",
"no symbol", HeaderFile, Index},
{R"cpp(// foo is declared outside the file.
void fo^o() {}
)cpp",
"used outside main file", !HeaderFile /*cc file*/, Index},
{R"cpp(
// We should detect the symbol is used outside the file from the AST.
void fo^o() {})cpp",
"used outside main file", !HeaderFile, nullptr /*no index*/},
{R"cpp(
void foo(int);
void foo(char);
template <typename T> void f(T t) {
fo^o(t);
})cpp",
"multiple symbols", !HeaderFile, nullptr /*no index*/},
{R"cpp(// disallow rename on unrelated token.
cl^ass Foo {};
)cpp",
"no symbol", !HeaderFile, nullptr},
{R"cpp(// disallow rename on unrelated token.
temp^late<typename T>
class Foo {};
)cpp",
"no symbol", !HeaderFile, nullptr},
};
for (const auto& Case : Cases) {
Annotations T(Case.Code);
TestTU TU = TestTU::withCode(T.code());
TU.HeaderCode = CommonHeader;
TU.ExtraArgs.push_back("-fno-delayed-template-parsing");
if (Case.IsHeaderFile) {
// We open the .h file as the main file.
TU.Filename = "test.h";
// Parsing the .h file as C++ include.
TU.ExtraArgs.push_back("-xobjective-c++-header");
}
auto AST = TU.build();
llvm::StringRef NewName = "dummyNewName";
auto Results =
rename({T.point(), NewName, AST, testPath(TU.Filename), Case.Index});
bool WantRename = true;
if (T.ranges().empty())
WantRename = false;
if (!WantRename) {
assert(Case.ErrorMessage && "Error message must be set!");
EXPECT_FALSE(Results)
<< "expected rename returned an error: " << T.code();
auto ActualMessage = llvm::toString(Results.takeError());
EXPECT_THAT(ActualMessage, testing::HasSubstr(Case.ErrorMessage));
} else {
EXPECT_TRUE(bool(Results)) << "rename returned an error: "
<< llvm::toString(Results.takeError());
ASSERT_EQ(1u, Results->size());
EXPECT_EQ(applyEdits(std::move(*Results)).front().second,
expectedResult(T, NewName));
}
}
}
TEST(RenameTest, MainFileReferencesOnly) {
// filter out references not from main file.
llvm::StringRef Test =
R"cpp(
void test() {
int [[fo^o]] = 1;
// rename references not from main file are not included.
#include "foo.inc"
})cpp";
Annotations Code(Test);
auto TU = TestTU::withCode(Code.code());
TU.AdditionalFiles["foo.inc"] = R"cpp(
#define Macro(X) X
&Macro(foo);
&foo;
)cpp";
auto AST = TU.build();
llvm::StringRef NewName = "abcde";
auto RenameResult =
rename({Code.point(), NewName, AST, testPath(TU.Filename)});
ASSERT_TRUE(bool(RenameResult)) << RenameResult.takeError() << Code.point();
ASSERT_EQ(1u, RenameResult->size());
EXPECT_EQ(applyEdits(std::move(*RenameResult)).front().second,
expectedResult(Code, NewName));
}
TEST(CrossFileRenameTests, DirtyBuffer) {
Annotations FooCode("class [[Foo]] {};");
std::string FooPath = testPath("foo.cc");
Annotations FooDirtyBuffer("class [[Foo]] {};\n// this is dirty buffer");
Annotations BarCode("void [[Bar]]() {}");
std::string BarPath = testPath("bar.cc");
// Build the index, the index has "Foo" references from foo.cc and "Bar"
// references from bar.cc.
FileSymbols FSymbols;
FSymbols.update(FooPath, nullptr, buildRefSlab(FooCode, "Foo", FooPath),
nullptr, false);
FSymbols.update(BarPath, nullptr, buildRefSlab(BarCode, "Bar", BarPath),
nullptr, false);
auto Index = FSymbols.buildIndex(IndexType::Light);
Annotations MainCode("class [[Fo^o]] {};");
auto MainFilePath = testPath("main.cc");
// Dirty buffer for foo.cc.
auto GetDirtyBuffer = [&](PathRef Path) -> llvm::Optional<std::string> {
if (Path == FooPath)
return FooDirtyBuffer.code().str();
return llvm::None;
};
// Run rename on Foo, there is a dirty buffer for foo.cc, rename should
// respect the dirty buffer.
TestTU TU = TestTU::withCode(MainCode.code());
auto AST = TU.build();
llvm::StringRef NewName = "newName";
auto Results = rename({MainCode.point(), NewName, AST, MainFilePath,
Index.get(), /*CrossFile=*/true, GetDirtyBuffer});
ASSERT_TRUE(bool(Results)) << Results.takeError();
EXPECT_THAT(
applyEdits(std::move(*Results)),
UnorderedElementsAre(
Pair(Eq(FooPath), Eq(expectedResult(FooDirtyBuffer, NewName))),
Pair(Eq(MainFilePath), Eq(expectedResult(MainCode, NewName)))));
// Run rename on Bar, there is no dirty buffer for the affected file bar.cc,
// so we should read file content from VFS.
MainCode = Annotations("void [[Bar]]() { [[B^ar]](); }");
TU = TestTU::withCode(MainCode.code());
// Set a file "bar.cc" on disk.
TU.AdditionalFiles["bar.cc"] = BarCode.code();
AST = TU.build();
Results = rename({MainCode.point(), NewName, AST, MainFilePath, Index.get(),
/*CrossFile=*/true, GetDirtyBuffer});
ASSERT_TRUE(bool(Results)) << Results.takeError();
EXPECT_THAT(
applyEdits(std::move(*Results)),
UnorderedElementsAre(
Pair(Eq(BarPath), Eq(expectedResult(BarCode, NewName))),
Pair(Eq(MainFilePath), Eq(expectedResult(MainCode, NewName)))));
// Run rename on a pagination index which couldn't return all refs in one
// request, we reject rename on this case.
class PaginationIndex : public SymbolIndex {
bool refs(const RefsRequest &Req,
llvm::function_ref<void(const Ref &)> Callback) const override {
return true; // has more references
}
bool fuzzyFind(
const FuzzyFindRequest &Req,
llvm::function_ref<void(const Symbol &)> Callback) const override {
return false;
}
void
lookup(const LookupRequest &Req,
llvm::function_ref<void(const Symbol &)> Callback) const override {}
void relations(const RelationsRequest &Req,
llvm::function_ref<void(const SymbolID &, const Symbol &)>
Callback) const override {}
size_t estimateMemoryUsage() const override { return 0; }
} PIndex;
Results = rename({MainCode.point(), NewName, AST, MainFilePath, &PIndex,
/*CrossFile=*/true, GetDirtyBuffer});
EXPECT_FALSE(Results);
EXPECT_THAT(llvm::toString(Results.takeError()),
testing::HasSubstr("too many occurrences"));
}
TEST(CrossFileRenameTests, DeduplicateRefsFromIndex) {
auto MainCode = Annotations("int [[^x]] = 2;");
auto MainFilePath = testPath("main.cc");
auto BarCode = Annotations("int [[x]];");
auto BarPath = testPath("bar.cc");
auto TU = TestTU::withCode(MainCode.code());
// Set a file "bar.cc" on disk.
TU.AdditionalFiles["bar.cc"] = BarCode.code();
auto AST = TU.build();
std::string BarPathURI = URI::create(BarPath).toString();
Ref XRefInBarCC = refWithRange(BarCode.range(), BarPathURI);
// The index will return duplicated refs, our code should be robost to handle
// it.
class DuplicatedXRefIndex : public SymbolIndex {
public:
DuplicatedXRefIndex(const Ref &ReturnedRef) : ReturnedRef(ReturnedRef) {}
bool refs(const RefsRequest &Req,
llvm::function_ref<void(const Ref &)> Callback) const override {
// Return two duplicated refs.
Callback(ReturnedRef);
Callback(ReturnedRef);
return false;
}
bool fuzzyFind(const FuzzyFindRequest &,
llvm::function_ref<void(const Symbol &)>) const override {
return false;
}
void lookup(const LookupRequest &,
llvm::function_ref<void(const Symbol &)>) const override {}
void relations(const RelationsRequest &,
llvm::function_ref<void(const SymbolID &, const Symbol &)>)
const override {}
size_t estimateMemoryUsage() const override { return 0; }
Ref ReturnedRef;
} DIndex(XRefInBarCC);
llvm::StringRef NewName = "newName";
auto Results = rename({MainCode.point(), NewName, AST, MainFilePath, &DIndex,
/*CrossFile=*/true});
ASSERT_TRUE(bool(Results)) << Results.takeError();
EXPECT_THAT(
applyEdits(std::move(*Results)),
UnorderedElementsAre(
Pair(Eq(BarPath), Eq(expectedResult(BarCode, NewName))),
Pair(Eq(MainFilePath), Eq(expectedResult(MainCode, NewName)))));
}
TEST(CrossFileRenameTests, WithUpToDateIndex) {
MockCompilationDatabase CDB;
CDB.ExtraClangFlags = {"-xc++"};
class IgnoreDiagnostics : public DiagnosticsConsumer {
void onDiagnosticsReady(PathRef File,
std::vector<Diag> Diagnostics) override {}
} DiagConsumer;
// rename is runnning on the "^" point in FooH, and "[[]]" ranges are the
// expected rename occurrences.
struct Case {
llvm::StringRef FooH;
llvm::StringRef FooCC;
} Cases[] = {
{
// classes.
R"cpp(
class [[Fo^o]] {
[[Foo]]();
~[[Foo]]();
};
)cpp",
R"cpp(
#include "foo.h"
[[Foo]]::[[Foo]]() {}
[[Foo]]::~[[Foo]]() {}
void func() {
[[Foo]] foo;
}
)cpp",
},
{
// class methods.
R"cpp(
class Foo {
void [[f^oo]]();
};
)cpp",
R"cpp(
#include "foo.h"
void Foo::[[foo]]() {}
void func(Foo* p) {
p->[[foo]]();
}
)cpp",
},
{
// Constructor.
R"cpp(
class [[Foo]] {
[[^Foo]]();
~[[Foo]]();
};
)cpp",
R"cpp(
#include "foo.h"
[[Foo]]::[[Foo]]() {}
[[Foo]]::~[[Foo]]() {}
void func() {
[[Foo]] foo;
}
)cpp",
},
{
// Destructor (selecting before the identifier).
R"cpp(
class [[Foo]] {
[[Foo]]();
~[[Foo^]]();
};
)cpp",
R"cpp(
#include "foo.h"
[[Foo]]::[[Foo]]() {}
[[Foo]]::~[[Foo]]() {}
void func() {
[[Foo]] foo;
}
)cpp",
},
{
// functions.
R"cpp(
void [[f^oo]]();
)cpp",
R"cpp(
#include "foo.h"
void [[foo]]() {}
void func() {
[[foo]]();
}
)cpp",
},
{
// typedefs.
R"cpp(
typedef int [[IN^T]];
[[INT]] foo();
)cpp",
R"cpp(
#include "foo.h"
[[INT]] foo() {}
)cpp",
},
{
// usings.
R"cpp(
using [[I^NT]] = int;
[[INT]] foo();
)cpp",
R"cpp(
#include "foo.h"
[[INT]] foo() {}
)cpp",
},
{
// variables.
R"cpp(
static const int [[VA^R]] = 123;
)cpp",
R"cpp(
#include "foo.h"
int s = [[VAR]];
)cpp",
},
{
// scope enums.
R"cpp(
enum class [[K^ind]] { ABC };
)cpp",
R"cpp(
#include "foo.h"
[[Kind]] ff() {
return [[Kind]]::ABC;
}
)cpp",
},
{
// enum constants.
R"cpp(
enum class Kind { [[A^BC]] };
)cpp",
R"cpp(
#include "foo.h"
Kind ff() {
return Kind::[[ABC]];
}
)cpp",
},
};
for (const auto& T : Cases) {
Annotations FooH(T.FooH);
Annotations FooCC(T.FooCC);
std::string FooHPath = testPath("foo.h");
std::string FooCCPath = testPath("foo.cc");
MockFSProvider FS;
FS.Files[FooHPath] = FooH.code();
FS.Files[FooCCPath] = FooCC.code();
auto ServerOpts = ClangdServer::optsForTest();
ServerOpts.CrossFileRename = true;
ServerOpts.BuildDynamicSymbolIndex = true;
ClangdServer Server(CDB, FS, DiagConsumer, ServerOpts);
// Add all files to clangd server to make sure the dynamic index has been
// built.
runAddDocument(Server, FooHPath, FooH.code());
runAddDocument(Server, FooCCPath, FooCC.code());
llvm::StringRef NewName = "NewName";
auto FileEditsList =
llvm::cantFail(runRename(Server, FooHPath, FooH.point(), NewName));
EXPECT_THAT(applyEdits(std::move(FileEditsList)),
UnorderedElementsAre(
Pair(Eq(FooHPath), Eq(expectedResult(T.FooH, NewName))),
Pair(Eq(FooCCPath), Eq(expectedResult(T.FooCC, NewName)))));
}
}
TEST(CrossFileRenameTests, CrossFileOnLocalSymbol) {
// cross-file rename should work for function-local symbols, even there is no
// index provided.
Annotations Code("void f(int [[abc]]) { [[a^bc]] = 3; }");
auto TU = TestTU::withCode(Code.code());
auto Path = testPath(TU.Filename);
auto AST = TU.build();
llvm::StringRef NewName = "newName";
auto Results = rename({Code.point(), NewName, AST, Path});
ASSERT_TRUE(bool(Results)) << Results.takeError();
EXPECT_THAT(
applyEdits(std::move(*Results)),
UnorderedElementsAre(Pair(Eq(Path), Eq(expectedResult(Code, NewName)))));
}
TEST(CrossFileRenameTests, BuildRenameEdits) {
Annotations Code("[[😂]]");
auto LSPRange = Code.range();
llvm::StringRef FilePath = "/test/TestTU.cpp";
llvm::StringRef NewName = "abc";
auto Edit = buildRenameEdit(FilePath, Code.code(), {LSPRange}, NewName);
ASSERT_TRUE(bool(Edit)) << Edit.takeError();
ASSERT_EQ(1UL, Edit->Replacements.size());
EXPECT_EQ(FilePath, Edit->Replacements.begin()->getFilePath());
EXPECT_EQ(4UL, Edit->Replacements.begin()->getLength());
// Test invalid range.
LSPRange.end = {10, 0}; // out of range
Edit = buildRenameEdit(FilePath, Code.code(), {LSPRange}, NewName);
EXPECT_FALSE(Edit);
EXPECT_THAT(llvm::toString(Edit.takeError()),
testing::HasSubstr("fail to convert"));
// Normal ascii characters.
Annotations T(R"cpp(
[[range]]
[[range]]
[[range]]
)cpp");
Edit = buildRenameEdit(FilePath, T.code(), T.ranges(), NewName);
ASSERT_TRUE(bool(Edit)) << Edit.takeError();
EXPECT_EQ(applyEdits(FileEdits{{T.code(), std::move(*Edit)}}).front().second,
expectedResult(T, NewName));
}
TEST(CrossFileRenameTests, adjustRenameRanges) {
// Ranges in IndexedCode indicate the indexed occurrences;
// ranges in DraftCode indicate the expected mapped result, empty indicates
// we expect no matched result found.
struct {
llvm::StringRef IndexedCode;
llvm::StringRef DraftCode;
} Tests[] = {
{
// both line and column are changed, not a near miss.
R"cpp(
int [[x]] = 0;
)cpp",
R"cpp(
// insert a line.
double x = 0;
)cpp",
},
{
// subset.
R"cpp(
int [[x]] = 0;
)cpp",
R"cpp(
int [[x]] = 0;
{int x = 0; }
)cpp",
},
{
// shift columns.
R"cpp(int [[x]] = 0; void foo(int x);)cpp",
R"cpp(double [[x]] = 0; void foo(double x);)cpp",
},
{
// shift lines.
R"cpp(
int [[x]] = 0;
void foo(int x);
)cpp",
R"cpp(
// insert a line.
int [[x]] = 0;
void foo(int x);
)cpp",
},
};
LangOptions LangOpts;
LangOpts.CPlusPlus = true;
for (const auto &T : Tests) {
Annotations Draft(T.DraftCode);
auto ActualRanges = adjustRenameRanges(
Draft.code(), "x", Annotations(T.IndexedCode).ranges(), LangOpts);
if (!ActualRanges)
EXPECT_THAT(Draft.ranges(), testing::IsEmpty());
else
EXPECT_THAT(Draft.ranges(),
testing::UnorderedElementsAreArray(*ActualRanges))
<< T.DraftCode;
}
}
TEST(RangePatchingHeuristic, GetMappedRanges) {
// ^ in LexedCode marks the ranges we expect to be mapped; no ^ indicates
// there are no mapped ranges.
struct {
llvm::StringRef IndexedCode;
llvm::StringRef LexedCode;
} Tests[] = {
{
// no lexed ranges.
"[[]]",
"",
},
{
// both line and column are changed, not a near miss.
R"([[]])",
R"(
[[]]
)",
},
{
// subset.
"[[]]",
"^[[]] [[]]"
},
{
// shift columns.
"[[]] [[]]",
" ^[[]] ^[[]] [[]]"
},
{
R"(
[[]]
[[]] [[]]
)",
R"(
// insert a line
^[[]]
^[[]] ^[[]]
)",
},
{
R"(
[[]]
[[]] [[]]
)",
R"(
// insert a line
^[[]]
^[[]] ^[[]] // column is shifted.
)",
},
{
R"(
[[]]
[[]] [[]]
)",
R"(
// insert a line
[[]]
[[]] [[]] // not mapped (both line and column are changed).
)",
},
{
R"(
[[]]
[[]]
[[]]
[[]]
}
)",
R"(
// insert a new line
^[[]]
^[[]]
[[]] // additional range
^[[]]
^[[]]
[[]] // additional range
)",
},
{
// non-distinct result (two best results), not a near miss
R"(
[[]]
[[]]
[[]]
)",
R"(
[[]]
[[]]
[[]]
[[]]
)",
}
};
for (const auto &T : Tests) {
auto Lexed = Annotations(T.LexedCode);
auto LexedRanges = Lexed.ranges();
std::vector<Range> ExpectedMatches;
for (auto P : Lexed.points()) {
auto Match = llvm::find_if(LexedRanges, [&P](const Range& R) {
return R.start == P;
});
ASSERT_NE(Match, LexedRanges.end());
ExpectedMatches.push_back(*Match);
}
auto Mapped =
getMappedRanges(Annotations(T.IndexedCode).ranges(), LexedRanges);
if (!Mapped)
EXPECT_THAT(ExpectedMatches, IsEmpty());
else
EXPECT_THAT(ExpectedMatches, UnorderedElementsAreArray(*Mapped))
<< T.IndexedCode;
}
}
TEST(CrossFileRenameTests, adjustmentCost) {
struct {
llvm::StringRef RangeCode;
size_t ExpectedCost;
} Tests[] = {
{
R"(
$idx[[]]$lex[[]] // diff: 0
)",
0,
},
{
R"(
$idx[[]]
$lex[[]] // line diff: +1
$idx[[]]
$lex[[]] // line diff: +1
$idx[[]]
$lex[[]] // line diff: +1
$idx[[]]
$lex[[]] // line diff: +2
)",
1 + 1
},
{
R"(
$idx[[]]
$lex[[]] // line diff: +1
$idx[[]]
$lex[[]] // line diff: +2
$idx[[]]
$lex[[]] // line diff: +3
)",
1 + 1 + 1
},
{
R"(
$idx[[]]
$lex[[]] // line diff: +3
$idx[[]]
$lex[[]] // line diff: +2
$idx[[]]
$lex[[]] // line diff: +1
)",
3 + 1 + 1
},
{
R"(
$idx[[]]
$lex[[]] // line diff: +1
$lex[[]] // line diff: -2
$idx[[]]
$idx[[]]
$lex[[]] // line diff: +3
)",
1 + 3 + 5
},
{
R"(
$idx[[]] $lex[[]] // column diff: +1
$idx[[]]$lex[[]] // diff: 0
)",
1
},
{
R"(
$idx[[]]
$lex[[]] // diff: +1
$idx[[]] $lex[[]] // column diff: +1
$idx[[]]$lex[[]] // diff: 0
)",
1 + 1 + 1
},
{
R"(
$idx[[]] $lex[[]] // column diff: +1
)",
1
},
{
R"(
// column diffs: +1, +2, +3
$idx[[]] $lex[[]] $idx[[]] $lex[[]] $idx[[]] $lex[[]]
)",
1 + 1 + 1,
},
};
for (const auto &T : Tests) {
Annotations C(T.RangeCode);
std::vector<size_t> MappedIndex;
for (size_t I = 0; I < C.ranges("lex").size(); ++I)
MappedIndex.push_back(I);
EXPECT_EQ(renameRangeAdjustmentCost(C.ranges("idx"), C.ranges("lex"),
MappedIndex),
T.ExpectedCost) << T.RangeCode;
}
}
} // namespace
} // namespace clangd
} // namespace clang