Fixed javadoc warnings on openstack applications

- Changed package name of 'app' submodule to avoid duplicate package name warning
- Added app.xml and features.xml to make the application activate successfully
- Fixed missing parameter javadoc warnings

Change-Id: Iaefdd08d15291ccea8224b13b815246eb13b84ce

@@ -15,6 +15,6 @@
  */
  */
 
 
 /**
 /**
- * Application for OpenstackRouting.
+ * Application that handles OpenStack Neutron REST calls.
  */
  */
 package org.onosproject.openstackinterface;
 package org.onosproject.openstackinterface;
\ No newline at end of file

+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+  ~ Copyright 2016 Open Networking Laboratory
+  ~
+  ~ Licensed under the Apache License, Version 2.0 (the "License");
+  ~ you may not use this file except in compliance with the License.
+  ~ You may obtain a copy of the License at
+  ~
+  ~     http://www.apache.org/licenses/LICENSE-2.0
+  ~
+  ~ Unless required by applicable law or agreed to in writing, software
+  ~ distributed under the License is distributed on an "AS IS" BASIS,
+  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  ~ See the License for the specific language governing permissions and
+  ~ limitations under the License.
+  -->
+<app name="org.onosproject.openstackinterface" origin="ON.Lab" version="${project.version}"
+     category="default" url="http://onosproject.org"
+     featuresRepo="mvn:${project.groupId}/${project.artifactId}/${project.version}/xml/features"
+     features="${project.artifactId}">
+    <description>${project.description}</description>
+    <artifact>mvn:${project.groupId}/onos-app-openstackinterface-api/${project.version}</artifact>
+    <artifact>mvn:${project.groupId}/onos-app-openstackinterface-app/${project.version}</artifact>
+</app>

+<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
+<!--
+  ~ Copyright 2016 Open Networking Laboratory
+  ~
+  ~ Licensed under the Apache License, Version 2.0 (the "License");
+  ~ you may not use this file except in compliance with the License.
+  ~ You may obtain a copy of the License at
+  ~
+  ~     http://www.apache.org/licenses/LICENSE-2.0
+  ~
+  ~ Unless required by applicable law or agreed to in writing, software
+  ~ distributed under the License is distributed on an "AS IS" BASIS,
+  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  ~ See the License for the specific language governing permissions and
+  ~ limitations under the License.
+  -->
+<features xmlns="http://karaf.apache.org/xmlns/features/v1.2.0" name="${project.artifactId}-${project.version}">
+    <feature name="${project.artifactId}" version="${project.version}"
+             description="${project.description}">
+        <feature>onos-api</feature>
+        <bundle>mvn:${project.groupId}/onos-app-openstackinterface-api/${project.version}</bundle>
+        <bundle>mvn:${project.groupId}/onos-app-openstackinterface-app/${project.version}</bundle>
+    </feature>
+</features>

@@ -13,7 +13,7 @@
  * See the License for the specific language governing permissions and
  * See the License for the specific language governing permissions and
  * limitations under the License.
  * limitations under the License.
  */
  */
-package org.onosproject.openstackinterface;
+package org.onosproject.openstackinterface.impl;
 
 
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.fasterxml.jackson.databind.node.ArrayNode;
 import com.fasterxml.jackson.databind.node.ArrayNode;
@@ -35,6 +35,13 @@ import org.onosproject.net.config.ConfigFactory;
 import org.onosproject.net.config.NetworkConfigEvent;
 import org.onosproject.net.config.NetworkConfigEvent;
 import org.onosproject.net.config.NetworkConfigListener;
 import org.onosproject.net.config.NetworkConfigListener;
 import org.onosproject.net.config.NetworkConfigRegistry;
 import org.onosproject.net.config.NetworkConfigRegistry;
+import org.onosproject.openstackinterface.OpenstackInterfaceService;
+import org.onosproject.openstackinterface.OpenstackNetwork;
+import org.onosproject.openstackinterface.OpenstackNetworkingConfig;
+import org.onosproject.openstackinterface.OpenstackPort;
+import org.onosproject.openstackinterface.OpenstackRouter;
+import org.onosproject.openstackinterface.OpenstackSecurityGroup;
+import org.onosproject.openstackinterface.OpenstackSubnet;
 import org.onosproject.openstackinterface.web.OpenstackNetworkCodec;
 import org.onosproject.openstackinterface.web.OpenstackNetworkCodec;
 import org.onosproject.openstackinterface.web.OpenstackPortCodec;
 import org.onosproject.openstackinterface.web.OpenstackPortCodec;
 import org.onosproject.openstackinterface.web.OpenstackRouterCodec;
 import org.onosproject.openstackinterface.web.OpenstackRouterCodec;

@@ -15,6 +15,6 @@
  */
  */
 
 
 /**
 /**
- * Application for OpenstackRouting.
+ * Implementation classes for OpenStack interface that handles Neutron REST calls.
  */
  */
-package org.onosproject.openstackinterface;
\ No newline at end of file
+package org.onosproject.openstackinterface.impl;
\ No newline at end of file

@@ -120,7 +120,7 @@ public class OpenstackRoutingRulePopulator {
      *  @param inboundPacket Packet-in event packet
      *  @param inboundPacket Packet-in event packet
      * @param openstackPort Target VM information
      * @param openstackPort Target VM information
      * @param portNum Pnat port number
      * @param portNum Pnat port number
-     * @param externalIp
+     * @param externalIp external ip address
      * @param externalInterfaceMacAddress Gateway external interface macaddress
      * @param externalInterfaceMacAddress Gateway external interface macaddress
      * @param externalRouterMacAddress Outer(physical) router`s macaddress
      * @param externalRouterMacAddress Outer(physical) router`s macaddress
      */
      */

@@ -69,6 +69,7 @@ public class OpenstackArpHandler {
      * OpenStack if it's not. This ARP proxy does not support overlapping IP.
      * OpenStack if it's not. This ARP proxy does not support overlapping IP.
      *
      *
      * @param pkt ARP request packet
      * @param pkt ARP request packet
+     * @param openstackPortInfoCollection collection of port information
      */
      */
     public void processPacketIn(InboundPacket pkt, Collection<OpenstackPortInfo> openstackPortInfoCollection) {
     public void processPacketIn(InboundPacket pkt, Collection<OpenstackPortInfo> openstackPortInfoCollection) {
         Ethernet ethRequest = pkt.parsed();
         Ethernet ethRequest = pkt.parsed();

@@ -75,6 +75,7 @@ public class OpenstackSwitchingRulePopulator {
      * @param appId application id
      * @param appId application id
      * @param flowObjectiveService FlowObjectiveService reference
      * @param flowObjectiveService FlowObjectiveService reference
      * @param deviceService DeviceService reference
      * @param deviceService DeviceService reference
+     * @param openstackService openstack interface service
      * @param driverService DriverService reference
      * @param driverService DriverService reference
      */
      */
     public OpenstackSwitchingRulePopulator(ApplicationId appId,
     public OpenstackSwitchingRulePopulator(ApplicationId appId,