Jonathan Hart
Committed by Gerrit Code Review

Pretty print the output of the netcfg command

Change-Id: Id76124517ff6ad1f8f607654cded3360b5981049
...@@ -15,6 +15,7 @@ ...@@ -15,6 +15,7 @@
15 */ 15 */
16 package org.onosproject.cli.cfg; 16 package org.onosproject.cli.cfg;
17 17
18 +import com.fasterxml.jackson.core.JsonProcessingException;
18 import com.fasterxml.jackson.databind.JsonNode; 19 import com.fasterxml.jackson.databind.JsonNode;
19 import com.fasterxml.jackson.databind.ObjectMapper; 20 import com.fasterxml.jackson.databind.ObjectMapper;
20 import com.fasterxml.jackson.databind.node.ObjectNode; 21 import com.fasterxml.jackson.databind.node.ObjectNode;
...@@ -52,7 +53,7 @@ public class NetworkConfigCommand extends AbstractShellCommand { ...@@ -52,7 +53,7 @@ public class NetworkConfigCommand extends AbstractShellCommand {
52 @Override 53 @Override
53 protected void execute() { 54 protected void execute() {
54 service = get(NetworkConfigService.class); 55 service = get(NetworkConfigService.class);
55 - JsonNode root = new ObjectMapper().createObjectNode(); 56 + JsonNode root = mapper.createObjectNode();
56 if (isNullOrEmpty(subjectKey)) { 57 if (isNullOrEmpty(subjectKey)) {
57 addAll((ObjectNode) root); 58 addAll((ObjectNode) root);
58 } else { 59 } else {
...@@ -68,14 +69,19 @@ public class NetworkConfigCommand extends AbstractShellCommand { ...@@ -68,14 +69,19 @@ public class NetworkConfigCommand extends AbstractShellCommand {
68 } 69 }
69 } 70 }
70 } 71 }
71 - print("%s", root.toString()); 72 +
73 + try {
74 + print("%s", mapper.writerWithDefaultPrettyPrinter().writeValueAsString(root));
75 + } catch (JsonProcessingException e) {
76 + throw new RuntimeException("Error writing JSON to string", e);
77 + }
72 } 78 }
73 79
74 @SuppressWarnings("unchecked") 80 @SuppressWarnings("unchecked")
75 private void addAll(ObjectNode root) { 81 private void addAll(ObjectNode root) {
76 service.getSubjectClasses() 82 service.getSubjectClasses()
77 .forEach(sc -> { 83 .forEach(sc -> {
78 - SubjectFactory sf = service.getSubjectFactory((Class) sc); 84 + SubjectFactory sf = service.getSubjectFactory(sc);
79 addSubjectClass(newObject(root, sf.subjectKey()), sf); 85 addSubjectClass(newObject(root, sf.subjectKey()), sf);
80 }); 86 });
81 } 87 }
......