Add TODO memos
Change-Id: I087b3c6ce3b9ad1fc5cab292a58af685f8b76609
Showing
4 changed files
with
7 additions
and
0 deletions
... | @@ -3,6 +3,8 @@ package org.onlab.onos.store.cluster.messaging; | ... | @@ -3,6 +3,8 @@ package org.onlab.onos.store.cluster.messaging; |
3 | import org.onlab.onos.cluster.ControllerNode; | 3 | import org.onlab.onos.cluster.ControllerNode; |
4 | import org.onlab.onos.store.cluster.impl.ClusterNodesDelegate; | 4 | import org.onlab.onos.store.cluster.impl.ClusterNodesDelegate; |
5 | 5 | ||
6 | +// TODO: This service interface can be removed, once we properly start | ||
7 | +// using ClusterService | ||
6 | /** | 8 | /** |
7 | * Service for administering communications manager. | 9 | * Service for administering communications manager. |
8 | */ | 10 | */ | ... | ... |
... | @@ -2,6 +2,8 @@ package org.onlab.onos.store.cluster.messaging; | ... | @@ -2,6 +2,8 @@ package org.onlab.onos.store.cluster.messaging; |
2 | 2 | ||
3 | import org.onlab.onos.cluster.NodeId; | 3 | import org.onlab.onos.cluster.NodeId; |
4 | 4 | ||
5 | +// TODO: ClusterMessage should be aware about how to serialize the payload | ||
6 | +// TODO: Should payload type be made generic? | ||
5 | /** | 7 | /** |
6 | * Base message for cluster-wide communications. | 8 | * Base message for cluster-wide communications. |
7 | */ | 9 | */ | ... | ... |
... | @@ -39,6 +39,7 @@ public class ClusterCommunicationManager | ... | @@ -39,6 +39,7 @@ public class ClusterCommunicationManager |
39 | 39 | ||
40 | private ControllerNode localNode; | 40 | private ControllerNode localNode; |
41 | private ClusterNodesDelegate nodesDelegate; | 41 | private ClusterNodesDelegate nodesDelegate; |
42 | + // FIXME: `members` should go away and should be using ClusterService | ||
42 | private Map<NodeId, ControllerNode> members = new HashMap<>(); | 43 | private Map<NodeId, ControllerNode> members = new HashMap<>(); |
43 | private final Timer timer = new Timer("onos-controller-heatbeats"); | 44 | private final Timer timer = new Timer("onos-controller-heatbeats"); |
44 | public static final long HEART_BEAT_INTERVAL_MILLIS = 1000L; | 45 | public static final long HEART_BEAT_INTERVAL_MILLIS = 1000L; | ... | ... |
... | @@ -3,6 +3,8 @@ package org.onlab.onos.store.cluster.messaging.impl; | ... | @@ -3,6 +3,8 @@ package org.onlab.onos.store.cluster.messaging.impl; |
3 | import org.onlab.onos.store.cluster.messaging.MessageSubject; | 3 | import org.onlab.onos.store.cluster.messaging.MessageSubject; |
4 | 4 | ||
5 | public final class ClusterMessageSubjects { | 5 | public final class ClusterMessageSubjects { |
6 | + // avoid instantiation | ||
6 | private ClusterMessageSubjects() {} | 7 | private ClusterMessageSubjects() {} |
8 | + | ||
7 | public static final MessageSubject CLUSTER_MEMBERSHIP_EVENT = new MessageSubject("CLUSTER_MEMBERSHIP_EVENT"); | 9 | public static final MessageSubject CLUSTER_MEMBERSHIP_EVENT = new MessageSubject("CLUSTER_MEMBERSHIP_EVENT"); |
8 | } | 10 | } | ... | ... |
-
Please register or login to post a comment