Committed by
Gerrit Code Review
[ONOS-2574]OVSDB Client Merge.We need to properly fix
DefaultOvsdbClient, which was broken by API changes in AbstractOvsdbTableService. There are two FIXMEs that identify the problems. Change-Id: If859dac398be627630deefcb8ecf57d0c6ccb734
Showing
1 changed file
with
4 additions
and
15 deletions
... | @@ -55,7 +55,6 @@ import org.onosproject.ovsdb.rfc.schema.TableSchema; | ... | @@ -55,7 +55,6 @@ import org.onosproject.ovsdb.rfc.schema.TableSchema; |
55 | import org.onosproject.ovsdb.rfc.table.Bridge; | 55 | import org.onosproject.ovsdb.rfc.table.Bridge; |
56 | import org.onosproject.ovsdb.rfc.table.Controller; | 56 | import org.onosproject.ovsdb.rfc.table.Controller; |
57 | import org.onosproject.ovsdb.rfc.table.Interface; | 57 | import org.onosproject.ovsdb.rfc.table.Interface; |
58 | -import org.onosproject.ovsdb.rfc.table.OpenVSwitch; | ||
59 | import org.onosproject.ovsdb.rfc.table.OvsdbTable; | 58 | import org.onosproject.ovsdb.rfc.table.OvsdbTable; |
60 | import org.onosproject.ovsdb.rfc.table.Port; | 59 | import org.onosproject.ovsdb.rfc.table.Port; |
61 | import org.onosproject.ovsdb.rfc.table.TableGenerator; | 60 | import org.onosproject.ovsdb.rfc.table.TableGenerator; |
... | @@ -359,7 +358,6 @@ public class DefaultOvsdbClient | ... | @@ -359,7 +358,6 @@ public class DefaultOvsdbClient |
359 | 358 | ||
360 | @Override | 359 | @Override |
361 | public String getOvsUuid(String dbName) { | 360 | public String getOvsUuid(String dbName) { |
362 | - DatabaseSchema dbSchema = schema.get(OvsdbConstant.DATABASENAME); | ||
363 | OvsdbRowStore rowStore = getRowStore(OvsdbConstant.DATABASENAME, | 361 | OvsdbRowStore rowStore = getRowStore(OvsdbConstant.DATABASENAME, |
364 | OvsdbConstant.DATABASENAME); | 362 | OvsdbConstant.DATABASENAME); |
365 | if (rowStore == null) { | 363 | if (rowStore == null) { |
... | @@ -367,23 +365,15 @@ public class DefaultOvsdbClient | ... | @@ -367,23 +365,15 @@ public class DefaultOvsdbClient |
367 | return null; | 365 | return null; |
368 | } | 366 | } |
369 | ConcurrentMap<String, Row> ovsTableRows = rowStore.getRowStore(); | 367 | ConcurrentMap<String, Row> ovsTableRows = rowStore.getRowStore(); |
370 | - | ||
371 | if (ovsTableRows != null) { | 368 | if (ovsTableRows != null) { |
372 | - | ||
373 | for (String uuid : ovsTableRows.keySet()) { | 369 | for (String uuid : ovsTableRows.keySet()) { |
374 | - | 370 | + Row row = ovsTableRows.get(uuid); |
375 | - OpenVSwitch ovs = (OpenVSwitch) TableGenerator | 371 | + String tableName = row.tableName(); |
376 | - .getTable(dbSchema, ovsTableRows.get(uuid), | 372 | + if (tableName.equals(dbName)) { |
377 | - OvsdbTable.OPENVSWITCH); | ||
378 | - | ||
379 | - // FIXME This is a quick hack to fix the build. Functionality/logic not verified. (BOC) | ||
380 | - if (ovs.dbSchema().name().equals(dbName)) { | ||
381 | return uuid; | 373 | return uuid; |
382 | } | 374 | } |
383 | } | 375 | } |
384 | - | ||
385 | } | 376 | } |
386 | - | ||
387 | return null; | 377 | return null; |
388 | } | 378 | } |
389 | 379 | ||
... | @@ -806,8 +796,7 @@ public class DefaultOvsdbClient | ... | @@ -806,8 +796,7 @@ public class DefaultOvsdbClient |
806 | .getTableSchema(OvsdbConstant.PORT); | 796 | .getTableSchema(OvsdbConstant.PORT); |
807 | ColumnSchema portColumnSchema = portTableSchema.getColumnSchema("name"); | 797 | ColumnSchema portColumnSchema = portTableSchema.getColumnSchema("name"); |
808 | 798 | ||
809 | - // FIXME This is a quick hack to fix the build. Functionality not verified. (BOC) | 799 | + String portName = (String) portRow.getColumn(portColumnSchema.name()).data(); |
810 | - String portName = (String) portRow.getColumn(portColumnSchema.toString()).data(); | ||
811 | 800 | ||
812 | Interface inf = (Interface) TableGenerator | 801 | Interface inf = (Interface) TableGenerator |
813 | .createTable(dbSchema, OvsdbTable.INTERFACE); | 802 | .createTable(dbSchema, OvsdbTable.INTERFACE); | ... | ... |
-
Please register or login to post a comment