[Falcon] fixes for Sonar Critical bugs

Change-Id: I0a63578727693a2517f3002bd4f4c391b6f44aea

@@ -425,6 +425,7 @@ public class CordFabricManager implements FabricService {
                         deviceService.isAvailable(event.subject().id())) {
                         deviceService.isAvailable(event.subject().id())) {
                     setupDefaultFlows();
                     setupDefaultFlows();
                 }
                 }
+                break;
             default:
             default:
                 break;
                 break;
             }
             }

@@ -78,7 +78,7 @@ public class OpenstackRestHandler {
             OpenstackNetworkCodec networkCodec = new OpenstackNetworkCodec();
             OpenstackNetworkCodec networkCodec = new OpenstackNetworkCodec();
             networkList.forEach(n -> openstackNetworks.add(networkCodec.decode((ObjectNode) n, null)));
             networkList.forEach(n -> openstackNetworks.add(networkCodec.decode((ObjectNode) n, null)));
         } catch (IOException e) {
         } catch (IOException e) {
-            e.printStackTrace();
+            log.warn("getNetworks()", e);
         }
         }
 
 
         log.debug("networks response:" + response);
         log.debug("networks response:" + response);
@@ -106,7 +106,7 @@ public class OpenstackRestHandler {
             OpenstackPortCodec portCodec = new OpenstackPortCodec();
             OpenstackPortCodec portCodec = new OpenstackPortCodec();
             portList.forEach(p -> openstackPorts.add(portCodec.decode((ObjectNode) p, null)));
             portList.forEach(p -> openstackPorts.add(portCodec.decode((ObjectNode) p, null)));
         } catch (IOException e) {
         } catch (IOException e) {
-            e.printStackTrace();
+            log.warn("getPorts()", e);
         }
         }
 
 
         log.debug("port response:" + response);
         log.debug("port response:" + response);
@@ -134,7 +134,7 @@ public class OpenstackRestHandler {
             OpenstackSubnetCodec subnetCodec = new OpenstackSubnetCodec();
             OpenstackSubnetCodec subnetCodec = new OpenstackSubnetCodec();
             subnetList.forEach(s -> subnets.add(subnetCodec.decode((ObjectNode) s, null)));
             subnetList.forEach(s -> subnets.add(subnetCodec.decode((ObjectNode) s, null)));
         } catch (IOException e) {
         } catch (IOException e) {
-            e.printStackTrace();
+            log.warn("getSubnets()", e);
         }
         }
 
 
         log.debug("subnets response:" + response);
         log.debug("subnets response:" + response);
@@ -163,7 +163,7 @@ public class OpenstackRestHandler {
                 ObjectNode node = (ObjectNode) mapper.readTree(response);
                 ObjectNode node = (ObjectNode) mapper.readTree(response);
                 tokenId = node.path("access").path("token").path("id").asText();
                 tokenId = node.path("access").path("token").path("id").asText();
             } catch (IOException e) {
             } catch (IOException e) {
-                e.printStackTrace();
+                log.warn("getToken()", e);
             }
             }
             log.debug("token response:" + response);
             log.debug("token response:" + response);
         }
         }

@@ -184,7 +184,7 @@ public class IntentSynchronizer implements IntentSynchronizationService {
                 intentsToAdd.add(localIntent);
                 intentsToAdd.add(localIntent);
             } else {
             } else {
                 IntentState state = intentService.getIntentState(serviceIntent.key());
                 IntentState state = intentService.getIntentState(serviceIntent.key());
-                if (!IntentUtils.equals(serviceIntent, localIntent) || state == null ||
+                if (!IntentUtils.intentsAreEqual(serviceIntent, localIntent) || state == null ||
                         state == IntentState.WITHDRAW_REQ ||
                         state == IntentState.WITHDRAW_REQ ||
                         state == IntentState.WITHDRAWING ||
                         state == IntentState.WITHDRAWING ||
                         state == IntentState.WITHDRAWN) {
                         state == IntentState.WITHDRAWN) {

@@ -135,7 +135,7 @@ public class PeerConnectivityManager {
 
 
             buildSpeakerIntents(bgpSpeaker).forEach(i -> {
             buildSpeakerIntents(bgpSpeaker).forEach(i -> {
                 PointToPointIntent intent = existingIntents.remove(i.key());
                 PointToPointIntent intent = existingIntents.remove(i.key());
-                if (intent == null || !IntentUtils.equals(i, intent)) {
+                if (intent == null || !IntentUtils.intentsAreEqual(i, intent)) {
                     peerIntents.put(i.key(), i);
                     peerIntents.put(i.key(), i);
                     intentSynchronizer.submit(i);
                     intentSynchronizer.submit(i);
                 }
                 }

@@ -216,7 +216,7 @@ public class IntentSyncTest extends AbstractIntentTest {
         // Compose a intent, which is equal to intent5 but the id is different.
         // Compose a intent, which is equal to intent5 but the id is different.
         MultiPointToSinglePointIntent intent5New =
         MultiPointToSinglePointIntent intent5New =
                 staticIntentBuilder(intent5, routeEntry5, "00:00:00:00:00:01");
                 staticIntentBuilder(intent5, routeEntry5, "00:00:00:00:00:01");
-        assertThat(IntentUtils.equals(intent5, intent5New), is(true));
+        assertThat(IntentUtils.intentsAreEqual(intent5, intent5New), is(true));
         assertFalse(intent5.equals(intent5New));
         assertFalse(intent5.equals(intent5New));
 
 
         MultiPointToSinglePointIntent intent6 = intentBuilder(
         MultiPointToSinglePointIntent intent6 = intentBuilder(

@@ -84,7 +84,7 @@ public final class TestIntentServiceHelper {
             Intent providedIntent = (Intent) object;
             Intent providedIntent = (Intent) object;
             providedString = providedIntent.toString();
             providedString = providedIntent.toString();
 
 
-            return IntentUtils.equals(intent, providedIntent);
+            return IntentUtils.intentsAreEqual(intent, providedIntent);
         }
         }
     }
     }
 
 

@@ -310,7 +310,7 @@ public class MessagingPerfApp {
                 messageSendingExecutor.submit(this::requestReply);
                 messageSendingExecutor.submit(this::requestReply);
             });
             });
         } catch (Exception e) {
         } catch (Exception e) {
-            e.printStackTrace();
+            log.info("requestReply()", e);
         }
         }
     }
     }
 
 
@@ -323,7 +323,7 @@ public class MessagingPerfApp {
                     encoder,
                     encoder,
                     randomPeer());
                     randomPeer());
         } catch (Exception e) {
         } catch (Exception e) {
-            e.printStackTrace();
+            log.info("unicast()", e);
         }
         }
         messageSendingExecutor.submit(this::unicast);
         messageSendingExecutor.submit(this::unicast);
     }
     }
@@ -336,7 +336,7 @@ public class MessagingPerfApp {
                     TEST_UNICAST_MESSAGE_TOPIC,
                     TEST_UNICAST_MESSAGE_TOPIC,
                     encoder);
                     encoder);
         } catch (Exception e) {
         } catch (Exception e) {
-            e.printStackTrace();
+            log.info("broadcast()", e);
         }
         }
         messageSendingExecutor.submit(this::broadcast);
         messageSendingExecutor.submit(this::broadcast);
     }
     }

@@ -63,6 +63,7 @@ public class AddTestFlowsCommand extends AbstractShellCommand {
     String numOfRuns = null;
     String numOfRuns = null;
 
 
     @Override
     @Override
+    @java.lang.SuppressWarnings("squid:S1148")
     protected void execute() {
     protected void execute() {
         FlowRuleService flowService = get(FlowRuleService.class);
         FlowRuleService flowService = get(FlowRuleService.class);
         DeviceService deviceService = get(DeviceService.class);
         DeviceService deviceService = get(DeviceService.class);

@@ -114,6 +114,7 @@ public class ReviewCommand extends AbstractShellCommand {
                         print("\t[Other] " + perm.getClass().getSimpleName() +
                         print("\t[Other] " + perm.getClass().getSimpleName() +
                                 " " + perm.getName() + " (" + perm.getActions() + ")");
                                 " " + perm.getName() + " (" + perm.getActions() + ")");
                     }
                     }
+                    break;
                 default:
                 default:
                     break;
                     break;
             }
             }

@@ -42,7 +42,7 @@ public final class IntentUtils {
      * @param two second intent
      * @param two second intent
      * @return true if the two intents represent the same value, otherwise false
      * @return true if the two intents represent the same value, otherwise false
      */
      */
-    public static boolean equals(Intent one, Intent two) {
+    public static boolean intentsAreEqual(Intent one, Intent two) {
         if (one.getClass() != two.getClass()) {
         if (one.getClass() != two.getClass()) {
             return false;
             return false;
         }
         }

@@ -232,6 +232,7 @@ public class DistributedSecurityModeStore
                         break;
                         break;
                     case SECURED:
                     case SECURED:
                         notifyDelegate(new SecurityModeEvent(SecurityModeEvent.Type.POLICY_ACCEPTED, appId));
                         notifyDelegate(new SecurityModeEvent(SecurityModeEvent.Type.POLICY_ACCEPTED, appId));
+                        break;
                     default:
                     default:
                         break;
                         break;
                 }
                 }
@@ -312,4 +313,4 @@ public class DistributedSecurityModeStore
     public void unsetDelegate(SecurityModeStoreDelegate delegate) {
     public void unsetDelegate(SecurityModeStoreDelegate delegate) {
         super.setDelegate(delegate);
         super.setDelegate(delegate);
     }
     }
-}
\ No newline at end of file
+}

@@ -87,8 +87,7 @@ public class CalientFiberSwitchHandshaker
         try {
         try {
             sendHandshakeOFExperimenterPortDescRequest();
             sendHandshakeOFExperimenterPortDescRequest();
         } catch (IOException e) {
         } catch (IOException e) {
-            log.error("Exception while sending experimenter port desc:", e.getMessage());
-            e.printStackTrace();
+            log.error("Exception while sending experimenter port desc:", e);
         }
         }
 
 
     }
     }

@@ -223,7 +223,7 @@ public final class FromJsonUtil {
             JsonNode jsonNode = input.get(i);
             JsonNode jsonNode = input.get(i);
             Operation operation = operations.get(i);
             Operation operation = operations.get(i);
             if (jsonNode != null && jsonNode.size() > 0) {
             if (jsonNode != null && jsonNode.size() > 0) {
-                if (i >= operations.size() || operation.getOp() != "select") {
+                if (i >= operations.size() || !operation.getOp().equals("select")) {
                     OperationResult or = objectMapper.convertValue(jsonNode, OperationResult.class);
                     OperationResult or = objectMapper.convertValue(jsonNode, OperationResult.class);
                     operationResults.add(or);
                     operationResults.add(or);
                 } else {
                 } else {

@@ -488,7 +488,7 @@ public class OpenFlowRuleProvider extends AbstractProvider
                                               + " tell us which one.");
                                               + " tell us which one.");
                         }
                         }
                     }
                     }
-
+                    break;
                 default:
                 default:
                     log.debug("Unhandled message type: {}", msg.getType());
                     log.debug("Unhandled message type: {}", msg.getType());
             }
             }

@@ -36,6 +36,7 @@ import java.util.List;
  * Produces ONOS component configuration catalogue resources.
  * Produces ONOS component configuration catalogue resources.
  */
  */
 @Mojo(name = "cfg", defaultPhase = LifecyclePhase.GENERATE_RESOURCES)
 @Mojo(name = "cfg", defaultPhase = LifecyclePhase.GENERATE_RESOURCES)
+@java.lang.SuppressWarnings("squid:S1148")
 public class OnosCfgMojo extends AbstractMojo {
 public class OnosCfgMojo extends AbstractMojo {
 
 
     private static final String COMPONENT = "org.apache.felix.scr.annotations.Component";
     private static final String COMPONENT = "org.apache.felix.scr.annotations.Component";

@@ -85,6 +85,7 @@ public class PIMHelloOption {
             case OPT_ADDRLIST:
             case OPT_ADDRLIST:
                 this.optLength = 0;   // We don't know what the length will be yet.
                 this.optLength = 0;   // We don't know what the length will be yet.
                 this.optValue = null;
                 this.optValue = null;
+                break;
 
 
             default:
             default:
                 //log.error("Unkown option type: " + type + "\n" );
                 //log.error("Unkown option type: " + type + "\n" );