alshabib

link provider tests

Change-Id: I074d067a1432c874fa0e1674423df046d4c31086
...@@ -33,6 +33,7 @@ public class FlowsListCommand extends AbstractShellCommand { ...@@ -33,6 +33,7 @@ public class FlowsListCommand extends AbstractShellCommand {
33 required = false, multiValued = false) 33 required = false, multiValued = false)
34 String uri = null; 34 String uri = null;
35 35
36 +
36 @Override 37 @Override
37 protected void execute() { 38 protected void execute() {
38 DeviceService deviceService = get(DeviceService.class); 39 DeviceService deviceService = get(DeviceService.class);
......
...@@ -86,7 +86,7 @@ public class LinkDiscovery implements TimerTask { ...@@ -86,7 +86,7 @@ public class LinkDiscovery implements TimerTask {
86 private final boolean useBDDP; 86 private final boolean useBDDP;
87 private final OpenFlowController ctrl; 87 private final OpenFlowController ctrl;
88 private final LinkProviderService linkProvider; 88 private final LinkProviderService linkProvider;
89 - private final Map<Integer, OFPortDesc> ports; 89 + protected final Map<Integer, OFPortDesc> ports;
90 private Timeout timeout; 90 private Timeout timeout;
91 91
92 /** 92 /**
......
...@@ -29,6 +29,7 @@ import org.projectfloodlight.openflow.protocol.OFPortState; ...@@ -29,6 +29,7 @@ import org.projectfloodlight.openflow.protocol.OFPortState;
29 import org.projectfloodlight.openflow.protocol.OFPortStatus; 29 import org.projectfloodlight.openflow.protocol.OFPortStatus;
30 import org.slf4j.Logger; 30 import org.slf4j.Logger;
31 31
32 +
32 /** 33 /**
33 * Provider which uses an OpenFlow controller to detect network 34 * Provider which uses an OpenFlow controller to detect network
34 * infrastructure links. 35 * infrastructure links.
...@@ -50,7 +51,7 @@ public class OpenFlowLinkProvider extends AbstractProvider implements LinkProvid ...@@ -50,7 +51,7 @@ public class OpenFlowLinkProvider extends AbstractProvider implements LinkProvid
50 51
51 private final InternalLinkProvider listener = new InternalLinkProvider(); 52 private final InternalLinkProvider listener = new InternalLinkProvider();
52 53
53 - private final Map<Dpid, LinkDiscovery> discoverers = new ConcurrentHashMap<>(); 54 + protected final Map<Dpid, LinkDiscovery> discoverers = new ConcurrentHashMap<>();
54 55
55 /** 56 /**
56 * Creates an OpenFlow link provider. 57 * Creates an OpenFlow link provider.
...@@ -138,7 +139,7 @@ public class OpenFlowLinkProvider extends AbstractProvider implements LinkProvid ...@@ -138,7 +139,7 @@ public class OpenFlowLinkProvider extends AbstractProvider implements LinkProvid
138 139
139 @Override 140 @Override
140 public void roleAssertFailed(Dpid dpid, RoleState role) { 141 public void roleAssertFailed(Dpid dpid, RoleState role) {
141 - // TODO Auto-generated method stub 142 + // do nothing for this.
142 } 143 }
143 144
144 } 145 }
......