Check if the logger is configured as trace when logging as trace

Change-Id: I58738913b18198fe8a01b313e776e20c6a21f1d0

Check if the logger is configured as trace when logging as trace
Change-Id: I58738913b18198fe8a01b313e776e20c6a21f1d0
Sho SHIMIZU · Gerrit Code Review
Commit 695bac68ec5da46d6cefc4ef9ef2f6a6caf1f6bc 695bac68 1 parent ba8c8050
Showing 2 changed files with 27 additions and 23 deletions
core/common/src/test/java/org/onosproject/store/trivial/SimpleGroupStore.java
core/store/dist/src/main/java/org/onosproject/store/group/impl/DistributedGroupStore.java
--- a/core/common/src/test/java/org/onosproject/store/trivial/SimpleGroupStore.java
View file @695bac6
+++ b/core/common/src/test/java/org/onosproject/store/trivial/SimpleGroupStore.java
View file @695bac6
@@ -575,19 +575,21 @@ public class SimpleGroupStore
         Set<Group> extraneousStoredEntries =
                 Sets.newHashSet(getExtraneousGroups(deviceId));
 
-         log.trace("pushGroupMetrics: Displaying all ({}) "
-                 + "southboundGroupEntries for device {}",
-                   southboundGroupEntries.size(),
-                   deviceId);
-         for (Group group : southboundGroupEntries) {
-             log.trace("Group {} in device {}", group, deviceId);
-         }
+         if (log.isTraceEnabled()) {
+             log.trace("pushGroupMetrics: Displaying all ({}) "
+                             + "southboundGroupEntries for device {}",
+                     southboundGroupEntries.size(),
+                     deviceId);
+             for (Group group : southboundGroupEntries) {
+                 log.trace("Group {} in device {}", group, deviceId);
+             }
 
-         log.trace("Displaying all ({}) stored group entries for device {}",
-                   storedGroupEntries.size(),
-                   deviceId);
-         for (Group group : storedGroupEntries) {
-             log.trace("Stored Group {} for device {}", group, deviceId);
+             log.trace("Displaying all ({}) stored group entries for device {}",
+                     storedGroupEntries.size(),
+                     deviceId);
+             for (Group group : storedGroupEntries) {
+                 log.trace("Stored Group {} for device {}", group, deviceId);
+             }
         }
 
         for (Iterator<Group> it2 = southboundGroupEntries.iterator(); it2.hasNext();) {
--- a/core/store/dist/src/main/java/org/onosproject/store/group/impl/DistributedGroupStore.java
View file @695bac6
+++ b/core/store/dist/src/main/java/org/onosproject/store/group/impl/DistributedGroupStore.java
View file @695bac6
@@ -1243,18 +1243,20 @@ public class DistributedGroupStore
         Set<Group> extraneousStoredEntries =
                 Sets.newHashSet(getExtraneousGroups(deviceId));
 
-         log.trace("pushGroupMetrics: Displaying all ({}) southboundGroupEntries for device {}",
-                   southboundGroupEntries.size(),
-                   deviceId);
-         for (Group group : southboundGroupEntries) {
-             log.trace("Group {} in device {}", group, deviceId);
-         }
+         if (log.isTraceEnabled()) {
+             log.trace("pushGroupMetrics: Displaying all ({}) southboundGroupEntries for device {}",
+                     southboundGroupEntries.size(),
+                     deviceId);
+             for (Group group : southboundGroupEntries) {
+                 log.trace("Group {} in device {}", group, deviceId);
+             }
 
-         log.trace("Displaying all ({}) stored group entries for device {}",
-                   storedGroupEntries.size(),
-                   deviceId);
-         for (StoredGroupEntry group : storedGroupEntries) {
-             log.trace("Stored Group {} for device {}", group, deviceId);
+             log.trace("Displaying all ({}) stored group entries for device {}",
+                     storedGroupEntries.size(),
+                     deviceId);
+             for (StoredGroupEntry group : storedGroupEntries) {
+                 log.trace("Stored Group {} for device {}", group, deviceId);
+             }
         }
 
         garbageCollect(deviceId, southboundGroupEntries, storedGroupEntries);