Fixed duplicate package issue and javaDoc warnings

Change-Id: I3c6456b650516e978e446471a3ffc7b693dab9c4

-BUNDLES = [
-    '//apps/scalablegateway/api:onos-apps-scalablegateway-api',
-    '//apps/scalablegateway/app:onos-apps-scalablegateway-app',
+COMPILE_DEPS = [
+    '//lib:CORE_DEPS',
 ]
 ]
 
 
+osgi_jar_with_tests (
+    deps = COMPILE_DEPS,
+)
+
 onos_app (
 onos_app (
   title = 'Scalable GW App',
   title = 'Scalable GW App',
   category = 'Utility',
   category = 'Utility',
   url = 'http://onosproject.org',
   url = 'http://onosproject.org',
-  included_bundles = BUNDLES,
+  description = 'Scalable gateway service',
 )
 )

-COMPILE_DEPS = [
-    '//lib:CORE_DEPS',
-]
-
-osgi_jar_with_tests (
-    deps = COMPILE_DEPS,
-)
\ No newline at end of file

-<?xml version="1.0" encoding="UTF-8"?>
-<!--
-  ~ Copyright 2016-present Open Networking Laboratory
-  ~
-  ~ Licensed under the Apache License, Version 2.0 (the "License");
-  ~ you may not use this file except in compliance with the License.
-  ~ You may obtain a copy of the License at
-  ~
-  ~     http://www.apache.org/licenses/LICENSE-2.0
-  ~
-  ~ Unless required by applicable law or agreed to in writing, software
-  ~ distributed under the License is distributed on an "AS IS" BASIS,
-  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-  ~ See the License for the specific language governing permissions and
-  ~ limitations under the License.
-  -->
-<project xmlns="http://maven.apache.org/POM/4.0.0"
-         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
-    <modelVersion>4.0.0</modelVersion>
-
-    <parent>
-        <groupId>org.onosproject</groupId>
-        <artifactId>onos-scalablegateway</artifactId>
-        <version>1.6.0-SNAPSHOT</version>
-        <relativePath>../pom.xml</relativePath>
-    </parent>
-
-    <artifactId>onos-app-scalablegateway-api</artifactId>
-    <packaging>bundle</packaging>
-
-    <dependencies>
-        <dependency>
-            <groupId>org.onosproject</groupId>
-            <artifactId>onos-api</artifactId>
-        </dependency>
-    </dependencies>
-
-</project>
\ No newline at end of file

-COMPILE_DEPS = [
-    '//lib:CORE_DEPS',
-    '//apps/scalablegateway/api:onos-apps-scalablegateway-api',
-]
-
-TEST_DEPS = [
-    '//lib:TEST_ADAPTERS',
-]
-
-osgi_jar_with_tests (
-    deps = COMPILE_DEPS,
-    test_deps = TEST_DEPS,
-)

-<?xml version="1.0" encoding="UTF-8"?>
-<!--
-  ~ Copyright 2016-present Open Networking Laboratory
-  ~
-  ~ Licensed under the Apache License, Version 2.0 (the "License");
-  ~ you may not use this file except in compliance with the License.
-  ~ You may obtain a copy of the License at
-  ~
-  ~     http://www.apache.org/licenses/LICENSE-2.0
-  ~
-  ~ Unless required by applicable law or agreed to in writing, software
-  ~ distributed under the License is distributed on an "AS IS" BASIS,
-  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-  ~ See the License for the specific language governing permissions and
-  ~ limitations under the License.
-  -->
-<project xmlns="http://maven.apache.org/POM/4.0.0"
-         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
-    <modelVersion>4.0.0</modelVersion>
-
-    <parent>
-        <groupId>org.onosproject</groupId>
-        <artifactId>onos-scalablegateway</artifactId>
-        <version>1.6.0-SNAPSHOT</version>
-        <relativePath>../pom.xml</relativePath>
-    </parent>
-
-    <artifactId>onos-app-scalablegateway-app</artifactId>
-    <packaging>bundle</packaging>
-
-    <dependencies>
-        <dependency>
-            <groupId>org.onosproject</groupId>
-            <artifactId>onos-api</artifactId>
-        </dependency>
-        <dependency>
-            <groupId>org.onosproject</groupId>
-            <artifactId>onos-app-scalablegateway-api</artifactId>
-            <version>${project.version}</version>
-        </dependency>
-    </dependencies>
-
-</project>

@@ -27,13 +27,26 @@
     </parent>
     </parent>
 
 
     <artifactId>onos-scalablegateway</artifactId>
     <artifactId>onos-scalablegateway</artifactId>
-    <packaging>pom</packaging>
+    <packaging>bundle</packaging>
 
 
-    <description>ONOS ScalableGateway applications</description>
+    <description>ONOS Scalable Gateway applications</description>
 
 
-    <modules>
-        <module>api</module>
-        <module>app</module>
-    </modules>
+    <properties>
+        <onos.app.name>org.onosproject.scalablegateway</onos.app.name>
+        <onos.app.title>Scalable Gateway App</onos.app.title>
+        <onos.app.category>Utility</onos.app.category>
+        <onos.app.url>http://onosproject.org</onos.app.url>
+        <onos.app.readm>Scalable Gateway Application.</onos.app.readm>
+    </properties>
 
 
+    <dependencies>
+        <dependency>
+            <groupId>org.osgi</groupId>
+            <artifactId>org.osgi.compendium</artifactId>
+        </dependency>
+        <dependency>
+            <groupId>org.onosproject</groupId>
+            <artifactId>onos-api</artifactId>
+        </dependency>
+    </dependencies>
 </project>
 </project>

@@ -13,7 +13,7 @@
  * See the License for the specific language governing permissions and
  * See the License for the specific language governing permissions and
  * limitations under the License.
  * limitations under the License.
  */
  */
-package org.onosproject.scalablegateway;
+package org.onosproject.scalablegateway.api;
 
 
 import com.google.common.collect.ImmutableList;
 import com.google.common.collect.ImmutableList;
 import org.onlab.packet.Ip4Address;
 import org.onlab.packet.Ip4Address;

@@ -13,7 +13,7 @@
  * See the License for the specific language governing permissions and
  * See the License for the specific language governing permissions and
  * limitations under the License.
  * limitations under the License.
  */
  */
-package org.onosproject.scalablegateway;
+package org.onosproject.scalablegateway.api;
 
 
 import org.onosproject.core.GroupId;
 import org.onosproject.core.GroupId;
 import org.onosproject.net.DeviceId;
 import org.onosproject.net.DeviceId;
@@ -45,6 +45,7 @@ public interface ScalableGatewayService {
     /**
     /**
      * Returns group id for gateway load balance.
      * Returns group id for gateway load balance.
      *
      *
+     * @param srcDeviceId source device id
      * @return The group id
      * @return The group id
      */
      */
     GroupId getGroupIdForGatewayLoadBalance(DeviceId srcDeviceId);
     GroupId getGroupIdForGatewayLoadBalance(DeviceId srcDeviceId);

@@ -17,4 +17,4 @@
 /**
 /**
  * Application for ScaleableGateway management.
  * Application for ScaleableGateway management.
  */
  */
-package org.onosproject.scalablegateway;
\ No newline at end of file
+package org.onosproject.scalablegateway.api;
\ No newline at end of file

@@ -14,11 +14,13 @@
  * limitations under the License.
  * limitations under the License.
  */
  */
 
 
-package org.onosproject.scalablegateway;
+package org.onosproject.scalablegateway.impl;
 
 
 import org.onosproject.core.GroupId;
 import org.onosproject.core.GroupId;
 import org.onosproject.net.DeviceId;
 import org.onosproject.net.DeviceId;
 import org.onosproject.net.PortNumber;
 import org.onosproject.net.PortNumber;
+import org.onosproject.scalablegateway.api.GatewayNode;
+import org.onosproject.scalablegateway.api.ScalableGatewayService;
 
 
 import java.util.List;
 import java.util.List;
 
 

@@ -17,4 +17,4 @@
 /**
 /**
  * Application for ScaleableGateway management.
  * Application for ScaleableGateway management.
  */
  */
-package org.onosproject.scalablegateway;
\ No newline at end of file
+package org.onosproject.scalablegateway.impl;
\ No newline at end of file