HIGUCHI Yuta
Committed by Gerrit Code Review

Fix L2ModificationInstructions

- PopVlanInstruction
  - type mismatch in #equals()

- StripVlanInstruction
  - hide default constructor
  - align #toString() format
  - fix #equals()

Change-Id: Ifb14866df19cc32dcb9cc28ab473de5ca45d8e41
...@@ -285,6 +285,8 @@ public abstract class L2ModificationInstruction implements Instruction { ...@@ -285,6 +285,8 @@ public abstract class L2ModificationInstruction implements Instruction {
285 285
286 public static final class StripVlanInstruction extends L2ModificationInstruction { 286 public static final class StripVlanInstruction extends L2ModificationInstruction {
287 287
288 + StripVlanInstruction() {}
289 +
288 @Override 290 @Override
289 public L2SubType subtype() { 291 public L2SubType subtype() {
290 return L2SubType.STRIP_VLAN; 292 return L2SubType.STRIP_VLAN;
...@@ -292,7 +294,8 @@ public abstract class L2ModificationInstruction implements Instruction { ...@@ -292,7 +294,8 @@ public abstract class L2ModificationInstruction implements Instruction {
292 294
293 @Override 295 @Override
294 public String toString() { 296 public String toString() {
295 - return subtype().toString(); 297 + return toStringHelper(subtype().toString())
298 + .toString();
296 } 299 }
297 300
298 @Override 301 @Override
...@@ -305,7 +308,9 @@ public abstract class L2ModificationInstruction implements Instruction { ...@@ -305,7 +308,9 @@ public abstract class L2ModificationInstruction implements Instruction {
305 if (this == obj) { 308 if (this == obj) {
306 return true; 309 return true;
307 } 310 }
308 - 311 + if (obj instanceof StripVlanInstruction) {
312 + return true;
313 + }
309 return false; 314 return false;
310 } 315 }
311 } 316 }
...@@ -341,8 +346,8 @@ public abstract class L2ModificationInstruction implements Instruction { ...@@ -341,8 +346,8 @@ public abstract class L2ModificationInstruction implements Instruction {
341 if (this == obj) { 346 if (this == obj) {
342 return true; 347 return true;
343 } 348 }
344 - if (obj instanceof PushHeaderInstructions) { 349 + if (obj instanceof PopVlanInstruction) {
345 - PushHeaderInstructions that = (PushHeaderInstructions) obj; 350 + PopVlanInstruction that = (PopVlanInstruction) obj;
346 return Objects.equals(subtype, that.subtype); 351 return Objects.equals(subtype, that.subtype);
347 } 352 }
348 return false; 353 return false;
......