홍길동 / onos

Go to a project
Toggle navigation Toggle navigation pinning
Ray Milkey
Committed by Gerrit Code Review
87b16b09 1 parent 9ad67e51

Javadoc Fixes 

Change-Id: I9107a50e32e3dc33c13b55b83418c2c91d46478b
Inline Side-by-side
Showing 2 changed files with 13 additions and 3 deletions
...@@ -32,9 +32,9 @@ public class OpenstackArpHandler { ...@@ -32,9 +32,9 @@ public class OpenstackArpHandler {
32 HashMap<String, OpenstackPort> openstackPortHashMap; 32 HashMap<String, OpenstackPort> openstackPortHashMap;
33 33
34 /** 34 /**
35 - * Returns OpenstackArpHandler reference. 35 + * Constructs an OpenstackArpHandler.
36 * 36 *
37 - * @param openstackPortMap 37 + * @param openstackPortMap port map
38 */ 38 */
39 public OpenstackArpHandler(HashMap<String, OpenstackPort> openstackPortMap) { 39 public OpenstackArpHandler(HashMap<String, OpenstackPort> openstackPortMap) {
40 this.openstackPortHashMap = openstackPortMap; 40 this.openstackPortHashMap = openstackPortMap;
......
...@@ -49,7 +49,9 @@ public class OpenstackSwitchingRulePopulator { ...@@ -49,7 +49,9 @@ public class OpenstackSwitchingRulePopulator {
49 private ApplicationId appId; 49 private ApplicationId appId;
50 50
51 /** 51 /**
52 - * Returns OpenstackSwitchingRule reference. 52 + * Creates OpenstackSwitchingRulPopulator.
53 + *
54 + * @param appId application id
53 * @param flowObjectiveService FlowObjectiveService reference 55 * @param flowObjectiveService FlowObjectiveService reference
54 */ 56 */
55 public OpenstackSwitchingRulePopulator(ApplicationId appId, 57 public OpenstackSwitchingRulePopulator(ApplicationId appId,
...@@ -61,6 +63,10 @@ public class OpenstackSwitchingRulePopulator { ...@@ -61,6 +63,10 @@ public class OpenstackSwitchingRulePopulator {
61 /** 63 /**
62 * Populates flows rules for forwarding packets to and from VMs. 64 * Populates flows rules for forwarding packets to and from VMs.
63 * 65 *
66 + * @param ip v4 IP Address
67 + * @param id device ID
68 + * @param port port
69 + * @param cidr v4 IP prefix
64 * @return true if it succeeds to populate rules, false otherwise. 70 * @return true if it succeeds to populate rules, false otherwise.
65 */ 71 */
66 public boolean populateForwardingRule(Ip4Address ip, DeviceId id, Port port, Ip4Prefix cidr) { 72 public boolean populateForwardingRule(Ip4Address ip, DeviceId id, Port port, Ip4Prefix cidr) {
...@@ -94,9 +100,13 @@ public class OpenstackSwitchingRulePopulator { ...@@ -94,9 +100,13 @@ public class OpenstackSwitchingRulePopulator {
94 * @param id device ID to populates the flow rules 100 * @param id device ID to populates the flow rules
95 * @param hostIp host IP address of the VM 101 * @param hostIp host IP address of the VM
96 * @param vmIp fixed IP address for the VM 102 * @param vmIp fixed IP address for the VM
103 + * @param vmMac MAC address for the VM
104 + * @param tunnelPort tunnel port number for the VM
97 * @param idx device ID for OVS of the other VM 105 * @param idx device ID for OVS of the other VM
98 * @param hostIpx host IP address of the other VM 106 * @param hostIpx host IP address of the other VM
99 * @param vmIpx fixed IP address of the other VM 107 * @param vmIpx fixed IP address of the other VM
108 + * @param vmMacx MAC address for the other VM
109 + * @param tunnelPortx x tunnel port number for other VM
100 */ 110 */
101 public void populateForwardingRuleForOtherCnode(String vni, DeviceId id, Ip4Address hostIp, 111 public void populateForwardingRuleForOtherCnode(String vni, DeviceId id, Ip4Address hostIp,
102 Ip4Address vmIp, MacAddress vmMac, PortNumber tunnelPort, 112 Ip4Address vmIp, MacAddress vmMac, PortNumber tunnelPort,
......