Unit tests to improve coverage

- DefaultPacketRequest
- PacketEventTest
- PacketProcessor

Change-Id: I86d1416f808ebc901ed84204f2e772dc25f9eb58

+/*
+ * Copyright 2015 Open Networking Laboratory
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.onosproject.net.packet;
+
+import org.junit.Test;
+import org.onosproject.core.DefaultApplicationId;
+import org.onosproject.net.NetTestTools;
+import org.onosproject.net.flow.DefaultTrafficSelector;
+import org.onosproject.net.flow.TrafficSelector;
+
+import com.google.common.testing.EqualsTester;
+
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.hamcrest.Matchers.is;
+import static org.onlab.junit.ImmutableClassChecker.assertThatClassIsImmutable;
+
+/**
+ * Unit tests for the DefaultPacketRequest class.
+ */
+public class DefaultPacketRequestTest {
+
+    private final TrafficSelector selector = DefaultTrafficSelector
+            .builder()
+            .matchIcmpCode((byte) 1)
+            .build();
+
+    private final DefaultPacketRequest packetRequest1 =
+            new DefaultPacketRequest(DefaultTrafficSelector.emptySelector(),
+                                     PacketPriority.CONTROL,
+                                     NetTestTools.APP_ID);
+    private final DefaultPacketRequest sameAsacketRequest1 =
+            new DefaultPacketRequest(DefaultTrafficSelector.emptySelector(),
+                                     PacketPriority.CONTROL,
+                                     NetTestTools.APP_ID);
+    private final DefaultPacketRequest packetRequest2 =
+            new DefaultPacketRequest(selector,
+                                     PacketPriority.CONTROL,
+                                     NetTestTools.APP_ID);
+    private final DefaultPacketRequest packetRequest3 =
+            new DefaultPacketRequest(DefaultTrafficSelector.emptySelector(),
+                                     PacketPriority.REACTIVE,
+                                     NetTestTools.APP_ID);
+    private final DefaultPacketRequest packetRequest4 =
+            new DefaultPacketRequest(DefaultTrafficSelector.emptySelector(),
+                                     PacketPriority.CONTROL,
+                                     new DefaultApplicationId(1, "foo"));
+
+    /**
+     * Tests the operation of the equals(), toAstring() and hashCode() methods.
+     */
+    @Test
+    public void testEquals() {
+        new EqualsTester()
+                .addEqualityGroup(packetRequest1, sameAsacketRequest1)
+                .addEqualityGroup(packetRequest2)
+                .addEqualityGroup(packetRequest3)
+                .addEqualityGroup(packetRequest4)
+                .testEquals();
+    }
+
+    /**
+     * Tests that building and fetching from a DefaultPacketRequest is correct.
+     */
+    @Test
+    public void testConstruction() {
+        assertThat(packetRequest1.priority(), is(PacketPriority.CONTROL));
+        assertThat(packetRequest1.priority().priorityValue(),
+                   is(PacketPriority.CONTROL.priorityValue()));
+        assertThat(packetRequest1.selector(), is(DefaultTrafficSelector.emptySelector()));
+        assertThat(packetRequest1.appId(), is(NetTestTools.APP_ID));
+    }
+
+    /**
+     * Checks that the DefaultPacketRequest class is immutable.
+     */
+    @Test
+    public void testImmutability() {
+        assertThatClassIsImmutable(DefaultPacketRequest.class);
+    }
+}

+/*
+ * Copyright 2015 Open Networking Laboratory
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.onosproject.net.packet;
+
+import org.junit.Test;
+
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.hamcrest.Matchers.greaterThanOrEqualTo;
+import static org.hamcrest.Matchers.is;
+
+/**
+ * Unit tests for PacketEvent class.
+ */
+public class PacketEventTest {
+
+    OutboundPacket packet;
+
+    @Test
+    public void testConstruction1() {
+        long time = System.currentTimeMillis();
+        PacketEvent event = new PacketEvent(PacketEvent.Type.EMIT, packet);
+
+        assertThat(event.type(), is(PacketEvent.Type.EMIT));
+        assertThat(event.subject(), is(packet));
+        assertThat(event.time(), greaterThanOrEqualTo(time));
+    }
+
+    @Test
+    public void testConstruction2() {
+        long time = 12345678;
+        PacketEvent event = new PacketEvent(PacketEvent.Type.EMIT, packet, time);
+
+        assertThat(event.type(), is(PacketEvent.Type.EMIT));
+        assertThat(event.subject(), is(packet));
+        assertThat(event.time(), is(time));
+    }
+
+}

+/*
+ * Copyright 2015 Open Networking Laboratory
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.onosproject.net.packet;
+
+import org.junit.Test;
+
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.hamcrest.Matchers.greaterThanOrEqualTo;
+import static org.hamcrest.Matchers.lessThan;
+
+/**
+ * Unit tests for static APIs in the packet processor class.
+ */
+public class PacketProcessorTest {
+
+    /**
+     * Tests a priority in the advisor range.
+     */
+    @Test
+    public void testAdvisorPriorities() {
+        int advisorPriority = PacketProcessor.advisor(3);
+        assertThat(advisorPriority, lessThan(PacketProcessor.ADVISOR_MAX));
+        assertThat(advisorPriority, greaterThanOrEqualTo(0));
+    }
+
+    /**
+     * Tests a priority in the director range.
+     */
+    @Test
+    public void testDirectorPriorities() {
+        int directorPriority = PacketProcessor.director(3);
+        assertThat(directorPriority, lessThan(PacketProcessor.DIRECTOR_MAX));
+        assertThat(directorPriority, greaterThanOrEqualTo(PacketProcessor.ADVISOR_MAX));
+    }
+
+    /**
+     * Tests a priority in the observer range.
+     */
+    @Test
+    public void testObserverPriorities() {
+        int observerPriority = PacketProcessor.observer(3);
+        assertThat(observerPriority, lessThan(PacketProcessor.OBSERVER_MAX));
+        assertThat(observerPriority, greaterThanOrEqualTo(PacketProcessor.DIRECTOR_MAX));
+    }
+
+}