홍길동 / onos

Go to a project
Toggle navigation Toggle navigation pinning
Yuta HIGUCHI
Committed by Gerrit Code Review
a5cda899 1 parent 6f4d5864

Reduce number of Map lookups 

Change-Id: I6ea71c120e9143dabdb44dfd86b78f570647eb4b
Inline Side-by-side
Showing 1 changed file with 6 additions and 4 deletions
......@@ -26,6 +26,7 @@ import org.onosproject.net.resource.Resources;
import java.util.LinkedHashMap;
import java.util.LinkedHashSet;
import java.util.Map;
import java.util.Map.Entry;
import java.util.Objects;
import java.util.Optional;
import java.util.Set;
......@@ -100,13 +101,14 @@ final class EncodableDiscreteResources implements DiscreteResources {
EncodableDiscreteResources cast = (EncodableDiscreteResources) other;
Map<Class<?>, EncodedDiscreteResources> newMap = new LinkedHashMap<>();
for (Class<?> key : this.map.keySet()) {
EncodedDiscreteResources thisValues = this.map.get(key);
if (!cast.map.containsKey(key)) {
for (Entry<Class<?>, EncodedDiscreteResources> e : this.map.entrySet()) {
Class<?> key = e.getKey();
EncodedDiscreteResources thisValues = e.getValue();
EncodedDiscreteResources otherValues = cast.map.get(key);
if (otherValues == null) {
newMap.put(key, thisValues);
continue;
}
EncodedDiscreteResources otherValues = cast.map.get(key);
EncodedDiscreteResources diff = thisValues.difference(otherValues);
// omit empty resources from a new resource set
// empty EncodedDiscreteResources can't deserialize due to
......