Fixed a number of javadoc warnings and cleaned up aggregate javadocs.

@@ -32,6 +32,7 @@ public class TestMessage extends AbstractMessage {
     /**
     /**
      * Creates a new message with the specified data.
      * Creates a new message with the specified data.
      *
      *
+     * @param length        message length
      * @param requestorTime requester time
      * @param requestorTime requester time
      * @param responderTime responder time
      * @param responderTime responder time
      * @param padding       message padding
      * @param padding       message padding

@@ -67,7 +67,8 @@ public abstract class ConnectivityIntentCompiler<T extends ConnectivityIntent>
     /**
     /**
      * Validates the specified path against the given constraints.
      * Validates the specified path against the given constraints.
      *
      *
-     * @param path path to be checked
+     * @param path        path to be checked
+     * @param constraints path constraints
      * @return true if the path passes all constraints
      * @return true if the path passes all constraints
      */
      */
     protected boolean checkPath(Path path, List<Constraint> constraints) {
     protected boolean checkPath(Path path, List<Constraint> constraints) {
@@ -82,8 +83,9 @@ public abstract class ConnectivityIntentCompiler<T extends ConnectivityIntent>
     /**
     /**
      * Computes a path between two ConnectPoints.
      * Computes a path between two ConnectPoints.
      *
      *
-     * @param one start of the path
-     * @param two end of the path
+     * @param intent intent on which behalf path is being computed
+     * @param one    start of the path
+     * @param two    end of the path
      * @return Path between the two
      * @return Path between the two
      * @throws PathNotFoundException if a path cannot be found
      * @throws PathNotFoundException if a path cannot be found
      */
      */

@@ -248,8 +248,9 @@ public class DefaultTopology extends AbstractModel implements Topology {
      * Computes on-demand the set of shortest paths between source and
      * Computes on-demand the set of shortest paths between source and
      * destination devices.
      * destination devices.
      *
      *
-     * @param src source device
-     * @param dst destination device
+     * @param src    source device
+     * @param dst    destination device
+     * @param weight link weight function
      * @return set of shortest paths
      * @return set of shortest paths
      */
      */
     Set<Path> getPaths(DeviceId src, DeviceId dst, LinkWeight weight) {
     Set<Path> getPaths(DeviceId src, DeviceId dst, LinkWeight weight) {

@@ -87,7 +87,13 @@
                         <group>
                         <group>
                             <title>Sample Applications</title>
                             <title>Sample Applications</title>
                             <packages>
                             <packages>
-                                org.onlab.onos.tvue:org.onlab.onos.fwd:org.onlab.onos.ifwd:org.onlab.onos.mobility:org.onlab.onos.proxyarp:org.onlab.onos.foo:org.onlab.onos.calendar:org.onlab.onos.sdnip:org.onlab.onos.sdnip.*:org.onlab.onos.optical:org.onlab.onos.optical.*:org.onlab.onos.metrics.*:org.onlab.onos.config
+                                org.onlab.onos.tvue:org.onlab.onos.fwd:org.onlab.onos.ifwd:org.onlab.onos.mobility:org.onlab.onos.proxyarp:org.onlab.onos.foo:org.onlab.onos.calendar:org.onlab.onos.optical.*:org.onlab.onos.sdnip:org.onlab.onos.sdnip.*:org.onlab.onos.config
+                            </packages>
+                        </group>
+                        <group>
+                            <title>Test Instrumentation</title>
+                            <packages>
+                                org.onlab.onos.metrics.*:org.onlab.onos.oecfg
                             </packages>
                             </packages>
                         </group>
                         </group>
                     </groups>
                     </groups>

@@ -115,7 +115,7 @@ class OFChannelHandler extends IdleStateAwareChannelHandler {
 
 
     /**
     /**
      * Create a new unconnected OFChannelHandler.
      * Create a new unconnected OFChannelHandler.
-     * @param controller
+     * @param controller parent controller
      */
      */
     OFChannelHandler(Controller controller) {
     OFChannelHandler(Controller controller) {
         this.controller = controller;
         this.controller = controller;
@@ -794,7 +794,7 @@ class OFChannelHandler extends IdleStateAwareChannelHandler {
          * @param m The PortStatus message we received
          * @param m The PortStatus message we received
          * @param doNotify if true switch port changed events will be
          * @param doNotify if true switch port changed events will be
          * dispatched
          * dispatched
-         * @throws SwitchStateException
+         * @throws SwitchStateException if the switch is not bound to the channel
          *
          *
          */
          */
         protected void handlePortStatusMessage(OFChannelHandler h, OFPortStatus m,
         protected void handlePortStatusMessage(OFChannelHandler h, OFPortStatus m,
@@ -826,8 +826,8 @@ class OFChannelHandler extends IdleStateAwareChannelHandler {
          *
          *
          * @param h The OFChannelHandler that received the message
          * @param h The OFChannelHandler that received the message
          * @param m The message we received.
          * @param m The message we received.
-         * @throws SwitchStateException
-         * @throws IOException
+         * @throws SwitchStateException if the switch is not bound to the channel
+         * @throws IOException if unable to send message back to the switch
          */
          */
         void processOFMessage(OFChannelHandler h, OFMessage m)
         void processOFMessage(OFChannelHandler h, OFMessage m)
                 throws IOException, SwitchStateException {
                 throws IOException, SwitchStateException {