Added ping to age-out idle or stale connections.

Repushing due to a javadoc inherited from the master.

Change-Id: I375fc114079ba7d0a2897791ba05fa41762db80b

@@ -20,19 +20,56 @@ import org.eclipse.jetty.websocket.WebSocketServlet;
 import org.onlab.osgi.DefaultServiceDirectory;
 import org.onlab.osgi.DefaultServiceDirectory;
 import org.onlab.osgi.ServiceDirectory;
 import org.onlab.osgi.ServiceDirectory;
 
 
+import javax.servlet.ServletException;
 import javax.servlet.http.HttpServletRequest;
 import javax.servlet.http.HttpServletRequest;
+import java.util.HashSet;
+import java.util.Iterator;
+import java.util.Set;
+import java.util.Timer;
+import java.util.TimerTask;
 
 
 /**
 /**
  * Web socket servlet capable of creating various sockets for the user interface.
  * Web socket servlet capable of creating various sockets for the user interface.
  */
  */
 public class GuiWebSocketServlet extends WebSocketServlet {
 public class GuiWebSocketServlet extends WebSocketServlet {
 
 
+    private static final long PING_DELAY_MS = 5000;
+
     private ServiceDirectory directory = new DefaultServiceDirectory();
     private ServiceDirectory directory = new DefaultServiceDirectory();
 
 
+    private final Set<TopologyWebSocket> sockets = new HashSet<>();
+    private final Timer timer = new Timer();
+    private final TimerTask pruner = new Pruner();
+
     @Override
     @Override
-    public WebSocket doWebSocketConnect(HttpServletRequest request, String protocol) {
+    public void init() throws ServletException {
+        super.init();
+        timer.schedule(pruner, PING_DELAY_MS, PING_DELAY_MS);
+    }
 
 
-        return new TopologyWebSocket(directory);
+    @Override
+    public WebSocket doWebSocketConnect(HttpServletRequest request, String protocol) {
+        TopologyWebSocket socket = new TopologyWebSocket(directory);
+        synchronized (sockets) {
+            sockets.add(socket);
+        }
+        return socket;
     }
     }
 
 
+    // Task for pruning web-sockets that are idle.
+    private class Pruner extends TimerTask {
+        @Override
+        public void run() {
+            synchronized (sockets) {
+                Iterator<TopologyWebSocket> it = sockets.iterator();
+                while (it.hasNext()) {
+                    TopologyWebSocket socket = it.next();
+                    if (socket.isIdle()) {
+                        it.remove();
+                        socket.close();
+                    }
+                }
+            }
+        }
+    }
 }
 }

@@ -61,13 +61,21 @@ import static org.onlab.onos.net.link.LinkEvent.Type.LINK_ADDED;
  * Web socket capable of interacting with the GUI topology view.
  * Web socket capable of interacting with the GUI topology view.
  */
  */
 public class TopologyWebSocket
 public class TopologyWebSocket
-        extends TopologyMessages implements WebSocket.OnTextMessage {
+        extends TopologyMessages
+        implements WebSocket.OnTextMessage, WebSocket.OnControl {
+
+    private static final long MAX_AGE_MS = 15000;
+
+    private static final byte PING = 0x9;
+    private static final byte PONG = 0xA;
+    private static final byte[] PING_DATA = new byte[]{(byte) 0xde, (byte) 0xad};
 
 
     private static final String APP_ID = "org.onlab.onos.gui";
     private static final String APP_ID = "org.onlab.onos.gui";
 
 
     private final ApplicationId appId;
     private final ApplicationId appId;
 
 
     private Connection connection;
     private Connection connection;
+    private FrameConnection control;
 
 
     private final ClusterEventListener clusterListener = new InternalClusterListener();
     private final ClusterEventListener clusterListener = new InternalClusterListener();
     private final DeviceListener deviceListener = new InternalDeviceListener();
     private final DeviceListener deviceListener = new InternalDeviceListener();
@@ -79,6 +87,8 @@ public class TopologyWebSocket
     // Intents that are being monitored for the GUI
     // Intents that are being monitored for the GUI
     private static Map<IntentId, Long> intentsToMonitor = new ConcurrentHashMap<>();
     private static Map<IntentId, Long> intentsToMonitor = new ConcurrentHashMap<>();
 
 
+    private long lastActive = System.currentTimeMillis();
+
     /**
     /**
      * Creates a new web-socket for serving data to GUI topology view.
      * Creates a new web-socket for serving data to GUI topology view.
      *
      *
@@ -89,9 +99,37 @@ public class TopologyWebSocket
         appId = directory.get(CoreService.class).registerApplication(APP_ID);
         appId = directory.get(CoreService.class).registerApplication(APP_ID);
     }
     }
 
 
+    /**
+     * Issues a close on the connection.
+     */
+    synchronized void close() {
+        if (connection.isOpen()) {
+            removeListeners();
+            connection.close();
+        }
+    }
+
+    /**
+     * Indicates if this connection is idle.
+     */
+    synchronized boolean isIdle() {
+        boolean idle = (System.currentTimeMillis() - lastActive) > MAX_AGE_MS;
+        if (idle || !connection.isOpen()) {
+            return true;
+        }
+        try {
+            control.sendControl(PING, PING_DATA, 0, PING_DATA.length);
+        } catch (IOException e) {
+            log.warn("Unable to send ping message due to: ", e);
+        }
+        return false;
+    }
+
     @Override
     @Override
     public void onOpen(Connection connection) {
     public void onOpen(Connection connection) {
+        log.info("GUI client connected");
         this.connection = connection;
         this.connection = connection;
+        this.control = (FrameConnection) connection;
         addListeners();
         addListeners();
 
 
         sendAllInstances();
         sendAllInstances();
@@ -101,12 +139,22 @@ public class TopologyWebSocket
     }
     }
 
 
     @Override
     @Override
-    public void onClose(int closeCode, String message) {
-        removeListeners();
+    public synchronized void onClose(int closeCode, String message) {
+        if (connection.isOpen()) {
+            removeListeners();
+        }
+        log.info("GUI client disconnected");
+    }
+
+    @Override
+    public boolean onControl(byte controlCode, byte[] data, int offset, int length) {
+        lastActive = System.currentTimeMillis();
+        return true;
     }
     }
 
 
     @Override
     @Override
     public void onMessage(String data) {
     public void onMessage(String data) {
+        lastActive = System.currentTimeMillis();
         try {
         try {
             ObjectNode event = (ObjectNode) mapper.reader().readTree(data);
             ObjectNode event = (ObjectNode) mapper.reader().readTree(data);
             String type = string(event, "event", "unknown");
             String type = string(event, "event", "unknown");
@@ -123,16 +171,17 @@ public class TopologyWebSocket
             }
             }
         } catch (Exception e) {
         } catch (Exception e) {
             log.warn("Unable to parse GUI request {} due to {}", data, e);
             log.warn("Unable to parse GUI request {} due to {}", data, e);
-            e.printStackTrace();
         }
         }
     }
     }
 
 
     // Sends the specified data to the client.
     // Sends the specified data to the client.
-    private void sendMessage(ObjectNode data) {
+    private synchronized void sendMessage(ObjectNode data) {
         try {
         try {
-            connection.sendMessage(data.toString());
+            if (connection.isOpen()) {
+                connection.sendMessage(data.toString());
+            }
         } catch (IOException e) {
         } catch (IOException e) {
-            e.printStackTrace();
+            log.warn("Unable to send message {} to GUI due to {}", data, e);
         }
         }
     }
     }
 
 
@@ -229,6 +278,7 @@ public class TopologyWebSocket
         linkService.removeListener(linkListener);
         linkService.removeListener(linkListener);
         hostService.removeListener(hostListener);
         hostService.removeListener(hostListener);
         mastershipService.removeListener(mastershipListener);
         mastershipService.removeListener(mastershipListener);
+        intentService.removeListener(intentListener);
     }
     }
 
 
     // Cluster event listener.
     // Cluster event listener.
@@ -268,6 +318,7 @@ public class TopologyWebSocket
         @Override
         @Override
         public void event(MastershipEvent event) {
         public void event(MastershipEvent event) {
             // TODO: Is DeviceEvent.Type.DEVICE_MASTERSHIP_CHANGED the same?
             // TODO: Is DeviceEvent.Type.DEVICE_MASTERSHIP_CHANGED the same?
+
         }
         }
     }
     }