Committed by
Brian O'Connor
Remove CompilingFailed because it does nothing
Change-Id: Ibeb244d0a9ebfbf019bc72e1efeacb73c3140cb2
Showing
2 changed files
with
4 additions
and
39 deletions
1 | -/* | ||
2 | - * Copyright 2015 Open Networking Laboratory | ||
3 | - * | ||
4 | - * Licensed under the Apache License, Version 2.0 (the "License"); | ||
5 | - * you may not use this file except in compliance with the License. | ||
6 | - * You may obtain a copy of the License at | ||
7 | - * | ||
8 | - * http://www.apache.org/licenses/LICENSE-2.0 | ||
9 | - * | ||
10 | - * Unless required by applicable law or agreed to in writing, software | ||
11 | - * distributed under the License is distributed on an "AS IS" BASIS, | ||
12 | - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
13 | - * See the License for the specific language governing permissions and | ||
14 | - * limitations under the License. | ||
15 | - */ | ||
16 | -package org.onosproject.net.intent.impl; | ||
17 | - | ||
18 | -import org.onosproject.net.intent.Intent; | ||
19 | - | ||
20 | -import static com.google.common.base.Preconditions.checkNotNull; | ||
21 | - | ||
22 | -/** | ||
23 | - * A processing phase after compilation failure. | ||
24 | - */ | ||
25 | -class CompilingFailed implements CompletedIntentUpdate { | ||
26 | - | ||
27 | - private final Intent intent; | ||
28 | - | ||
29 | - /** | ||
30 | - * Create an instance from the submitted intent. | ||
31 | - * | ||
32 | - * @param intent submitted intent. | ||
33 | - */ | ||
34 | - CompilingFailed(Intent intent) { | ||
35 | - this.intent = checkNotNull(intent); | ||
36 | - } | ||
37 | -} |
... | @@ -479,10 +479,12 @@ public class IntentManager | ... | @@ -479,10 +479,12 @@ public class IntentManager |
479 | return Optional.of(new Installing(intent, compileIntent(intent, null))); | 479 | return Optional.of(new Installing(intent, compileIntent(intent, null))); |
480 | } catch (PathNotFoundException e) { | 480 | } catch (PathNotFoundException e) { |
481 | log.debug("Path not found for intent {}", intent); | 481 | log.debug("Path not found for intent {}", intent); |
482 | - return Optional.of(new CompilingFailed(intent)); | 482 | + // TODO: revisit to implement failure handling |
483 | + return Optional.of(new DoNothing()); | ||
483 | } catch (IntentException e) { | 484 | } catch (IntentException e) { |
484 | log.warn("Unable to compile intent {} due to:", intent.id(), e); | 485 | log.warn("Unable to compile intent {} due to:", intent.id(), e); |
485 | - return Optional.of(new CompilingFailed(intent)); | 486 | + // TODO: revisit to implement failure handling |
487 | + return Optional.of(new DoNothing()); | ||
486 | } | 488 | } |
487 | } | 489 | } |
488 | } | 490 | } | ... | ... |
-
Please register or login to post a comment