Sho SHIMIZU
Committed by Gerrit Code Review

Make methods of TrafficSelector.Builder deprecated

Because direct use of primitive value like short is fragile against
future change and the methods can be easily replaced by
TrafficSelector.Builder.add(Criterion)

- matchLambda(short)
- matchOpticalSignalType(short)

Change-Id: I0f65605a9bccd77a5d752d3a262ca818234f6ea8
...@@ -297,11 +297,13 @@ public final class DefaultTrafficSelector implements TrafficSelector { ...@@ -297,11 +297,13 @@ public final class DefaultTrafficSelector implements TrafficSelector {
297 return add(Criteria.matchIPv6ExthdrFlags(exthdrFlags)); 297 return add(Criteria.matchIPv6ExthdrFlags(exthdrFlags));
298 } 298 }
299 299
300 + @Deprecated
300 @Override 301 @Override
301 public Builder matchLambda(short lambda) { 302 public Builder matchLambda(short lambda) {
302 return add(Criteria.matchLambda(lambda)); 303 return add(Criteria.matchLambda(lambda));
303 } 304 }
304 305
306 + @Deprecated
305 @Override 307 @Override
306 public Builder matchOpticalSignalType(short signalType) { 308 public Builder matchOpticalSignalType(short signalType) {
307 return add(Criteria.matchOpticalSignalType(signalType)); 309 return add(Criteria.matchOpticalSignalType(signalType));
......
...@@ -313,7 +313,11 @@ public interface TrafficSelector { ...@@ -313,7 +313,11 @@ public interface TrafficSelector {
313 * 313 *
314 * @param lambda lambda 314 * @param lambda lambda
315 * @return a selection builder 315 * @return a selection builder
316 + * @deprecated in Cardinal Release.
317 + * Use {@link #add(Criterion)} with an instance created
318 + * by {@link org.onosproject.net.flow.criteria.Criteria#matchLambda(org.onosproject.net.Lambda)}.
316 */ 319 */
320 + @Deprecated
317 Builder matchLambda(short lambda); 321 Builder matchLambda(short lambda);
318 322
319 /** 323 /**
...@@ -321,7 +325,11 @@ public interface TrafficSelector { ...@@ -321,7 +325,11 @@ public interface TrafficSelector {
321 * 325 *
322 * @param signalType signalType 326 * @param signalType signalType
323 * @return a selection builder 327 * @return a selection builder
328 + * @deprecated in Cardinal Release.
329 + * Use {@link #add(Criterion)}} with an instance created
330 + * by {@link org.onosproject.net.flow.criteria.Criteria#matchOchSignalType(org.onosproject.net.OchSignalType)}.
324 */ 331 */
332 + @Deprecated
325 Builder matchOpticalSignalType(short signalType); 333 Builder matchOpticalSignalType(short signalType);
326 334
327 /** 335 /**
......