Matteo Scandolo
Committed by Gerrit Code Review

Enabling UI live-reload for apps not in the ONOS source code

Change-Id: Ib88929a8825b7adf136d2b6b90d66db10549c165
namespace java org.p4.bmv2.thrift
namespace cpp cpservice
service ControlPlaneService {
bool ping(),
oneway void packetIn(1: i32 port, 2: i64 reason, 3: i32 tableId, 4: i32 contextId, 5: binary packet),
oneway void hello(1: i32 thriftServerPort, 2: i32 deviceId)
}
\ No newline at end of file
namespace java org.p4.bmv2.thrift
/* Copyright 2013-present Barefoot Networks, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
/*
* Antonin Bas (antonin@barefootnetworks.com)
*
*/
namespace cpp bm_runtime.simple_pre
namespace py bm_runtime.simple_pre
typedef i32 BmMcMgrp
typedef i32 BmMcRid
typedef i32 BmMcMgrpHandle
typedef i32 BmMcL1Handle
typedef string BmMcPortMap // string of 0s and 1s
enum McOperationErrorCode {
TABLE_FULL = 1,
INVALID_HANDLE = 2,
INVALID_MGID = 3,
INVALID_L1_HANDLE = 4,
INVALID_L2_HANLDE = 5,
ERROR = 6
}
exception InvalidMcOperation {
1:McOperationErrorCode code
}
service SimplePre {
BmMcMgrpHandle bm_mc_mgrp_create(
1:i32 cxt_id,
2:BmMcMgrp mgrp
) throws (1:InvalidMcOperation ouch),
void bm_mc_mgrp_destroy(
1:i32 cxt_id,
2:BmMcMgrpHandle mgrp_handle
) throws (1:InvalidMcOperation ouch),
BmMcL1Handle bm_mc_node_create(
1:i32 cxt_id,
2:BmMcRid rid
3:BmMcPortMap port_map
) throws (1:InvalidMcOperation ouch),
void bm_mc_node_associate(
1:i32 cxt_id,
2:BmMcMgrpHandle mgrp_handle,
3:BmMcL1Handle l1_handle
) throws (1:InvalidMcOperation ouch),
void bm_mc_node_dissociate(
1:i32 cxt_id,
2:BmMcMgrpHandle mgrp_handle,
3:BmMcL1Handle l1_handle
) throws (1:InvalidMcOperation ouch),
void bm_mc_node_destroy(
1:i32 cxt_id,
2:BmMcL1Handle l1_handle
) throws (1:InvalidMcOperation ouch),
void bm_mc_node_update(
1:i32 cxt_id,
2:BmMcL1Handle l1_handle,
3:BmMcPortMap port_map
) throws (1:InvalidMcOperation ouch),
}
namespace java org.p4.bmv2.thrift
/* Copyright 2013-present Barefoot Networks, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
/*
* Srikrishna Gopu (krishna@barefootnetworks.com)
* Antonin Bas (antonin@barefootnetworks.com)
*
*/
namespace cpp bm_runtime.simple_pre_lag
namespace py bm_runtime.simple_pre_lag
typedef i32 BmMcMgrp
typedef i32 BmMcRid
typedef i32 BmMcMgrpHandle
typedef i32 BmMcL1Handle
typedef i16 BmMcLagIndex
typedef string BmMcPortMap // string of 0s and 1s
typedef string BmMcLagMap // string of 0s and 1s
enum McOperationErrorCode {
TABLE_FULL = 1,
INVALID_HANDLE = 2,
INVALID_MGID = 3,
INVALID_L1_HANDLE = 4,
INVALID_L2_HANLDE = 5,
ERROR = 6
}
exception InvalidMcOperation {
1:McOperationErrorCode code
}
service SimplePreLAG {
BmMcMgrpHandle bm_mc_mgrp_create(
1:i32 cxt_id,
2:BmMcMgrp mgrp
) throws (1:InvalidMcOperation ouch),
void bm_mc_mgrp_destroy(
1:i32 cxt_id,
2:BmMcMgrpHandle mgrp_handle
) throws (1:InvalidMcOperation ouch),
BmMcL1Handle bm_mc_node_create(
1:i32 cxt_id,
2:BmMcRid rid,
3:BmMcPortMap port_map,
4:BmMcLagMap lag_map
) throws (1:InvalidMcOperation ouch),
void bm_mc_node_associate(
1:i32 cxt_id,
2:BmMcMgrpHandle mgrp_handle,
3:BmMcL1Handle l1_handle
) throws (1:InvalidMcOperation ouch),
void bm_mc_node_dissociate(
1:i32 cxt_id,
2:BmMcMgrpHandle mgrp_handle,
3:BmMcL1Handle l1_handle
) throws (1:InvalidMcOperation ouch),
void bm_mc_node_destroy(
1:i32 cxt_id,
2:BmMcL1Handle l1_handle
) throws (1:InvalidMcOperation ouch),
void bm_mc_node_update(
1:i32 cxt_id,
2:BmMcL1Handle l1_handle,
3:BmMcPortMap port_map,
4:BmMcLagMap lag_map
) throws (1:InvalidMcOperation ouch),
void bm_mc_set_lag_membership(
1:i32 cxt_id,
2:BmMcLagIndex lag_index,
3:BmMcPortMap port_map
) throws (1:InvalidMcOperation ouch),
}
namespace java org.p4.bmv2.thrift
/* Copyright 2013-present Barefoot Networks, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
/*
* Antonin Bas (antonin@barefootnetworks.com)
*
*/
namespace cpp sswitch_runtime
namespace py sswitch_runtime
service SimpleSwitch {
i32 mirroring_mapping_add(1:i32 mirror_id, 2:i32 egress_port);
i32 mirroring_mapping_delete(1:i32 mirror_id);
i32 mirroring_mapping_get_egress_port(1:i32 mirror_id);
i32 set_egress_queue_depth(1:i32 depth_pkts);
i32 set_egress_queue_rate(1:i64 rate_pps);
oneway void push_packet(1:i32 port, 2:binary packet);
bool ping();
}
This diff is collapsed. Click to expand it.
......@@ -26,4 +26,17 @@ Dev server is up and listening on http://localhost: 8182
[BS] Watching files...
```
To open ONOS visit the local URL (eg: `http://localhost:3000`) plus `/onos/ui` (eg: `http://localhost:3000/onos/ui`)
\ No newline at end of file
To open ONOS visit the local URL (eg: `http://localhost:3000`) plus `/onos/ui`
(eg: `http://localhost:3000/onos/ui`)
## Loading files from external applications
The UI development environment provide the ability to serve UI files
from an external forlder that can be specified with:
`ONOS_EXTERNAL_APP_DIRS="appName:path-to-the-first-folder" npm start`
Eg:
`ONOS_EXTERNAL_APP_DIRS="sampleCustom:../../meow/sample/meowster-sample/" npm start`
_Note that `ONOS_EXTERNAL_APP_DIRS` is an environment variable,so it can be set with_
_`export ONOS_EXTERNAL_APP_DIRS="sampleCustom:../../meow/sample/meowster-sample/"`_
\ No newline at end of file
......
......@@ -19,15 +19,38 @@ var proxy = httpProxy.createProxyServer({
target: 'http://localhost:8182',
});
if (process.env.ONOS_EXTERNAL_APP_DIRS) {
var external_apps = process.env.ONOS_EXTERNAL_APP_DIRS.replace(/\s/,'').split(',');
external_apps = external_apps.reduce(function(dict, app){
var pieces = app.split(':');
var appName = pieces[0];
var appPath = pieces[1];
dict[appName] = appPath;
return dict;
}, {});
}
var defaultViews = fs.readdirSync('./app/view/');
var viewNameMatcher = new RegExp(/\/onos\/ui\/app\/view\/(.+)\/.+\.(?:js|css|html)/);
var checkExternalApp = function (url) {
if(external_apps){
for(var i = 0; i < Object.keys(external_apps).length; i++){
var key = Object.keys(external_apps)[i];
if(url.indexOf(key) !== -1){
return key;
};
}
}
return false;
};
proxy.on('upgrade', function (req, socket, head) {
console.log('[WS]: ', head);
proxy.ws(req, socket, head);
});
proxy.on('error', function(error, req, res) {
proxy.on('error', function (error, req, res) {
res.writeHead(500, {
'Content-Type': 'text/plain'
});
......@@ -50,21 +73,29 @@ module.exports = {
proxy: {
target: "http://localhost:8181",
ws: true,
middleware: function(req, res, next){
middleware: function (req, res, next) {
var viewName = viewNameMatcher.exec(req.url);
if(!!viewName && defaultViews.indexOf(viewName[1]) === -1){
// in this case it is an external application that extend the view
var isExternalApp = checkExternalApp(req.url);
if (!!viewName && !isExternalApp && defaultViews.indexOf(viewName[1]) === -1) {
// in this case it is an application that extend the view
// so we redirect the request to the app folder in case of .js, .css, .html
req.url = req.url.replace('/onos/ui/', '/apps/' + viewName[1] + '/app/src/main/resources/');
proxy.web(req, res);
}
else if (isExternalApp) {
// in this case it is an external application (not in ONOS source code) that extend the view
// so we redirect the request to the app folder in case of .js, .css, .html
req.url = req.url.replace('/onos/ui/', '/src/main/resources/');
proxy.web(req, res);
}
// NOTE onos.js and index.html should not be proxied (require server side injection)
else if(req.url.match(/(?:js|css|html)/) && req.url !== '/onos/ui/onos.js' && req.url !== '/onos/ui/index.html' && req.url !== '/onos/ui/nav.html'){
else if (req.url.match(/(?:js|css|html)/) && req.url !== '/onos/ui/onos.js' &&
req.url !== '/onos/ui/index.html' && req.url !== '/onos/ui/nav.html') {
// redirect onos base js files to the source folder
req.url = req.url.replace('/onos/ui/', '/web/gui/src/main/webapp/');
proxy.web(req, res);
proxy.web(req, res);
}
else {
return next();
......
'use strict';
var http = require('http');
// var httpProxy = require('http-proxy');
var connect = require('connect');
var serveStatic = require('serve-static');
var path = require('path');
var express = require('express');
var app = express();
var conf = {
paths: {
......@@ -13,17 +11,31 @@ var conf = {
port: '8182'
}
var httpProxyInit = function (baseDir) {
if (process.env.ONOS_EXTERNAL_APP_DIRS) {
var external_apps = process.env.ONOS_EXTERNAL_APP_DIRS.replace(/\s/,'').split(',');
external_apps.forEach(function(a, i){
let [appName, appPath] = a.split(':');
conf.paths[appName] = appPath;
});
}
var app = connect();
var httpProxyInit = function (baseDirs) {
app.use(serveStatic(path.join(__dirname, baseDir)));
Object.keys(baseDirs).forEach(dir => {
var d = path.isAbsolute(baseDirs[dir]) ? baseDirs[dir] : path.join(__dirname, baseDirs[dir]);
app.use(express.static(d));
});
var server = http.createServer(app);
app.get('/', function (req, res) {
res.send('Hello World!');
});
server.listen(conf.port, function(){
console.log('Dev server is up and listening on http://localhost:', conf.port);
app.listen(conf.port, function () {
console.log(`Dev server is up and listening on http://localhost:${conf.port}!`);
});
};
httpProxyInit(conf.paths.root);
\ No newline at end of file
httpProxyInit(conf.paths);
......
......@@ -7,17 +7,16 @@
"test": "tests"
},
"scripts": {
"bs": "browser-sync start --config bs-config.js",
"dev-server": "node dev_server.js",
"bs": "browser-sync start --config bs-config.js",
"dev-server": "node --harmony_destructuring dev_server.js",
"start": "parallelshell \"npm run dev-server\" \"npm run bs\""
},
"author": "ON.Lab",
"license": "Apache 2.0",
"devDependencies": {
"browser-sync": "^2.12.8",
"connect": "^3.4.1",
"http-proxy": "^1.13.2",
"parallelshell": "^2.0.0",
"serve-static": "^1.10.2"
"serve-static": "^1.10.2",
"express": "^4.14.0"
}
}
......