Committed by
Gerrit Code Review
Fix comments
- Delete obsolete TODO comment - Write Javadoc for IntentUpdate subclasses which have no Javadoc Change-Id: I2b233fa9741733fd3642bbbe639990b1ce0b7405
Showing
4 changed files
with
12 additions
and
1 deletions
| ... | @@ -26,6 +26,9 @@ import java.util.Optional; | ... | @@ -26,6 +26,9 @@ import java.util.Optional; |
| 26 | 26 | ||
| 27 | import static com.google.common.base.Preconditions.checkNotNull; | 27 | import static com.google.common.base.Preconditions.checkNotNull; |
| 28 | 28 | ||
| 29 | +/** | ||
| 30 | + * Represents a phase where an intent is being compiled. | ||
| 31 | + */ | ||
| 29 | class Compiling implements IntentUpdate { | 32 | class Compiling implements IntentUpdate { |
| 30 | 33 | ||
| 31 | private static final Logger log = LoggerFactory.getLogger(Compiling.class); | 34 | private static final Logger log = LoggerFactory.getLogger(Compiling.class); | ... | ... |
| ... | @@ -21,7 +21,9 @@ import java.util.Optional; | ... | @@ -21,7 +21,9 @@ import java.util.Optional; |
| 21 | 21 | ||
| 22 | import static com.google.common.base.Preconditions.checkNotNull; | 22 | import static com.google.common.base.Preconditions.checkNotNull; |
| 23 | 23 | ||
| 24 | -// TODO pull out the IntentUpdate inner classes | 24 | +/** |
| 25 | + * Represents a phase where intent installation has been requested. | ||
| 26 | + */ | ||
| 25 | class InstallRequest implements IntentUpdate { | 27 | class InstallRequest implements IntentUpdate { |
| 26 | 28 | ||
| 27 | // TODO: define an interface and use it, instead of IntentManager | 29 | // TODO: define an interface and use it, instead of IntentManager | ... | ... |
| ... | @@ -20,6 +20,9 @@ import org.onosproject.net.intent.IntentData; | ... | @@ -20,6 +20,9 @@ import org.onosproject.net.intent.IntentData; |
| 20 | import static com.google.common.base.Preconditions.checkNotNull; | 20 | import static com.google.common.base.Preconditions.checkNotNull; |
| 21 | import static org.onosproject.net.intent.IntentState.INSTALLING; | 21 | import static org.onosproject.net.intent.IntentState.INSTALLING; |
| 22 | 22 | ||
| 23 | +/** | ||
| 24 | + * Represent a phase where an intent has been installed. | ||
| 25 | + */ | ||
| 23 | class Installed extends CompletedIntentUpdate { | 26 | class Installed extends CompletedIntentUpdate { |
| 24 | 27 | ||
| 25 | private final IntentData intentData; | 28 | private final IntentData intentData; | ... | ... |
| ... | @@ -21,6 +21,9 @@ import org.onosproject.net.intent.IntentState; | ... | @@ -21,6 +21,9 @@ import org.onosproject.net.intent.IntentState; |
| 21 | import static com.google.common.base.Preconditions.checkNotNull; | 21 | import static com.google.common.base.Preconditions.checkNotNull; |
| 22 | import static org.onosproject.net.intent.IntentState.WITHDRAWING; | 22 | import static org.onosproject.net.intent.IntentState.WITHDRAWING; |
| 23 | 23 | ||
| 24 | +/** | ||
| 25 | + * Represents a phase where an intent has been withdrawn. | ||
| 26 | + */ | ||
| 24 | class Withdrawn extends CompletedIntentUpdate { | 27 | class Withdrawn extends CompletedIntentUpdate { |
| 25 | 28 | ||
| 26 | private final IntentData intentData; | 29 | private final IntentData intentData; | ... | ... |
-
Please register or login to post a comment