홍길동 / onos

Go to a project
Toggle navigation Toggle navigation pinning
Heedo Kang
Committed by Gerrit Code Review
d8241c7d 1 parent 609cf87e

SM-ONOS performance improvement 

Change-Id: Ieefb3cc3da34b2080e41b40e6f09ac5570a3079b
Inline Side-by-side
Showing 1 changed file with 6 additions and 40 deletions
......@@ -18,23 +18,18 @@ package org.onosproject.security;
import java.security.AccessController;
import java.security.AccessControlContext;
import java.security.PrivilegedAction;
import java.security.ProtectionDomain;
import com.google.common.annotations.Beta;
import com.google.common.cache.Cache;
import com.google.common.cache.CacheBuilder;
import java.lang.reflect.Field;
import java.util.concurrent.ExecutionException;
import java.util.concurrent.TimeUnit;
/**
* Aids SM-ONOS to perform API-level permission checking.
*/
@Beta
public final class AppGuard {
private AppGuard() {
}
/**
......@@ -43,46 +38,19 @@ public final class AppGuard {
* @param permission permission to be checked
*/
public static void checkPermission(AppPermission.Type permission) {
SecurityManager sm = System.getSecurityManager();
if (sm == null) {
return;
}
Object result = AccessController.doPrivileged((PrivilegedAction<Object>) () -> {
int contextHash = 0;
AccessControlContext context = AccessController.getContext();
Field f = null;
try {
f = context.getClass().getDeclaredField("context");
f.setAccessible(true);
ProtectionDomain[] domain = (ProtectionDomain[]) f.get(context);
for (ProtectionDomain pd : domain) {
if (pd.getCodeSource() != null) {
contextHash = contextHash ^ pd.getCodeSource().getLocation().hashCode();
} else {
return null;
}
}
return contextHash;
} catch (NoSuchFieldException e) {
return null;
} catch (IllegalAccessException e) {
return null;
}
});
if (result == null) {
sm.checkPermission(new AppPermission(permission));
AccessControlContext context = AccessController.getContext();
if (context == null) {
sm.checkPermission(new AppPermission((permission)));
} else {
AppPermission perm = new AppPermission(permission);
int hash = ((int) result) ^ perm.hashCode();
PermissionCheckCache.getInstance().checkCache(hash, perm);
int contextHash = context.hashCode() ^ permission.hashCode();
PermissionCheckCache.getInstance().checkCache(contextHash, new AppPermission(permission));
}
}
private static final class PermissionCheckCache {
private static final Cache<Integer, Boolean> CACHE = CacheBuilder.newBuilder()
......@@ -112,6 +80,4 @@ public final class AppGuard {
}
}
}
}
......