Committed by
Gerrit Code Review
[Code Review] PCEP Report message min length should be 18 & PCE web java doc
Change-Id: I62046aeed2e75b666d85dfedbc7b1c1ba9ad9570
Showing
2 changed files
with
10 additions
and
4 deletions
... | @@ -31,14 +31,20 @@ public class PceWebLink extends BiLink { | ... | @@ -31,14 +31,20 @@ public class PceWebLink extends BiLink { |
31 | 31 | ||
32 | private boolean primary; | 32 | private boolean primary; |
33 | private boolean secondary; | 33 | private boolean secondary; |
34 | + | ||
34 | /** | 35 | /** |
35 | - * Initialize the Link key attributes. | 36 | + * Initialize the Link and key attributes. |
37 | + * @param key the link key identifier | ||
38 | + * @param link the link to be highlighted. | ||
36 | */ | 39 | */ |
37 | public PceWebLink(LinkKey key, Link link) { | 40 | public PceWebLink(LinkKey key, Link link) { |
38 | super(key, link); | 41 | super(key, link); |
39 | } | 42 | } |
40 | - /** | 43 | + |
44 | + /** | ||
41 | * Highlight the color of given selected links. | 45 | * Highlight the color of given selected links. |
46 | + * @param selectedLinks the primary links | ||
47 | + * @param allLinks the secondary links | ||
42 | */ | 48 | */ |
43 | public void computeHilight(Set<Link> selectedLinks, Set<Link> allLinks) { | 49 | public void computeHilight(Set<Link> selectedLinks, Set<Link> allLinks) { |
44 | primary = selectedLinks.contains(this.one()) || | 50 | primary = selectedLinks.contains(this.one()) || | ... | ... |
... | @@ -65,8 +65,8 @@ class PcepReportMsgVer1 implements PcepReportMsg { | ... | @@ -65,8 +65,8 @@ class PcepReportMsgVer1 implements PcepReportMsg { |
65 | protected static final Logger log = LoggerFactory.getLogger(PcepReportMsgVer1.class); | 65 | protected static final Logger log = LoggerFactory.getLogger(PcepReportMsgVer1.class); |
66 | 66 | ||
67 | public static final byte PACKET_VERSION = 1; | 67 | public static final byte PACKET_VERSION = 1; |
68 | - //PACKET_MINIMUM_LENGTH = CommonHeaderLen(4)+LspObjMinLen(8)+EroObjMinLen(12) | 68 | + //PACKET_MINIMUM_LENGTH = CommonHeaderLen(4)+LspObjMinLen(8)+EroObjMinLen(4) |
69 | - public static final int PACKET_MINIMUM_LENGTH = 24; | 69 | + public static final int PACKET_MINIMUM_LENGTH = 16; |
70 | public static final PcepType MSG_TYPE = PcepType.REPORT; | 70 | public static final PcepType MSG_TYPE = PcepType.REPORT; |
71 | public static final byte REPORT_OBJ_TYPE = 1; | 71 | public static final byte REPORT_OBJ_TYPE = 1; |
72 | //Optional TLV | 72 | //Optional TLV | ... | ... |
-
Please register or login to post a comment