홍길동 / onos

Go to a project
Toggle navigation Toggle navigation pinning
Jonathan Hart
Committed by Gerrit Code Review
e9ef4f3f 1 parent 7dd4a33d

Changed TODOs to NOTEs 

Change-Id: I17a0f5099bd6931c50189794596c742f6ddc5b5a
Inline Side-by-side
Showing 2 changed files with 8 additions and 8 deletions
......@@ -20,10 +20,10 @@ import static com.google.common.base.Preconditions.checkNotNull;
import java.util.ArrayList;
import java.util.Objects;
import org.onosproject.sdnip.RouteEntry;
import org.onosproject.sdnip.bgp.BgpConstants.Update;
import org.onlab.packet.Ip4Address;
import org.onlab.packet.Ip4Prefix;
import org.onosproject.sdnip.RouteEntry;
import org.onosproject.sdnip.bgp.BgpConstants.Update;
import com.google.common.base.MoreObjects;
......@@ -175,7 +175,7 @@ public class BgpRouteEntry extends RouteEntry {
}
if (firstPathSegment.getSegmentAsNumbers().isEmpty()) {
// TODO: Shouldn't happen. Should check during the parsing.
// NOTE: Shouldn't happen. Should check during the parsing.
return BgpConstants.BGP_AS_0;
}
return firstPathSegment.getSegmentAsNumbers().get(0);
......@@ -381,7 +381,7 @@ public class BgpRouteEntry extends RouteEntry {
case Update.AsPath.AS_CONFED_SET:
break; // Ignore
default:
// TODO: What to do if the Path Segment type is unknown?
// NOTE: What to do if the Path Segment type is unknown?
break;
}
}
......
......@@ -38,13 +38,13 @@ import org.jboss.netty.util.HashedWheelTimer;
import org.jboss.netty.util.Timeout;
import org.jboss.netty.util.Timer;
import org.jboss.netty.util.TimerTask;
import org.onlab.packet.Ip4Address;
import org.onlab.packet.Ip4Prefix;
import org.onosproject.sdnip.bgp.BgpConstants.Notifications;
import org.onosproject.sdnip.bgp.BgpConstants.Notifications.HoldTimerExpired;
import org.onosproject.sdnip.bgp.BgpConstants.Notifications.MessageHeaderError;
import org.onosproject.sdnip.bgp.BgpConstants.Notifications.OpenMessageError;
import org.onosproject.sdnip.bgp.BgpConstants.Notifications.UpdateMessageError;
import org.onlab.packet.Ip4Address;
import org.onlab.packet.Ip4Prefix;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
......@@ -444,7 +444,7 @@ public class BgpSession extends SimpleChannelHandler {
closeSession(ctx);
return;
}
// TODO: Parse the optional parameters (if needed)
// NOTE: Parse the optional parameters (if needed)
message.readBytes(optParamLen); // NOTE: data ignored
//
......@@ -727,7 +727,7 @@ public class BgpSession extends SimpleChannelHandler {
break;
default:
// TODO: Parse any new Attribute Types if needed
// NOTE: Parse any new Attribute Types if needed
if (!optionalBit) {
// ERROR: Unrecognized Well-known Attribute
actionsBgpUpdateUnrecognizedWellKnownAttribute(
......