홍길동 / onos

Go to a project
Toggle navigation Toggle navigation pinning
Jonathan Hart
Committed by Gerrit Code Review
e9ef4f3f 1 parent 7dd4a33d

Changed TODOs to NOTEs 

Change-Id: I17a0f5099bd6931c50189794596c742f6ddc5b5a
Inline Side-by-side
Showing 2 changed files with 8 additions and 8 deletions
...@@ -20,10 +20,10 @@ import static com.google.common.base.Preconditions.checkNotNull; ...@@ -20,10 +20,10 @@ import static com.google.common.base.Preconditions.checkNotNull;
20 import java.util.ArrayList; 20 import java.util.ArrayList;
21 import java.util.Objects; 21 import java.util.Objects;
22 22
23 -import org.onosproject.sdnip.RouteEntry;
24 -import org.onosproject.sdnip.bgp.BgpConstants.Update;
25 import org.onlab.packet.Ip4Address; 23 import org.onlab.packet.Ip4Address;
26 import org.onlab.packet.Ip4Prefix; 24 import org.onlab.packet.Ip4Prefix;
25 +import org.onosproject.sdnip.RouteEntry;
26 +import org.onosproject.sdnip.bgp.BgpConstants.Update;
27 27
28 import com.google.common.base.MoreObjects; 28 import com.google.common.base.MoreObjects;
29 29
...@@ -175,7 +175,7 @@ public class BgpRouteEntry extends RouteEntry { ...@@ -175,7 +175,7 @@ public class BgpRouteEntry extends RouteEntry {
175 } 175 }
176 176
177 if (firstPathSegment.getSegmentAsNumbers().isEmpty()) { 177 if (firstPathSegment.getSegmentAsNumbers().isEmpty()) {
178 - // TODO: Shouldn't happen. Should check during the parsing. 178 + // NOTE: Shouldn't happen. Should check during the parsing.
179 return BgpConstants.BGP_AS_0; 179 return BgpConstants.BGP_AS_0;
180 } 180 }
181 return firstPathSegment.getSegmentAsNumbers().get(0); 181 return firstPathSegment.getSegmentAsNumbers().get(0);
...@@ -381,7 +381,7 @@ public class BgpRouteEntry extends RouteEntry { ...@@ -381,7 +381,7 @@ public class BgpRouteEntry extends RouteEntry {
381 case Update.AsPath.AS_CONFED_SET: 381 case Update.AsPath.AS_CONFED_SET:
382 break; // Ignore 382 break; // Ignore
383 default: 383 default:
384 - // TODO: What to do if the Path Segment type is unknown? 384 + // NOTE: What to do if the Path Segment type is unknown?
385 break; 385 break;
386 } 386 }
387 } 387 }
......
...@@ -38,13 +38,13 @@ import org.jboss.netty.util.HashedWheelTimer; ...@@ -38,13 +38,13 @@ import org.jboss.netty.util.HashedWheelTimer;
38 import org.jboss.netty.util.Timeout; 38 import org.jboss.netty.util.Timeout;
39 import org.jboss.netty.util.Timer; 39 import org.jboss.netty.util.Timer;
40 import org.jboss.netty.util.TimerTask; 40 import org.jboss.netty.util.TimerTask;
41 +import org.onlab.packet.Ip4Address;
42 +import org.onlab.packet.Ip4Prefix;
41 import org.onosproject.sdnip.bgp.BgpConstants.Notifications; 43 import org.onosproject.sdnip.bgp.BgpConstants.Notifications;
42 import org.onosproject.sdnip.bgp.BgpConstants.Notifications.HoldTimerExpired; 44 import org.onosproject.sdnip.bgp.BgpConstants.Notifications.HoldTimerExpired;
43 import org.onosproject.sdnip.bgp.BgpConstants.Notifications.MessageHeaderError; 45 import org.onosproject.sdnip.bgp.BgpConstants.Notifications.MessageHeaderError;
44 import org.onosproject.sdnip.bgp.BgpConstants.Notifications.OpenMessageError; 46 import org.onosproject.sdnip.bgp.BgpConstants.Notifications.OpenMessageError;
45 import org.onosproject.sdnip.bgp.BgpConstants.Notifications.UpdateMessageError; 47 import org.onosproject.sdnip.bgp.BgpConstants.Notifications.UpdateMessageError;
46 -import org.onlab.packet.Ip4Address;
47 -import org.onlab.packet.Ip4Prefix;
48 import org.slf4j.Logger; 48 import org.slf4j.Logger;
49 import org.slf4j.LoggerFactory; 49 import org.slf4j.LoggerFactory;
50 50
...@@ -444,7 +444,7 @@ public class BgpSession extends SimpleChannelHandler { ...@@ -444,7 +444,7 @@ public class BgpSession extends SimpleChannelHandler {
444 closeSession(ctx); 444 closeSession(ctx);
445 return; 445 return;
446 } 446 }
447 - // TODO: Parse the optional parameters (if needed) 447 + // NOTE: Parse the optional parameters (if needed)
448 message.readBytes(optParamLen); // NOTE: data ignored 448 message.readBytes(optParamLen); // NOTE: data ignored
449 449
450 // 450 //
...@@ -727,7 +727,7 @@ public class BgpSession extends SimpleChannelHandler { ...@@ -727,7 +727,7 @@ public class BgpSession extends SimpleChannelHandler {
727 break; 727 break;
728 728
729 default: 729 default:
730 - // TODO: Parse any new Attribute Types if needed 730 + // NOTE: Parse any new Attribute Types if needed
731 if (!optionalBit) { 731 if (!optionalBit) {
732 // ERROR: Unrecognized Well-known Attribute 732 // ERROR: Unrecognized Well-known Attribute
733 actionsBgpUpdateUnrecognizedWellKnownAttribute( 733 actionsBgpUpdateUnrecognizedWellKnownAttribute(
......