Committed by
Gerrit Code Review
bugfix: equals comparing a field with itself
Change-Id: I02df9a7ca3788bf736edb89e39215992e2d6c375
Showing
3 changed files
with
3 additions
and
3 deletions
| ... | @@ -241,7 +241,7 @@ public class PIMAddrGroup { | ... | @@ -241,7 +241,7 @@ public class PIMAddrGroup { |
| 241 | return false; | 241 | return false; |
| 242 | } | 242 | } |
| 243 | final PIMAddrGroup other = (PIMAddrGroup) obj; | 243 | final PIMAddrGroup other = (PIMAddrGroup) obj; |
| 244 | - if (this.family != this.family) { | 244 | + if (this.family != other.family) { |
| 245 | return false; | 245 | return false; |
| 246 | } | 246 | } |
| 247 | 247 | ... | ... |
| ... | @@ -265,7 +265,7 @@ public class PIMAddrSource { | ... | @@ -265,7 +265,7 @@ public class PIMAddrSource { |
| 265 | return false; | 265 | return false; |
| 266 | } | 266 | } |
| 267 | final PIMAddrSource other = (PIMAddrSource) obj; | 267 | final PIMAddrSource other = (PIMAddrSource) obj; |
| 268 | - if (this.family != this.family) { | 268 | + if (this.family != other.family) { |
| 269 | return false; | 269 | return false; |
| 270 | } | 270 | } |
| 271 | 271 | ... | ... |
| ... | @@ -166,7 +166,7 @@ public class PIMAddrUnicast { | ... | @@ -166,7 +166,7 @@ public class PIMAddrUnicast { |
| 166 | return false; | 166 | return false; |
| 167 | } | 167 | } |
| 168 | final PIMAddrUnicast other = (PIMAddrUnicast) obj; | 168 | final PIMAddrUnicast other = (PIMAddrUnicast) obj; |
| 169 | - if (this.family != this.family) { | 169 | + if (this.family != other.family) { |
| 170 | return false; | 170 | return false; |
| 171 | } | 171 | } |
| 172 | 172 | ... | ... |
-
Please register or login to post a comment