FallibleIteratorTest.cpp
8.4 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
//===- unittests/ADT/FallibleIteratorTest.cpp - fallible_iterator.h tests -===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "llvm/ADT/fallible_iterator.h"
#include "llvm/Testing/Support/Error.h"
#include "gtest/gtest-spi.h"
#include "gtest/gtest.h"
#include <utility>
#include <vector>
using namespace llvm;
namespace {
using ItemValid = enum { ValidItem, InvalidItem };
using LinkValid = enum { ValidLink, InvalidLink };
class Item {
public:
Item(ItemValid V) : V(V) {}
bool isValid() const { return V == ValidItem; }
private:
ItemValid V;
};
// A utility to mock "bad collections". It supports both invalid items,
// where the dereference operator may return an Error, and bad links
// where the inc/dec operations may return an Error.
// Each element of the mock collection contains a pair of a (possibly broken)
// item and link.
using FallibleCollection = std::vector<std::pair<Item, LinkValid>>;
class FallibleCollectionWalker {
public:
FallibleCollectionWalker(FallibleCollection &C, unsigned Idx)
: C(C), Idx(Idx) {}
Item &operator*() { return C[Idx].first; }
const Item &operator*() const { return C[Idx].first; }
Error inc() {
assert(Idx != C.size() && "Walking off end of (mock) collection");
if (C[Idx].second == ValidLink) {
++Idx;
return Error::success();
}
return make_error<StringError>("cant get next object in (mock) collection",
inconvertibleErrorCode());
}
Error dec() {
assert(Idx != 0 && "Walking off start of (mock) collection");
--Idx;
if (C[Idx].second == ValidLink)
return Error::success();
return make_error<StringError>("cant get prev object in (mock) collection",
inconvertibleErrorCode());
}
friend bool operator==(const FallibleCollectionWalker &LHS,
const FallibleCollectionWalker &RHS) {
assert(&LHS.C == &RHS.C && "Comparing iterators across collectionss.");
return LHS.Idx == RHS.Idx;
}
private:
FallibleCollection &C;
unsigned Idx;
};
class FallibleCollectionWalkerWithStructDeref
: public FallibleCollectionWalker {
public:
using FallibleCollectionWalker::FallibleCollectionWalker;
Item *operator->() { return &this->operator*(); }
const Item *operator->() const { return &this->operator*(); }
};
class FallibleCollectionWalkerWithFallibleDeref
: public FallibleCollectionWalker {
public:
using FallibleCollectionWalker::FallibleCollectionWalker;
Expected<Item &> operator*() {
auto &I = FallibleCollectionWalker::operator*();
if (!I.isValid())
return make_error<StringError>("bad item", inconvertibleErrorCode());
return I;
}
Expected<const Item &> operator*() const {
const auto &I = FallibleCollectionWalker::operator*();
if (!I.isValid())
return make_error<StringError>("bad item", inconvertibleErrorCode());
return I;
}
};
TEST(FallibleIteratorTest, BasicSuccess) {
// Check that a basic use-case involing successful iteration over a
// "FallibleCollection" works.
FallibleCollection C({{ValidItem, ValidLink}, {ValidItem, ValidLink}});
FallibleCollectionWalker begin(C, 0);
FallibleCollectionWalker end(C, 2);
Error Err = Error::success();
for (auto &Elem :
make_fallible_range<FallibleCollectionWalker>(begin, end, Err))
EXPECT_TRUE(Elem.isValid());
cantFail(std::move(Err));
}
TEST(FallibleIteratorTest, BasicFailure) {
// Check that a iteration failure (due to the InvalidLink state on element one
// of the fallible collection) breaks out of the loop and raises an Error.
FallibleCollection C({{ValidItem, ValidLink}, {ValidItem, InvalidLink}});
FallibleCollectionWalker begin(C, 0);
FallibleCollectionWalker end(C, 2);
Error Err = Error::success();
for (auto &Elem :
make_fallible_range<FallibleCollectionWalker>(begin, end, Err))
EXPECT_TRUE(Elem.isValid());
EXPECT_THAT_ERROR(std::move(Err), Failed()) << "Expected failure value";
}
TEST(FallibleIteratorTest, NoRedundantErrorCheckOnEarlyExit) {
// Check that an early return from the loop body does not require a redundant
// check of Err.
FallibleCollection C({{ValidItem, ValidLink}, {ValidItem, ValidLink}});
FallibleCollectionWalker begin(C, 0);
FallibleCollectionWalker end(C, 2);
Error Err = Error::success();
for (auto &Elem :
make_fallible_range<FallibleCollectionWalker>(begin, end, Err)) {
(void)Elem;
return;
}
// Err not checked, but should be ok because we exit from the loop
// body.
}
#if LLVM_ENABLE_ABI_BREAKING_CHECKS
TEST(FallibleIteratorTest, RegularLoopExitRequiresErrorCheck) {
// Check that Err must be checked after a normal (i.e. not early) loop exit
// by failing to check and expecting program death (due to the unchecked
// error).
EXPECT_DEATH(
{
FallibleCollection C({{ValidItem, ValidLink}, {ValidItem, ValidLink}});
FallibleCollectionWalker begin(C, 0);
FallibleCollectionWalker end(C, 2);
Error Err = Error::success();
for (auto &Elem :
make_fallible_range<FallibleCollectionWalker>(begin, end, Err))
(void)Elem;
},
"Program aborted due to an unhandled Error:")
<< "Normal (i.e. not early) loop exit should require an error check";
}
#endif
TEST(FallibleIteratorTest, RawIncrementAndDecrementBehavior) {
// Check the exact behavior of increment / decrement.
FallibleCollection C({{ValidItem, ValidLink},
{ValidItem, InvalidLink},
{ValidItem, ValidLink},
{ValidItem, InvalidLink}});
{
// One increment from begin succeeds.
Error Err = Error::success();
auto I = make_fallible_itr(FallibleCollectionWalker(C, 0), Err);
++I;
EXPECT_THAT_ERROR(std::move(Err), Succeeded());
}
{
// Two increments from begin fail.
Error Err = Error::success();
auto I = make_fallible_itr(FallibleCollectionWalker(C, 0), Err);
++I;
EXPECT_THAT_ERROR(std::move(Err), Succeeded());
++I;
EXPECT_THAT_ERROR(std::move(Err), Failed()) << "Expected failure value";
}
{
// One decement from element three succeeds.
Error Err = Error::success();
auto I = make_fallible_itr(FallibleCollectionWalker(C, 3), Err);
--I;
EXPECT_THAT_ERROR(std::move(Err), Succeeded());
}
{
// One decement from element three succeeds.
Error Err = Error::success();
auto I = make_fallible_itr(FallibleCollectionWalker(C, 3), Err);
--I;
EXPECT_THAT_ERROR(std::move(Err), Succeeded());
--I;
EXPECT_THAT_ERROR(std::move(Err), Failed());
}
}
TEST(FallibleIteratorTest, CheckStructDerefOperatorSupport) {
// Check that the fallible_iterator wrapper forwards through to the
// underlying iterator's structure dereference operator if present.
FallibleCollection C({{ValidItem, ValidLink},
{ValidItem, ValidLink},
{InvalidItem, InvalidLink}});
FallibleCollectionWalkerWithStructDeref begin(C, 0);
{
Error Err = Error::success();
auto I = make_fallible_itr(begin, Err);
EXPECT_TRUE(I->isValid());
cantFail(std::move(Err));
}
{
Error Err = Error::success();
const auto I = make_fallible_itr(begin, Err);
EXPECT_TRUE(I->isValid());
cantFail(std::move(Err));
}
}
TEST(FallibleIteratorTest, CheckDerefToExpectedSupport) {
// Check that the fallible_iterator wrapper forwards value types, in
// particular llvm::Expected, correctly.
FallibleCollection C({{ValidItem, ValidLink},
{InvalidItem, ValidLink},
{ValidItem, ValidLink}});
FallibleCollectionWalkerWithFallibleDeref begin(C, 0);
FallibleCollectionWalkerWithFallibleDeref end(C, 3);
Error Err = Error::success();
auto I = make_fallible_itr(begin, Err);
auto E = make_fallible_end(end);
Expected<Item> V1 = *I;
EXPECT_THAT_ERROR(V1.takeError(), Succeeded());
++I;
EXPECT_NE(I, E); // Implicitly check error.
Expected<Item> V2 = *I;
EXPECT_THAT_ERROR(V2.takeError(), Failed());
++I;
EXPECT_NE(I, E); // Implicitly check error.
Expected<Item> V3 = *I;
EXPECT_THAT_ERROR(V3.takeError(), Succeeded());
++I;
EXPECT_EQ(I, E);
cantFail(std::move(Err));
}
} // namespace